From: Daniel Vetter <daniel@ffwll.ch>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: intel-gfx@lists.freedesktop.org, shuang.he@linux.intel.com
Subject: Re: [PATCH 4/4] drm/i915: use current mode if the size matches the preferred mode
Date: Thu, 23 Oct 2014 12:23:53 +0200 [thread overview]
Message-ID: <20141023102353.GE26941@phenom.ffwll.local> (raw)
In-Reply-To: <20141022084232.4b0689b9@jbarnes-hsw>
On Wed, Oct 22, 2014 at 08:42:32AM -0700, Jesse Barnes wrote:
> On Tue, 21 Oct 2014 16:53:02 +0200
> Daniel Vetter <daniel@ffwll.ch> wrote:
>
> > On Thu, Oct 09, 2014 at 12:57:45PM -0700, Jesse Barnes wrote:
> > > From: Kristian Høgsberg <hoegsberg@gmail.com>
> > >
> > > The BIOS may set a native mode that doesn't quite match the preferred
> > > mode timings. It should be ok to use however if it uses the same size,
> > > so try to avoid a mode set in that case.
> > >
> > > Signed-off-by: Kristian Høgsberg <hoegsberg@gmail.com>
> > > Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> >
> > Why exactly does this fail? Is the clock off slightly or are the timings
> > off?
> >
> > I just wonder whether we should check vrefresh to make sure the bios
> > doesn't sneak a low refresh rate mode past us (from stuck drrs or
> > whatever).
> >
> > /me thinking a bit paranoid again.
>
> Yeah you asked this same thing last time. IIRC it's not a lower clock
> rate like DRRS, but rather different timings. But Kristian will have
> to post them.
Yeah, I get points for being consistent! And this time around I didn't
even realize it ;-)
> Kristian, can you please post the mode lines from the EDID on this
> machine and the ones the BIOS sets at boot up?
Yeah, I think we should put the full timing data for the bios and edid
mode into the commit message. That way we can later on inspect the
situation again in case of new kinds of brokeness.
Cheers, Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2014-10-23 10:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-09 19:57 [PATCH 1/4] drm/i915: preserve SSC if previously set v3 Jesse Barnes
2014-10-09 19:57 ` [PATCH 2/4] drm/i915: preserve swizzle settings if necessary v4 Jesse Barnes
2014-10-21 14:49 ` Daniel Vetter
2014-10-30 21:25 ` Jesse Barnes
2014-10-09 19:57 ` [PATCH 3/4] drm: add drm_mode_same_size function Jesse Barnes
2014-10-21 14:49 ` Daniel Vetter
2014-10-22 15:40 ` Jesse Barnes
2014-10-09 19:57 ` [PATCH 4/4] drm/i915: use current mode if the size matches the preferred mode Jesse Barnes
2014-10-10 14:44 ` [PATCH 4/4] drm/i915: use current mode if the size shuang.he
2014-10-21 14:53 ` [PATCH 4/4] drm/i915: use current mode if the size matches the preferred mode Daniel Vetter
2014-10-22 15:42 ` Jesse Barnes
2014-10-23 10:23 ` Daniel Vetter [this message]
2014-11-13 8:42 ` [PATCH 1/4] drm/i915: preserve SSC if previously set v3 Jani Nikula
2014-11-14 9:36 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141023102353.GE26941@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
--cc=shuang.he@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox