From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] lib: fix #define max
Date: Thu, 23 Oct 2014 14:19:49 +0200
Message-ID: <20141023121948.GI26941@phenom.ffwll.local>
References: <1413906580-4840-1-git-send-email-mika.kuoppala@intel.com>
 <87h9ywgdl4.fsf@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-wi0-f178.google.com (mail-wi0-f178.google.com
 [209.85.212.178])
 by gabe.freedesktop.org (Postfix) with ESMTP id 9D8AB6E470
 for <intel-gfx@lists.freedesktop.org>; Thu, 23 Oct 2014 05:19:40 -0700 (PDT)
Received: by mail-wi0-f178.google.com with SMTP id q5so580352wiv.11
 for <intel-gfx@lists.freedesktop.org>; Thu, 23 Oct 2014 05:19:39 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <87h9ywgdl4.fsf@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Wed, Oct 22, 2014 at 09:32:23PM +0300, Jani Nikula wrote:
> On Tue, 21 Oct 2014, Mika Kuoppala <mika.kuoppala@linux.intel.com> wrote:
> > Regression from:
> >
> > commit be4710a541b517b5f8663448bffed5656d59b47b
> > Author: Thomas Wood <thomas.wood@intel.com>
> > Date:   Fri Oct 10 11:20:35 2014 +0100
> >
> >     lib: add common min and max macros
> >
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=85218
> > Tested-by: Guo Jinxian <jinxianx.guo@intel.com>
> > Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>
> 
> Push it already!

To clarify igt process: If you're patch has been sitting on the m-l for a
day or so without objection, just push it. If it's critical (like this
one) and you're confident it's good push right after sending.

Submitting to intel-gfx for igt patches is mostly so that other people can
watch what flies by and drop suggestions for later improvements. And of
course new contributors get the full review treatment to make sure they
use all the nice stuff the testsuite provides properly.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch