Re: [PATCH] drm/i915: Emit even number of dwords when emitting LRIs

Damien Lespiau
2014-10-22T10:54:11Z

On Wed, Oct 22, 2014 at 11:40:30AM +0100, Damien Lespiau wrote:
> On Wed, Oct 22, 2014 at 10:09:49AM +0100, Arun Siluvery wrote:
> > The number of DWords should be even when doing ring emits as
> > command sequences require QWord alignment.
>
> It looks like we could just pad at the end of the batch instead of one
> NOP per register write?
>
> Also, It looks like we could use the LRI variant that can write more
> than one register in one go (separate patch)?.

Note that if you use the multi-register LRI variant, the number of
dwords will always be odd, so we'll always need to pad a NOP, that makes
it easy.

--
Damien