From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Correctly reject invalid flags for wait_ioctl Date: Thu, 23 Oct 2014 16:12:03 +0200 Message-ID: <20141023141203.GN26941@phenom.ffwll.local> References: <1411997486-10716-1-git-send-email-daniel.vetter@ffwll.ch> <20141023133941.GD10367@strange.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wi0-f172.google.com (mail-wi0-f172.google.com [209.85.212.172]) by gabe.freedesktop.org (Postfix) with ESMTP id F37076E3EC for ; Thu, 23 Oct 2014 07:11:54 -0700 (PDT) Received: by mail-wi0-f172.google.com with SMTP id bs8so4249140wib.11 for ; Thu, 23 Oct 2014 07:11:54 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20141023133941.GD10367@strange.ger.corp.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Damien Lespiau Cc: Daniel Vetter , Intel Graphics Development , Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org On Thu, Oct 23, 2014 at 02:39:41PM +0100, Damien Lespiau wrote: > On Thu, Oct 23, 2014 at 03:28:24PM +0200, Daniel Vetter wrote: > > On Mon, Sep 29, 2014 at 3:31 PM, Daniel Vetter wrote: > > > Not having checks for this isn't good. > > > > > > I've checked igt and libdrm and they all already clear flags properly. > > > So we're lucky and should be able to sneak this ABI clarification in. > > > > > > Testcase: igt/gem_wait/invalid-flags > > > Signed-off-by: Daniel Vetter > > > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=85280 > > > > Some please review this little fix? > > Reviewed-by: Damien Lespiau Thanks for the mercy ;-) Patch merged to dinq now. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch