From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 2/2] drm/i915/bdw: Setup global hardware status page in execlists mode Date: Fri, 24 Oct 2014 10:48:43 +0200 Message-ID: <20141024084843.GY26941@phenom.ffwll.local> References: <1414077886-19017-1-git-send-email-thomas.daniel@intel.com> <20141024081451.GT26941@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com [209.85.212.177]) by gabe.freedesktop.org (Postfix) with ESMTP id EC9A06E58D for ; Fri, 24 Oct 2014 01:48:34 -0700 (PDT) Received: by mail-wi0-f177.google.com with SMTP id ex7so689585wid.10 for ; Fri, 24 Oct 2014 01:48:34 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Daniel, Thomas" Cc: "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org On Fri, Oct 24, 2014 at 08:30:56AM +0000, Daniel, Thomas wrote: > > > > -----Original Message----- > > From: Daniel Vetter [mailto:daniel.vetter@ffwll.ch] On Behalf Of Daniel > > Vetter > > Sent: Friday, October 24, 2014 9:15 AM > > To: Daniel, Thomas > > Cc: intel-gfx@lists.freedesktop.org; shuang.he@linux.intel.com > > Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915/bdw: Setup global hardware > > status page in execlists mode > > So every time a random new contexts gets created we write a new value into > > the HWS_PGA register? Shouldn't this only be done when we set up the > > default/system context? > The write is inside an if(ctx == ring->default_ctx) block. > We only write when the default context is created. Hm right, confusing diff context. And I guess we can't move that out to logical_ring_init since it must happen before we init the render ring? I think extracting this entire block into a setup_global_hws or so helper function would be useful for clarity. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch