From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Daniel Vetter <daniel@ffwll.ch>,
intel-gfx@lists.freedesktop.org,
Akash Goel <akash.goel@intel.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH] drm/i915: Report the actual swizzling back to userspace
Date: Mon, 27 Oct 2014 10:08:29 +0100 [thread overview]
Message-ID: <20141027090829.GK26941@phenom.ffwll.local> (raw)
In-Reply-To: <20141024151614.GB24617@nuc-i3427.alporthouse.com>
On Fri, Oct 24, 2014 at 04:16:14PM +0100, Chris Wilson wrote:
> On Fri, Oct 24, 2014 at 04:39:29PM +0200, Daniel Vetter wrote:
> > On Fri, Oct 24, 2014 at 12:11:11PM +0100, Chris Wilson wrote:
> > > Userspace cares about whether or not swizzling depends on the page
> > > address for its direct access into bound objects. Extend the get_tiling
> > > ioctl to report the physical swizzling value in addition to the logical
> > > swizzling value so that userspace can accurately determine when it is
> > > possible for manual detiling.
> > >
> > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > > Cc: Akash Goel <akash.goel@intel.com>
> > > Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> >
> > I wonder whether we should care really, since on gen5+ we know that they
> > agree. Pimp some igt (by skipping if needed) to convince me?
>
> It's for gen2-4... Trivial little change to enable more sharing of code
> paths and speedups.
>
> What type of igt do you want? I personally have never seen a bit17
> swizzling machine, but we know that some do exist due to the bug
> reports.
I've thought of adding the relevant new cases to gem_tiled_pread.c. But
that's for the pread stuff and not cpu mmaps, but copypaste to
gem_tiled_cpu_mmap.c can fix that. And the desktop i915g I have here does
bit17 - without any L-shaped craziness even afaik!
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2014-10-27 9:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-24 11:11 [PATCH] drm/i915: Report the actual swizzling back to userspace Chris Wilson
2014-10-24 14:39 ` Daniel Vetter
2014-10-24 15:16 ` Chris Wilson
2014-10-27 9:08 ` Daniel Vetter [this message]
2014-10-30 10:40 ` Chris Wilson
2014-11-03 11:41 ` Daniel Vetter
2014-11-04 7:29 ` Chris Wilson
2014-11-04 9:40 ` Daniel Vetter
2014-11-04 7:35 ` [PATCH] igt/gem_tiled_wc: Exercise wc mmaps with swizzling Chris Wilson
2014-11-04 9:43 ` Daniel Vetter
2014-11-04 9:50 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141027090829.GK26941@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=akash.goel@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox