From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 11/17] drm/i915: Make sure DPLL is enabled when kicking the power sequencer on VLV/CHV Date: Tue, 28 Oct 2014 09:22:12 +0100 Message-ID: <20141028082212.GC26941@phenom.ffwll.local> References: <1413484055-20669-1-git-send-email-ville.syrjala@linux.intel.com> <1413484185-21127-1-git-send-email-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wg0-f52.google.com (mail-wg0-f52.google.com [74.125.82.52]) by gabe.freedesktop.org (Postfix) with ESMTP id 66C846E3DC for ; Tue, 28 Oct 2014 01:22:01 -0700 (PDT) Received: by mail-wg0-f52.google.com with SMTP id y10so184870wgg.23 for ; Tue, 28 Oct 2014 01:22:00 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1413484185-21127-1-git-send-email-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: ville.syrjala@linux.intel.com Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBPY3QgMTYsIDIwMTQgYXQgMDk6Mjk6NDVQTSArMDMwMCwgdmlsbGUuc3lyamFsYUBs aW51eC5pbnRlbC5jb20gd3JvdGU6Cj4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJq YWxhQGxpbnV4LmludGVsLmNvbT4KPiAKPiBUaGUgcG93ZXIgc2VxZXVlbmNlciBraWNrIHByb2Nl ZHVyZSByZXF1aXJlcyB0aGUgRFBMTCB0byBiZSBydW5uaW5nCj4gaW4gb3JkZXIgdG8gY29tcGxl dGUgc3VjY2VzZnVsbHkuIEluIGNhc2UgdGhlIERQTEwgaXNuJ3QgY3VycmVudGx5Cj4gcnVubmlu ZyB3aGVuIHdlIG5lZWQgdG8ga2ljayB0aGUgcG93ZXIgc2VxZXVuY2VyIGVuYWJsZSBpdAo+IHRl bXBvcmFyaWx5LiBUaGlzIGNhbiBoYXBwZW4gZWcuIGR1cmluZyAtPmRldGVjdCgpIHdoZW4gdGhl IHBpcGUgaXMKPiBub3QgYWxyZWFkeSBhY3RpdmUuCj4gCj4gVG8gYXZvaWQgbmVlZGxlc3NseSBk dXBsaWNhdGluZyB0aGUgRFBMTCBwcm9ncmFtbWluZyByZS11c2UgdGhlIGFscmVhZHkKPiBleGlz dGluZyBmdW5jdGlvbnMgYnkgcGFzc2luZyBhIHRlbXBvcmFyeSBwaXBlIGNvbmZpZyB0byB0aGVt IGluc3RlYWQKPiBvZiBoYXZpbmcgdGhlbSBjb25zdWx0IHRoZSBjdXJyZW50IHBpcGUgY29uZmln IGF0IGNydGMtPmNvbmZpZy4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZp bGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgoKW3NuaXBdCgo+ICsJLyoKPiArCSAqIFRoZSBE UExMIGZvciB0aGUgcGlwZSBtdXN0IGJlIGVuYWJsZWQgZm9yIHRoaXMgdG8gd29yay4KPiArCSAq IFNvIGVuYWJsZSB0ZW1wb3JhcmlseSBpdCBpZiBpdCdzIG5vdCBhbHJlYWR5IGVuYWJsZWQuCj4g KwkgKi8KPiArCWlmICghcGxsX2VuYWJsZWQpIHsKPiArCQlzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0 YyA9Cj4gKwkJCXRvX2ludGVsX2NydGMoZGV2X3ByaXYtPnBpcGVfdG9fY3J0Y19tYXBwaW5nW3Bp cGVdKTsKPiArCQlzdHJ1Y3QgaW50ZWxfY3J0Y19jb25maWcgcGlwZV9jb25maWcgPSB7Cj4gKwkJ CS5waXhlbF9tdWx0aXBsaWVyID0gMSwKPiArCQkJLmRwbGwgPSBJU19DSEVSUllWSUVXKGRldikg Pwo+ICsJCQkJY2h2X2RwbGxbMF0uZHBsbCA6IHZsdl9kcGxsWzBdLmRwbGwsCj4gKwkJCS5wb3J0 X2Nsb2NrID0gMTYyMDAwLAo+ICsJCQkuY2xvY2tfc2V0ID0gdHJ1ZSwKPiArCQkJLmhhc19kcF9l bmNvZGVyID0gdHJ1ZSwKPiArCQl9Owo+ICsKPiArCQlpZiAoSVNfQ0hFUlJZVklFVyhkZXYpKSB7 Cj4gKwkJCWNodl91cGRhdGVfcGxsKGNydGMsICZwaXBlX2NvbmZpZyk7Cj4gKwkJCWNodl9wcmVw YXJlX3BsbChjcnRjLCAmcGlwZV9jb25maWcpOwo+ICsJCQljaHZfZW5hYmxlX3BsbChjcnRjLCAm cGlwZV9jb25maWcpOwo+ICsJCX0gZWxzZSB7Cj4gKwkJCXZsdl91cGRhdGVfcGxsKGNydGMsICZw aXBlX2NvbmZpZyk7Cj4gKwkJCXZsdl9wcmVwYXJlX3BsbChjcnRjLCAmcGlwZV9jb25maWcpOwo+ ICsJCQl2bHZfZW5hYmxlX3BsbChjcnRjLCAmcGlwZV9jb25maWcpOwoKSSdtIG5vdCB0ZXJyaWJs eSBoYXBweSB3aXRoIHRoZSBtYXNzaXZlIGxpc3Qgb2Ygbm9uLXN0YXRpYyBwbGF0Zm9ybQpmdW5j dGlvbnMgdGhpcyBleHBvc2VzLiBBbmQgaXQncyBhbHNvIGZhaXJseSBsZWFreSBzaW5jZSB0aGUg bWluaW1hbCBwaXBlCmNvbmZpZyBkZXBlbmRzIHVwb24gd2hhdCBleGFjdGx5IHRoZSB2bHYvY2h2 IHBsbCBmdW5jdGlvbnMgbmVlZC4KCkNvdWxkIHdlIGluc3RlYWQgaGF2ZSBhIHdyYXBwZXIgZnVu Y3Rpb24gZm9yIGJvdGggdGhlIGVuYWJsZSBhbmQgZGlzYWJsZQp3aGljaCBzaXRzIHJpZ2h0IG5l eHQgdG8gdGhlIHZsdi9jaHYgZHBsbCBjb2RlIGluIGludGVsX2Rpc3BsYXkuYz8gRS5nLgp2YWxs ZXl2aWV3X2ZvcmNlX3BsbF9vbi9vZmYoZGV2LCBwaXBlKSBvciBzb21ldGhpbmcgbGlrZSB0aGF0 LgotRGFuaWVsCgo+ICsJCX0KPiArCX0KPiArCj4gIAkvKgo+ICAJICogU2ltaWxhciBtYWdpYyBh cyBpbiBpbnRlbF9kcF9lbmFibGVfcG9ydCgpLgo+ICAJICogV2UgX211c3RfIGRvIHRoaXMgcG9y dCBlbmFibGUgKyBkaXNhYmxlIHRyaWNrCj4gQEAgLTM2NSw2ICszOTUsMTMgQEAgdmx2X3Bvd2Vy X3NlcXVlbmNlcl9raWNrKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHApCj4gIAo+ICAJSTkxNV9X UklURShpbnRlbF9kcC0+b3V0cHV0X3JlZywgRFAgJiB+RFBfUE9SVF9FTik7Cj4gIAlQT1NUSU5H X1JFQUQoaW50ZWxfZHAtPm91dHB1dF9yZWcpOwo+ICsKPiArCWlmICghcGxsX2VuYWJsZWQpIHsK PiArCQlpZiAoSVNfQ0hFUlJZVklFVyhkZXYpKQo+ICsJCQljaHZfZGlzYWJsZV9wbGwoZGV2X3By aXYsIHBpcGUpOwo+ICsJCWVsc2UKPiArCQkJdmx2X2Rpc2FibGVfcGxsKGRldl9wcml2LCBwaXBl KTsKPiArCX0KPiAgfQo+ICAKPiAgc3RhdGljIGVudW0gcGlwZQo+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2Rydi5oCj4gaW5kZXggZjdiYTFmYy4uNjljOGM1ZiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9kcnYuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2Rydi5oCj4gQEAgLTkxMSw2ICs5MTEsMjEgQEAgdm9pZCBhc3NlcnRfc2hhcmVkX2RwbGwoc3Ry dWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICBzdHJ1Y3QgaW50ZWxfc2hhcmVkX2Rw bGwgKmludGVsX2dldF9zaGFyZWRfZHBsbChzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0Yyk7Cj4gIHZv aWQgaW50ZWxfcHV0X3NoYXJlZF9kcGxsKHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjKTsKPiAgCj4g K3ZvaWQgdmx2X3VwZGF0ZV9wbGwoc3RydWN0IGludGVsX2NydGMgKmNydGMsCj4gKwkJICAgIHN0 cnVjdCBpbnRlbF9jcnRjX2NvbmZpZyAqcGlwZV9jb25maWcpOwo+ICt2b2lkIGNodl91cGRhdGVf cGxsKHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjLAo+ICsJCSAgICBzdHJ1Y3QgaW50ZWxfY3J0Y19j b25maWcgKnBpcGVfY29uZmlnKTsKPiArdm9pZCB2bHZfcHJlcGFyZV9wbGwoc3RydWN0IGludGVs X2NydGMgKmNydGMsCj4gKwkJICAgICBjb25zdCBzdHJ1Y3QgaW50ZWxfY3J0Y19jb25maWcgKnBp cGVfY29uZmlnKTsKPiArdm9pZCBjaHZfcHJlcGFyZV9wbGwoc3RydWN0IGludGVsX2NydGMgKmNy dGMsCj4gKwkJICAgICBjb25zdCBzdHJ1Y3QgaW50ZWxfY3J0Y19jb25maWcgKnBpcGVfY29uZmln KTsKPiArdm9pZCB2bHZfZW5hYmxlX3BsbChzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YywKPiArCQkg ICAgY29uc3Qgc3RydWN0IGludGVsX2NydGNfY29uZmlnICpwaXBlX2NvbmZpZyk7Cj4gK3ZvaWQg Y2h2X2VuYWJsZV9wbGwoc3RydWN0IGludGVsX2NydGMgKmNydGMsCj4gKwkJICAgIGNvbnN0IHN0 cnVjdCBpbnRlbF9jcnRjX2NvbmZpZyAqcGlwZV9jb25maWcpOwo+ICt2b2lkIHZsdl9kaXNhYmxl X3BsbChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsIGVudW0gcGlwZSBwaXBlKTsK PiArdm9pZCBjaHZfZGlzYWJsZV9wbGwoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2 LCBlbnVtIHBpcGUgcGlwZSk7Cj4gKwo+ICAvKiBtb2Rlc2V0dGluZyBhc3NlcnRzICovCj4gIHZv aWQgYXNzZXJ0X3BhbmVsX3VubG9ja2VkKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJp diwKPiAgCQkJICAgZW51bSBwaXBlIHBpcGUpOwo+IC0tIAo+IDIuMC40Cj4gCj4gX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBJbnRlbC1nZnggbWFpbGlu ZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHA6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKCi0tIApEYW5pZWwgVmV0 dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgorNDEgKDApIDc5IDM2NSA1 NyA0OCAtIGh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vaW50ZWwtZ2Z4Cg==