From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 11/17] drm/i915: Make sure DPLL is enabled when kicking the power sequencer on VLV/CHV Date: Tue, 28 Oct 2014 10:27:55 +0200 Message-ID: <20141028082755.GS4284@intel.com> References: <1413484055-20669-1-git-send-email-ville.syrjala@linux.intel.com> <1413484185-21127-1-git-send-email-ville.syrjala@linux.intel.com> <20141028082212.GC26941@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 3653F6E429 for ; Tue, 28 Oct 2014 01:27:59 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20141028082212.GC26941@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBPY3QgMjgsIDIwMTQgYXQgMDk6MjI6MTJBTSArMDEwMCwgRGFuaWVsIFZldHRlciB3 cm90ZToKPiBPbiBUaHUsIE9jdCAxNiwgMjAxNCBhdCAwOToyOTo0NVBNICswMzAwLCB2aWxsZS5z eXJqYWxhQGxpbnV4LmludGVsLmNvbSB3cm90ZToKPiA+IEZyb206IFZpbGxlIFN5cmrDpGzDpCA8 dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gPiAKPiA+IFRoZSBwb3dlciBzZXFldWVu Y2VyIGtpY2sgcHJvY2VkdXJlIHJlcXVpcmVzIHRoZSBEUExMIHRvIGJlIHJ1bm5pbmcKPiA+IGlu IG9yZGVyIHRvIGNvbXBsZXRlIHN1Y2Nlc2Z1bGx5LiBJbiBjYXNlIHRoZSBEUExMIGlzbid0IGN1 cnJlbnRseQo+ID4gcnVubmluZyB3aGVuIHdlIG5lZWQgdG8ga2ljayB0aGUgcG93ZXIgc2VxZXVu Y2VyIGVuYWJsZSBpdAo+ID4gdGVtcG9yYXJpbHkuIFRoaXMgY2FuIGhhcHBlbiBlZy4gZHVyaW5n IC0+ZGV0ZWN0KCkgd2hlbiB0aGUgcGlwZSBpcwo+ID4gbm90IGFscmVhZHkgYWN0aXZlLgo+ID4g Cj4gPiBUbyBhdm9pZCBuZWVkbGVzc2x5IGR1cGxpY2F0aW5nIHRoZSBEUExMIHByb2dyYW1taW5n IHJlLXVzZSB0aGUgYWxyZWFkeQo+ID4gZXhpc3RpbmcgZnVuY3Rpb25zIGJ5IHBhc3NpbmcgYSB0 ZW1wb3JhcnkgcGlwZSBjb25maWcgdG8gdGhlbSBpbnN0ZWFkCj4gPiBvZiBoYXZpbmcgdGhlbSBj b25zdWx0IHRoZSBjdXJyZW50IHBpcGUgY29uZmlnIGF0IGNydGMtPmNvbmZpZy4KPiA+IAo+ID4g U2lnbmVkLW9mZi1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVs LmNvbT4KPiAKPiBbc25pcF0KPiAKPiA+ICsJLyoKPiA+ICsJICogVGhlIERQTEwgZm9yIHRoZSBw aXBlIG11c3QgYmUgZW5hYmxlZCBmb3IgdGhpcyB0byB3b3JrLgo+ID4gKwkgKiBTbyBlbmFibGUg dGVtcG9yYXJpbHkgaXQgaWYgaXQncyBub3QgYWxyZWFkeSBlbmFibGVkLgo+ID4gKwkgKi8KPiA+ ICsJaWYgKCFwbGxfZW5hYmxlZCkgewo+ID4gKwkJc3RydWN0IGludGVsX2NydGMgKmNydGMgPQo+ ID4gKwkJCXRvX2ludGVsX2NydGMoZGV2X3ByaXYtPnBpcGVfdG9fY3J0Y19tYXBwaW5nW3BpcGVd KTsKPiA+ICsJCXN0cnVjdCBpbnRlbF9jcnRjX2NvbmZpZyBwaXBlX2NvbmZpZyA9IHsKPiA+ICsJ CQkucGl4ZWxfbXVsdGlwbGllciA9IDEsCj4gPiArCQkJLmRwbGwgPSBJU19DSEVSUllWSUVXKGRl dikgPwo+ID4gKwkJCQljaHZfZHBsbFswXS5kcGxsIDogdmx2X2RwbGxbMF0uZHBsbCwKPiA+ICsJ CQkucG9ydF9jbG9jayA9IDE2MjAwMCwKPiA+ICsJCQkuY2xvY2tfc2V0ID0gdHJ1ZSwKPiA+ICsJ CQkuaGFzX2RwX2VuY29kZXIgPSB0cnVlLAo+ID4gKwkJfTsKPiA+ICsKPiA+ICsJCWlmIChJU19D SEVSUllWSUVXKGRldikpIHsKPiA+ICsJCQljaHZfdXBkYXRlX3BsbChjcnRjLCAmcGlwZV9jb25m aWcpOwo+ID4gKwkJCWNodl9wcmVwYXJlX3BsbChjcnRjLCAmcGlwZV9jb25maWcpOwo+ID4gKwkJ CWNodl9lbmFibGVfcGxsKGNydGMsICZwaXBlX2NvbmZpZyk7Cj4gPiArCQl9IGVsc2Ugewo+ID4g KwkJCXZsdl91cGRhdGVfcGxsKGNydGMsICZwaXBlX2NvbmZpZyk7Cj4gPiArCQkJdmx2X3ByZXBh cmVfcGxsKGNydGMsICZwaXBlX2NvbmZpZyk7Cj4gPiArCQkJdmx2X2VuYWJsZV9wbGwoY3J0Yywg JnBpcGVfY29uZmlnKTsKPiAKPiBJJ20gbm90IHRlcnJpYmx5IGhhcHB5IHdpdGggdGhlIG1hc3Np dmUgbGlzdCBvZiBub24tc3RhdGljIHBsYXRmb3JtCj4gZnVuY3Rpb25zIHRoaXMgZXhwb3Nlcy4g QW5kIGl0J3MgYWxzbyBmYWlybHkgbGVha3kgc2luY2UgdGhlIG1pbmltYWwgcGlwZQo+IGNvbmZp ZyBkZXBlbmRzIHVwb24gd2hhdCBleGFjdGx5IHRoZSB2bHYvY2h2IHBsbCBmdW5jdGlvbnMgbmVl ZC4KPiAKPiBDb3VsZCB3ZSBpbnN0ZWFkIGhhdmUgYSB3cmFwcGVyIGZ1bmN0aW9uIGZvciBib3Ro IHRoZSBlbmFibGUgYW5kIGRpc2FibGUKPiB3aGljaCBzaXRzIHJpZ2h0IG5leHQgdG8gdGhlIHZs di9jaHYgZHBsbCBjb2RlIGluIGludGVsX2Rpc3BsYXkuYz8gRS5nLgo+IHZhbGxleXZpZXdfZm9y Y2VfcGxsX29uL29mZihkZXYsIHBpcGUpIG9yIHNvbWV0aGluZyBsaWtlIHRoYXQuCgpTdXJlLiBJ J2xsIHJlc3BpbiB0aGlzIHdpdGggdGhhdCBpZGVhLgoKPiAtRGFuaWVsCj4gCj4gPiArCQl9Cj4g PiArCX0KPiA+ICsKPiA+ICAJLyoKPiA+ICAJICogU2ltaWxhciBtYWdpYyBhcyBpbiBpbnRlbF9k cF9lbmFibGVfcG9ydCgpLgo+ID4gIAkgKiBXZSBfbXVzdF8gZG8gdGhpcyBwb3J0IGVuYWJsZSAr IGRpc2FibGUgdHJpY2sKPiA+IEBAIC0zNjUsNiArMzk1LDEzIEBAIHZsdl9wb3dlcl9zZXF1ZW5j ZXJfa2ljayhzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwKQo+ID4gIAo+ID4gIAlJOTE1X1dSSVRF KGludGVsX2RwLT5vdXRwdXRfcmVnLCBEUCAmIH5EUF9QT1JUX0VOKTsKPiA+ICAJUE9TVElOR19S RUFEKGludGVsX2RwLT5vdXRwdXRfcmVnKTsKPiA+ICsKPiA+ICsJaWYgKCFwbGxfZW5hYmxlZCkg ewo+ID4gKwkJaWYgKElTX0NIRVJSWVZJRVcoZGV2KSkKPiA+ICsJCQljaHZfZGlzYWJsZV9wbGwo ZGV2X3ByaXYsIHBpcGUpOwo+ID4gKwkJZWxzZQo+ID4gKwkJCXZsdl9kaXNhYmxlX3BsbChkZXZf cHJpdiwgcGlwZSk7Cj4gPiArCX0KPiA+ICB9Cj4gPiAgCj4gPiAgc3RhdGljIGVudW0gcGlwZQo+ ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmgKPiA+IGluZGV4IGY3YmExZmMuLjY5YzhjNWYgMTAw NjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaAo+ID4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmgKPiA+IEBAIC05MTEsNiArOTExLDIxIEBA IHZvaWQgYXNzZXJ0X3NoYXJlZF9kcGxsKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJp diwKPiA+ICBzdHJ1Y3QgaW50ZWxfc2hhcmVkX2RwbGwgKmludGVsX2dldF9zaGFyZWRfZHBsbChz dHJ1Y3QgaW50ZWxfY3J0YyAqY3J0Yyk7Cj4gPiAgdm9pZCBpbnRlbF9wdXRfc2hhcmVkX2RwbGwo c3RydWN0IGludGVsX2NydGMgKmNydGMpOwo+ID4gIAo+ID4gK3ZvaWQgdmx2X3VwZGF0ZV9wbGwo c3RydWN0IGludGVsX2NydGMgKmNydGMsCj4gPiArCQkgICAgc3RydWN0IGludGVsX2NydGNfY29u ZmlnICpwaXBlX2NvbmZpZyk7Cj4gPiArdm9pZCBjaHZfdXBkYXRlX3BsbChzdHJ1Y3QgaW50ZWxf Y3J0YyAqY3J0YywKPiA+ICsJCSAgICBzdHJ1Y3QgaW50ZWxfY3J0Y19jb25maWcgKnBpcGVfY29u ZmlnKTsKPiA+ICt2b2lkIHZsdl9wcmVwYXJlX3BsbChzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YywK PiA+ICsJCSAgICAgY29uc3Qgc3RydWN0IGludGVsX2NydGNfY29uZmlnICpwaXBlX2NvbmZpZyk7 Cj4gPiArdm9pZCBjaHZfcHJlcGFyZV9wbGwoc3RydWN0IGludGVsX2NydGMgKmNydGMsCj4gPiAr CQkgICAgIGNvbnN0IHN0cnVjdCBpbnRlbF9jcnRjX2NvbmZpZyAqcGlwZV9jb25maWcpOwo+ID4g K3ZvaWQgdmx2X2VuYWJsZV9wbGwoc3RydWN0IGludGVsX2NydGMgKmNydGMsCj4gPiArCQkgICAg Y29uc3Qgc3RydWN0IGludGVsX2NydGNfY29uZmlnICpwaXBlX2NvbmZpZyk7Cj4gPiArdm9pZCBj aHZfZW5hYmxlX3BsbChzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YywKPiA+ICsJCSAgICBjb25zdCBz dHJ1Y3QgaW50ZWxfY3J0Y19jb25maWcgKnBpcGVfY29uZmlnKTsKPiA+ICt2b2lkIHZsdl9kaXNh YmxlX3BsbChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsIGVudW0gcGlwZSBwaXBl KTsKPiA+ICt2b2lkIGNodl9kaXNhYmxlX3BsbChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2 X3ByaXYsIGVudW0gcGlwZSBwaXBlKTsKPiA+ICsKPiA+ICAvKiBtb2Rlc2V0dGluZyBhc3NlcnRz ICovCj4gPiAgdm9pZCBhc3NlcnRfcGFuZWxfdW5sb2NrZWQoc3RydWN0IGRybV9pOTE1X3ByaXZh dGUgKmRldl9wcml2LAo+ID4gIAkJCSAgIGVudW0gcGlwZSBwaXBlKTsKPiA+IC0tIAo+ID4gMi4w LjQKPiA+IAo+ID4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KPiA+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiA+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKPiA+IGh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9pbnRlbC1nZngKPiAKPiAtLSAKPiBEYW5pZWwgVmV0dGVyCj4gU29mdHdhcmUgRW5naW5lZXIs IEludGVsIENvcnBvcmF0aW9uCj4gKzQxICgwKSA3OSAzNjUgNTcgNDggLSBodHRwOi8vYmxvZy5m ZndsbC5jaAoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbCBPVEMKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRl bC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK