Re: [PATCH 0/8] SKL WM fixups

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Tue, Oct 14, 2014 at 05:30:58PM +0100, Damien Lespiau wrote:
> Here's a few patches on top of the original WM series to both address some
> review comments from Ville and disable the transition WMs (because we noticed
> some underruns with them and the code is not quit ready).
> 
> With those, I'm hopeful a few more r-b tags can be given.

> 
> -- 
> Damien
> 
> Damien Lespiau (8):
>   drm/i915/skl: Make 'end' of the DDB allocation entry exclusive

Replied with a comment to this patch

>   drm/i915/skl: Use a more descriptive parameter name in
>     skl_compute_plane_wm()
>   drm/i915/skl: Move the per-latency maximum test earlier

and here too

>   drm/i915/skl: Reduce the number of holes in struct skl_wm_level
>   drm/i915/skl: Move all the WM compute functions in one place
>   drm/i915/skl: Rework when the transition WMs are computed
>   drm/i915/skl: Correctly align skl_compute_plane_wm() arguments
>   drm/i915/skl: Reduce the indentation level in skl_write_wm_values()

The rest seem good to me, so:
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> 
>  drivers/gpu/drm/i915/i915_drv.h |   6 +-
>  drivers/gpu/drm/i915/intel_pm.c | 164 ++++++++++++++++++++++------------------
>  2 files changed, 94 insertions(+), 76 deletions(-)
> 
> -- 
> 1.8.3.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx