Re: [PATCH] drm/i915: Make sample_c messages go faster on Haswell.

Kenneth Graunke
2015-01-06T05:54:55Z

[-- Attachment #1.1: Type: text/plain, Size: 896 bytes --]

On Tuesday, January 06, 2015 01:11:53 PM Xiang, Haihao wrote:
>
> Hi Kenneth,
>
> How did you test OSD ? I can't reproduce the issue you mentioned, OSD
> works well for me when using mplayer-vaapi with the latest
> libva/libva-intel-driver master branch.
>
> I tried your patch, what surprised me is OSD still works well after
> applying your patch. It seems your patch didn't disable the palette.
>
> Thanks
> Haihao

I ran:

mplayer -osdlevel 3 -vo vaapi big_buck_bunny_720p_stereo.ogg

For me, the OSD text is solid green, with hard edges.

If you use "-vo gl" or "-vo xv", the OSD is solid white text with a black
border around it. I presume that it's supposed to be white with vaapi as
well, but I guess I'm not entirely sure.

It's possible that the optimization doesn't affect the palette as long as
you never use sample_c with the paletted textures.

--Ken

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]