From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 05/14] drm/i915: Use a consistent order between IIR, IER, IMR writes on vlv/chv Date: Thu, 30 Oct 2014 21:39:07 +0200 Message-ID: <20141030193907.GY10649@intel.com> References: <1414690983-19260-1-git-send-email-ville.syrjala@linux.intel.com> <1414690983-19260-6-git-send-email-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 1F3516E57C for ; Thu, 30 Oct 2014 12:40:44 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Paulo Zanoni Cc: Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBPY3QgMzAsIDIwMTQgYXQgMDU6MjQ6MDVQTSAtMDIwMCwgUGF1bG8gWmFub25pIHdy b3RlOgo+IDIwMTQtMTAtMzAgMTU6NDIgR01ULTAyOjAwICA8dmlsbGUuc3lyamFsYUBsaW51eC5p bnRlbC5jb20+Ogo+ID4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4 LmludGVsLmNvbT4KPiA+Cj4gPiBGb2xsb3cgdGhlIHNhbWUgb3JkZXJpbmcgcnVsZXMgZm9yIHRo ZSBJSVIsSUVSLElNUiB3cml0ZXMgb24gdmx2L2Nodgo+ID4gdGhhdCB3ZSBkbyBvbiBvdGhlciBn ZW41KyBwbGF0Zm9ybXMuCj4gPgo+ID4gU2lnbmVkLW9mZi1ieTogVmlsbGUgU3lyasOkbMOkIDx2 aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiA+IC0tLQo+ID4gIGRyaXZlcnMvZ3B1L2Ry bS9pOTE1L2k5MTVfaXJxLmMgfCAyOSArKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLQo+ID4g IDEgZmlsZSBjaGFuZ2VkLCAxOCBpbnNlcnRpb25zKCspLCAxMSBkZWxldGlvbnMoLSkKPiA+Cj4g PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9pcnEuYyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2k5MTVfaXJxLmMKPiA+IGluZGV4IDFlNDA2MmQuLjU4OWFlNTEgMTAwNjQ0 Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2lycS5jCj4gPiArKysgYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2lycS5jCj4gPiBAQCAtMzEyOCwxMCArMzEyOCwxMSBAQCBz dGF0aWMgdm9pZCB2YWxsZXl2aWV3X2lycV9wcmVpbnN0YWxsKHN0cnVjdCBkcm1fZGV2aWNlICpk ZXYpCj4gPiAgICAgICAgIEk5MTVfV1JJVEUoUE9SVF9IT1RQTFVHX1NUQVQsIEk5MTVfUkVBRChQ T1JUX0hPVFBMVUdfU1RBVCkpOwo+ID4gICAgICAgICBmb3JfZWFjaF9waXBlKGRldl9wcml2LCBw aXBlKQo+ID4gICAgICAgICAgICAgICAgIEk5MTVfV1JJVEUoUElQRVNUQVQocGlwZSksIDB4ZmZm Zik7Cj4gPiAtICAgICAgIEk5MTVfV1JJVEUoVkxWX0lJUiwgMHhmZmZmZmZmZik7Cj4gPiAgICAg ICAgIEk5MTVfV1JJVEUoVkxWX0lNUiwgMHhmZmZmZmZmZik7Cj4gPiAgICAgICAgIEk5MTVfV1JJ VEUoVkxWX0lFUiwgMHgwKTsKPiA+IC0gICAgICAgUE9TVElOR19SRUFEKFZMVl9JRVIpOwo+ID4g KyAgICAgICBJOTE1X1dSSVRFKFZMVl9JSVIsIDB4ZmZmZmZmZmYpOwo+ID4gKyAgICAgICBJOTE1 X1dSSVRFKFZMVl9JSVIsIDB4ZmZmZmZmZmYpOwo+ID4gKyAgICAgICBQT1NUSU5HX1JFQUQoVkxW X0lJUik7Cj4gCj4gVGhpcyBpcyBhbHNvIGEgImZpeCIgc2luY2UgY2xlYXJpbmcgSUlSIGJlZm9y ZSBJTVIgZG9lc24ndCBndWFyYW50ZWUKPiB1cyBhbnl0aGluZy4gVGhlIHNhbWUgYXBwbGllcyBp biBtYW55IGNodW5rcyBiZWxvdy4KPiAKPiAKPiA+ICB9Cj4gPgo+ID4gIHN0YXRpYyB2b2lkIGdl bjhfZ3RfaXJxX3Jlc2V0KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiA+IEBA IC0zMTk5LDYgKzMyMDAsNyBAQCBzdGF0aWMgdm9pZCBjaGVycnl2aWV3X2lycV9wcmVpbnN0YWxs KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4gPiAgICAgICAgIEk5MTVfV1JJVEUoVkxWX0lNUiwg MHhmZmZmZmZmZik7Cj4gPiAgICAgICAgIEk5MTVfV1JJVEUoVkxWX0lFUiwgMHgwKTsKPiA+ICAg ICAgICAgSTkxNV9XUklURShWTFZfSUlSLCAweGZmZmZmZmZmKTsKPiA+ICsgICAgICAgSTkxNV9X UklURShWTFZfSUlSLCAweGZmZmZmZmZmKTsKPiA+ICAgICAgICAgUE9TVElOR19SRUFEKFZMVl9J SVIpOwo+ID4gIH0KPiA+Cj4gPiBAQCAtMzM2Miw5ICszMzY0LDkgQEAgc3RhdGljIHZvaWQgdmFs bGV5dmlld19kaXNwbGF5X2lycXNfaW5zdGFsbChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2 X3ByaXYpCj4gPgo+ID4gICAgICAgICBJOTE1X1dSSVRFKFZMVl9JSVIsIGlpcl9tYXNrKTsKPiA+ ICAgICAgICAgSTkxNV9XUklURShWTFZfSUlSLCBpaXJfbWFzayk7Cj4gPiAtICAgICAgIEk5MTVf V1JJVEUoVkxWX0lNUiwgZGV2X3ByaXYtPmlycV9tYXNrKTsKPiA+ICAgICAgICAgSTkxNV9XUklU RShWTFZfSUVSLCB+ZGV2X3ByaXYtPmlycV9tYXNrKTsKPiA+IC0gICAgICAgUE9TVElOR19SRUFE KFZMVl9JRVIpOwo+ID4gKyAgICAgICBJOTE1X1dSSVRFKFZMVl9JTVIsIGRldl9wcml2LT5pcnFf bWFzayk7Cj4gPiArICAgICAgIFBPU1RJTkdfUkVBRChWTFZfSU1SKTsKPiAKPiBBdCB0aGlzIHBv aW50IHlvdSBzaG91bGQgcHJvYmFibHkganVzdCBiZSBhc3NlcnRpbmcgdGhhdCBJSVIgc2hvdWxk Cj4gc3RpbGwgYmUgemVybywgc2luY2UgdGhpcyBzZWVtcyB0byBydW4gYXQgdGhlIHBvc3RpbnN0 YWxsIHN0YWdlLCBhbmQKPiB3ZSBhbHJlYWR5IGNsZWFyZWQgSUlSL0lNUi9JRVIgYXQgcHJlaW5z dGFsbCwgc28gaW4gdGhlb3J5IGl0IHNob3VsZAo+IGJlIGltcG9zc2libGUgZm9yIElJUiB0byBi ZSBub24temVyby4gQnV0IEkgc2VlIHRoZXJlJ3MgYWxzbyBhIGNhbGwKPiBmcm9tIGludGVsX3J1 bnRpbWVfcG0uYywgc28gSSBkb24ndCBrbm93Li4uCj4gCj4gVGhlICJvbmx5IGNoZWNrIElJUiBh dCBwb2luc3RpbnN0YWxsIHNpbmNlIHdlIGFscmVhZHkgZGlzYWJsZWQgaXQgYXQKPiBwcmVpbnN0 YWxsIiBhcmd1bWVudCBpcyBhbHNvIHZhbGlkIGluIHNvbWUgY2h1bmtzIGJlbG93Lgo+IAo+IEFu eXdheSwgdGhpcyBjb21taXQgaXMgYWxyZWFkeSBhbiBpbXByb3ZlbWVudCBzbyBpZiB5b3UgZG9u J3QgcGxhbiB0bwo+IGNoYW5nZSBhbnl0aGluZyBmb3Igbm93Ogo+IFJldmlld2VkLWJ5OiBQYXVs byBaYW5vbmkgPHBhdWxvLnIuemFub25pQGludGVsLmNvbT4KClllYWggSSBkaWQgZXllIHRoZSBJ TklUKCkgbWFjcm9zIGx1c3RmdWxseSBmb3IgYSB3aGlsZSwgYnV0IGRlY2lkZWQgdGhhdApzd2l0 Y2hpbmcgb3ZlciB3b3VsZCBwcm9iYWJseSByZXF1aXJlIGEgYml0IG9mIGV4dHJhIGRpbGlnZW5j ZSBvbiBteQpwYXJ0LiBTbyBkZWZpbml0ZWx5IHNvbWV0aGluZyBJIHdhbnQgdG8gdHJ5IGRvaW5n IGF0IHNvbWUgcG9pbnQsIGJ1dCBJCmZpZ3VyZWQgSSBzaG91bGQgYXZvaWQgcGlsaW5nIG9uIHRv byBtYW55IHBhdGNoZXMgaW4gdGhpcyBvbmUgc2VyaWVzLgoKPiAKPiA+ICB9Cj4gPgo+ID4gIHN0 YXRpYyB2b2lkIHZhbGxleXZpZXdfZGlzcGxheV9pcnFzX3VuaW5zdGFsbChzdHJ1Y3QgZHJtX2k5 MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gPiBAQCAtMzM3Nyw4ICszMzc5LDggQEAgc3RhdGljIHZv aWQgdmFsbGV5dmlld19kaXNwbGF5X2lycXNfdW5pbnN0YWxsKHN0cnVjdCBkcm1faTkxNV9wcml2 YXRlICpkZXZfcHJpdikKPiA+ICAgICAgICAgICAgICAgICAgICBJOTE1X0RJU1BMQVlfUElQRV9C X0VWRU5UX0lOVEVSUlVQVDsKPiA+Cj4gPiAgICAgICAgIGRldl9wcml2LT5pcnFfbWFzayB8PSBp aXJfbWFzazsKPiA+IC0gICAgICAgSTkxNV9XUklURShWTFZfSUVSLCB+ZGV2X3ByaXYtPmlycV9t YXNrKTsKPiA+ICAgICAgICAgSTkxNV9XUklURShWTFZfSU1SLCBkZXZfcHJpdi0+aXJxX21hc2sp Owo+ID4gKyAgICAgICBJOTE1X1dSSVRFKFZMVl9JRVIsIH5kZXZfcHJpdi0+aXJxX21hc2spOwo+ ID4gICAgICAgICBJOTE1X1dSSVRFKFZMVl9JSVIsIGlpcl9tYXNrKTsKPiA+ICAgICAgICAgSTkx NV9XUklURShWTFZfSUlSLCBpaXJfbWFzayk7Cj4gPiAgICAgICAgIFBPU1RJTkdfUkVBRChWTFZf SUlSKTsKPiA+IEBAIC0zNDMyLDEwICszNDM0LDExIEBAIHN0YXRpYyBpbnQgdmFsbGV5dmlld19p cnFfcG9zdGluc3RhbGwoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiA+ICAgICAgICAgSTkxNV9X UklURShQT1JUX0hPVFBMVUdfRU4sIDApOwo+ID4gICAgICAgICBQT1NUSU5HX1JFQUQoUE9SVF9I T1RQTFVHX0VOKTsKPiA+Cj4gPiAtICAgICAgIEk5MTVfV1JJVEUoVkxWX0lNUiwgZGV2X3ByaXYt PmlycV9tYXNrKTsKPiA+IC0gICAgICAgSTkxNV9XUklURShWTFZfSUVSLCB+ZGV2X3ByaXYtPmly cV9tYXNrKTsKPiA+ICAgICAgICAgSTkxNV9XUklURShWTFZfSUlSLCAweGZmZmZmZmZmKTsKPiA+ IC0gICAgICAgUE9TVElOR19SRUFEKFZMVl9JRVIpOwo+ID4gKyAgICAgICBJOTE1X1dSSVRFKFZM Vl9JSVIsIDB4ZmZmZmZmZmYpOwo+ID4gKyAgICAgICBJOTE1X1dSSVRFKFZMVl9JRVIsIH5kZXZf cHJpdi0+aXJxX21hc2spOwo+ID4gKyAgICAgICBJOTE1X1dSSVRFKFZMVl9JTVIsIGRldl9wcml2 LT5pcnFfbWFzayk7Cj4gPiArICAgICAgIFBPU1RJTkdfUkVBRChWTFZfSU1SKTsKPiA+Cj4gPiAg ICAgICAgIC8qIEludGVycnVwdCBzZXR1cCBpcyBhbHJlYWR5IGd1YXJhbnRlZWQgdG8gYmUgc2lu Z2xlLXRocmVhZGVkLCB0aGlzIGlzCj4gPiAgICAgICAgICAqIGp1c3QgdG8gbWFrZSB0aGUgYXNz ZXJ0X3NwaW5fbG9ja2VkIGNoZWNrIGhhcHB5LiAqLwo+ID4gQEAgLTM1NTksOCArMzU2MiwxMCBA QCBzdGF0aWMgaW50IGNoZXJyeXZpZXdfaXJxX3Bvc3RpbnN0YWxsKHN0cnVjdCBkcm1fZGV2aWNl ICpkZXYpCj4gPiAgICAgICAgIHNwaW5fdW5sb2NrX2lycSgmZGV2X3ByaXYtPmlycV9sb2NrKTsK PiA+Cj4gPiAgICAgICAgIEk5MTVfV1JJVEUoVkxWX0lJUiwgMHhmZmZmZmZmZik7Cj4gPiAtICAg ICAgIEk5MTVfV1JJVEUoVkxWX0lNUiwgZGV2X3ByaXYtPmlycV9tYXNrKTsKPiA+ICsgICAgICAg STkxNV9XUklURShWTFZfSUlSLCAweGZmZmZmZmZmKTsKPiA+ICAgICAgICAgSTkxNV9XUklURShW TFZfSUVSLCBlbmFibGVfbWFzayk7Cj4gPiArICAgICAgIEk5MTVfV1JJVEUoVkxWX0lNUiwgZGV2 X3ByaXYtPmlycV9tYXNrKTsKPiA+ICsgICAgICAgUE9TVElOR19SRUFEKFZMVl9JTVIpOwo+ID4K PiA+ICAgICAgICAgZ2VuOF9ndF9pcnFfcG9zdGluc3RhbGwoZGV2X3ByaXYpOwo+ID4KPiA+IEBA IC0zNjA2LDEwICszNjExLDExIEBAIHN0YXRpYyB2b2lkIHZhbGxleXZpZXdfaXJxX3VuaW5zdGFs bChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ID4KPiA+ICAgICAgICAgZGV2X3ByaXYtPmlycV9t YXNrID0gMDsKPiA+Cj4gPiAtICAgICAgIEk5MTVfV1JJVEUoVkxWX0lJUiwgMHhmZmZmZmZmZik7 Cj4gPiAgICAgICAgIEk5MTVfV1JJVEUoVkxWX0lNUiwgMHhmZmZmZmZmZik7Cj4gPiAgICAgICAg IEk5MTVfV1JJVEUoVkxWX0lFUiwgMHgwKTsKPiA+IC0gICAgICAgUE9TVElOR19SRUFEKFZMVl9J RVIpOwo+ID4gKyAgICAgICBJOTE1X1dSSVRFKFZMVl9JSVIsIDB4ZmZmZmZmZmYpOwo+ID4gKyAg ICAgICBJOTE1X1dSSVRFKFZMVl9JSVIsIDB4ZmZmZmZmZmYpOwo+ID4gKyAgICAgICBQT1NUSU5H X1JFQUQoVkxWX0lJUik7Cj4gPiAgfQo+ID4KPiA+ICBzdGF0aWMgdm9pZCBjaGVycnl2aWV3X2ly cV91bmluc3RhbGwoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiA+IEBAIC0zNjM2LDYgKzM2NDIs NyBAQCBzdGF0aWMgdm9pZCBjaGVycnl2aWV3X2lycV91bmluc3RhbGwoc3RydWN0IGRybV9kZXZp Y2UgKmRldikKPiA+ICAgICAgICAgSTkxNV9XUklURShWTFZfSU1SLCAweGZmZmZmZmZmKTsKPiA+ ICAgICAgICAgSTkxNV9XUklURShWTFZfSUVSLCAweDApOwo+ID4gICAgICAgICBJOTE1X1dSSVRF KFZMVl9JSVIsIDB4ZmZmZmZmZmYpOwo+ID4gKyAgICAgICBJOTE1X1dSSVRFKFZMVl9JSVIsIDB4 ZmZmZmZmZmYpOwo+ID4gICAgICAgICBQT1NUSU5HX1JFQUQoVkxWX0lJUik7Cj4gPiAgfQo+ID4K PiA+IC0tCj4gPiAyLjAuNAo+ID4KPiA+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCj4gPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gPiBJbnRlbC1nZnhA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gPiBodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cj4gCj4gCj4gCj4gLS0gCj4gUGF1bG8gWmFub25pCgot LSAKVmlsbGUgU3lyasOkbMOkCkludGVsIE9UQwpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2ludGVsLWdmeAo=