From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 08/14] drm/i915: Make valleyview_display_irqs_(un)install() work for chv Date: Fri, 31 Oct 2014 11:40:36 +0200 Message-ID: <20141031094036.GB10649@intel.com> References: <1414690983-19260-1-git-send-email-ville.syrjala@linux.intel.com> <1414690983-19260-9-git-send-email-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id BF1196E60C for ; Fri, 31 Oct 2014 02:40:42 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Paulo Zanoni Cc: Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBPY3QgMzAsIDIwMTQgYXQgMDY6MTI6NTFQTSAtMDIwMCwgUGF1bG8gWmFub25pIHdy b3RlOgo+IDIwMTQtMTAtMzAgMTU6NDIgR01ULTAyOjAwICA8dmlsbGUuc3lyamFsYUBsaW51eC5p bnRlbC5jb20+Ogo+ID4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4 LmludGVsLmNvbT4KPiA+Cj4gPiBHZW5yYWxpemUgdmFsbGV5dmlld19kaXNwbGF5X2lycXNfaW5z dGFsbCgpIGFuZAo+ID4gdmFsbGV5dmlld19kaXNwbGF5X2lycXNfdW5pbnN0YWxsKCkgZW5vdWdo IHNvIHRoYXQgdGhleSB3b3JrIG9uIGNodi4KPiA+IFRoZSBvbmx5IGRpZmZlcmVuY2UgdG8gdmx2 IGhlcmUgYmVpbmcgdGhlIHRoaXJkIHBpcGUgdGhhdCBjaHYgYnJpbmdzLgo+ID4KPiA+IFNpZ25l ZC1vZmYtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+ Cj4gPiAtLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2lycS5jIHwgMjcgKysrKysr KysrKysrKysrKystLS0tLS0tLS0tCj4gPiAgMSBmaWxlIGNoYW5nZWQsIDE3IGluc2VydGlvbnMo KyksIDEwIGRlbGV0aW9ucygtKQo+ID4KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pOTE1X2lycS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9pcnEuYwo+ID4gaW5k ZXggNjdjMDQ2Yi4uNTA0MzFmNiAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2k5MTVfaXJxLmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfaXJxLmMKPiA+ IEBAIC0zMzM1LDI0ICszMzM1LDI3IEBAIHN0YXRpYyB2b2lkIHZhbGxleXZpZXdfZGlzcGxheV9p cnFzX2luc3RhbGwoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ID4gIHsKPiA+ ICAgICAgICAgdTMyIHBpcGVzdGF0X21hc2s7Cj4gPiAgICAgICAgIHUzMiBpaXJfbWFzazsKPiA+ ICsgICAgICAgZW51bSBwaXBlIHBpcGU7Cj4gPgo+ID4gICAgICAgICBwaXBlc3RhdF9tYXNrID0g UElQRVNUQVRfSU5UX1NUQVRVU19NQVNLIHwKPiA+ICAgICAgICAgICAgICAgICAgICAgICAgIFBJ UEVfRklGT19VTkRFUlJVTl9TVEFUVVM7Cj4gPgo+ID4gLSAgICAgICBJOTE1X1dSSVRFKFBJUEVT VEFUKFBJUEVfQSksIHBpcGVzdGF0X21hc2spOwo+ID4gLSAgICAgICBJOTE1X1dSSVRFKFBJUEVT VEFUKFBJUEVfQiksIHBpcGVzdGF0X21hc2spOwo+ID4gKyAgICAgICBmb3JfZWFjaF9waXBlKGRl dl9wcml2LCBwaXBlKQo+ID4gKyAgICAgICAgICAgICAgIEk5MTVfV1JJVEUoUElQRVNUQVQocGlw ZSksIHBpcGVzdGF0X21hc2spOwo+ID4gICAgICAgICBQT1NUSU5HX1JFQUQoUElQRVNUQVQoUElQ RV9BKSk7Cj4gPgo+ID4gICAgICAgICBwaXBlc3RhdF9tYXNrID0gUExBTkVfRkxJUF9ET05FX0lO VF9TVEFUVVNfVkxWIHwKPiA+ICAgICAgICAgICAgICAgICAgICAgICAgIFBJUEVfQ1JDX0RPTkVf SU5URVJSVVBUX1NUQVRVUzsKPiA+Cj4gPiAtICAgICAgIGk5MTVfZW5hYmxlX3BpcGVzdGF0KGRl dl9wcml2LCBQSVBFX0EsIHBpcGVzdGF0X21hc2sgfAo+ID4gLSAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBQSVBFX0dNQlVTX0lOVEVSUlVQVF9TVEFUVVMpOwo+ ID4gLSAgICAgICBpOTE1X2VuYWJsZV9waXBlc3RhdChkZXZfcHJpdiwgUElQRV9CLCBwaXBlc3Rh dF9tYXNrKTsKPiA+ICsgICAgICAgaTkxNV9lbmFibGVfcGlwZXN0YXQoZGV2X3ByaXYsIFBJUEVf QSwgUElQRV9HTUJVU19JTlRFUlJVUFRfU1RBVFVTKTsKPiA+ICsgICAgICAgZm9yX2VhY2hfcGlw ZShkZXZfcHJpdiwgcGlwZSkKPiA+ICsgICAgICAgICAgICAgICAgICAgICBpOTE1X2VuYWJsZV9w aXBlc3RhdChkZXZfcHJpdiwgcGlwZSwgcGlwZXN0YXRfbWFzayk7Cj4gCj4gV2hpbGUgdHJ5aW5n IHRvIGNoZWNrIGZvciB0aGUgY29ycmVjdG5lc3Mgb2YgdGhlIGxpbmVzIGFib3ZlLCBJCj4gbm90 aWNlZCB0aGF0IGluIF9faTkxNV9lbmFibGVfcGlwZXN0YXQoKSwgaWYgdGhlIGVuYWJsZSBtYXNr IGlzCj4gYWxyZWFkeSB3aGF0IHdlIHdhbnQsIHdlIHdvbid0IGNsZWFyL3VwZGF0ZSB0aGUgc3Rh dHVzIGJpdHMuIElzIHRoYXQKPiBjb3JyZWN0PyBXaHk/IEFueXdheSwgYW55IHByb2JsZW1zIGlu IHRoYXQgZnVuY3Rpb24gc2hvdWxkIGJlIGZpeGVkIGJ5Cj4gYSBzZXBhcmF0ZSBwYXRjaC4KCkkg dGhpbmsgdGhlIGN1cnJlbnQgYmVoYXZpb3VyIGlzIGNvcnJlY3QuIFdlIGRvbid0IHdhbnQgdG8g bG9zZQppbnRlcnJ1cHRzIGluIGNhc2Ugc29tZW9uZSBlbmFibGVzIHRoZSBzYW1lIHBpcGVzdGF0 IGJpdCB0d2ljZS4gQnV0Cm9idmlvdXNseSB0aGVuIGRpc2FibGluZyB0d2ljZSBkb2Vzbid0IHdv cmsgYmVjYXVzZSB3ZSBkb24ndCByZWZjb3VudAp0aGUgaW5kaXZpZHVhbCBiaXRzLiBTbyBwZXJo YXBzIHdlIHdhbnQgdG8gcHJpbnQgYSB3YXJuaW5nIGlmIHNvbWUgb2YKdGhlIGJpdHMgd2UncmUg dHJ5aW5nIHRvIHNldCBhcmUgYWxyZWFkeSBzZXQ/Cgo+IAo+IFJldmlld2VkLWJ5OiBQYXVsbyBa YW5vbmkgPHBhdWxvLnIuemFub25pQGludGVsLmNvbT4KPiAKPiA+Cj4gPiAgICAgICAgIGlpcl9t YXNrID0gSTkxNV9ESVNQTEFZX1BPUlRfSU5URVJSVVBUIHwKPiA+ICAgICAgICAgICAgICAgICAg ICBJOTE1X0RJU1BMQVlfUElQRV9BX0VWRU5UX0lOVEVSUlVQVCB8Cj4gPiAgICAgICAgICAgICAg ICAgICAgSTkxNV9ESVNQTEFZX1BJUEVfQl9FVkVOVF9JTlRFUlJVUFQ7Cj4gPiArICAgICAgIGlm IChJU19DSEVSUllWSUVXKGRldl9wcml2KSkKPiA+ICsgICAgICAgICAgICAgICBpaXJfbWFzayB8 PSBJOTE1X0RJU1BMQVlfUElQRV9DX0VWRU5UX0lOVEVSUlVQVDsKPiA+ICAgICAgICAgZGV2X3By aXYtPmlycV9tYXNrICY9IH5paXJfbWFzazsKPiA+Cj4gPiAgICAgICAgIEk5MTVfV1JJVEUoVkxW X0lJUiwgaWlyX21hc2spOwo+ID4gQEAgLTMzNjYsMTAgKzMzNjksMTMgQEAgc3RhdGljIHZvaWQg dmFsbGV5dmlld19kaXNwbGF5X2lycXNfdW5pbnN0YWxsKHN0cnVjdCBkcm1faTkxNV9wcml2YXRl ICpkZXZfcHJpdikKPiA+ICB7Cj4gPiAgICAgICAgIHUzMiBwaXBlc3RhdF9tYXNrOwo+ID4gICAg ICAgICB1MzIgaWlyX21hc2s7Cj4gPiArICAgICAgIGVudW0gcGlwZSBwaXBlOwo+ID4KPiA+ICAg ICAgICAgaWlyX21hc2sgPSBJOTE1X0RJU1BMQVlfUE9SVF9JTlRFUlJVUFQgfAo+ID4gICAgICAg ICAgICAgICAgICAgIEk5MTVfRElTUExBWV9QSVBFX0FfRVZFTlRfSU5URVJSVVBUIHwKPiA+ICAg ICAgICAgICAgICAgICAgICBJOTE1X0RJU1BMQVlfUElQRV9CX0VWRU5UX0lOVEVSUlVQVDsKPiA+ ICsgICAgICAgaWYgKElTX0NIRVJSWVZJRVcoZGV2X3ByaXYpKQo+ID4gKyAgICAgICAgICAgICAg IGlpcl9tYXNrIHw9IEk5MTVfRElTUExBWV9QSVBFX0NfRVZFTlRfSU5URVJSVVBUOwo+ID4KPiA+ ICAgICAgICAgZGV2X3ByaXYtPmlycV9tYXNrIHw9IGlpcl9tYXNrOwo+ID4gICAgICAgICBJOTE1 X1dSSVRFKFZMVl9JTVIsIGRldl9wcml2LT5pcnFfbWFzayk7Cj4gPiBAQCAtMzM4MSwxNCArMzM4 NywxNSBAQCBzdGF0aWMgdm9pZCB2YWxsZXl2aWV3X2Rpc3BsYXlfaXJxc191bmluc3RhbGwoc3Ry dWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ID4gICAgICAgICBwaXBlc3RhdF9tYXNr ID0gUExBTkVfRkxJUF9ET05FX0lOVF9TVEFUVVNfVkxWIHwKPiA+ICAgICAgICAgICAgICAgICAg ICAgICAgIFBJUEVfQ1JDX0RPTkVfSU5URVJSVVBUX1NUQVRVUzsKPiA+Cj4gPiAtICAgICAgIGk5 MTVfZGlzYWJsZV9waXBlc3RhdChkZXZfcHJpdiwgUElQRV9BLCBwaXBlc3RhdF9tYXNrIHwKPiA+ IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFBJUEVfR01C VVNfSU5URVJSVVBUX1NUQVRVUyk7Cj4gPiAtICAgICAgIGk5MTVfZGlzYWJsZV9waXBlc3RhdChk ZXZfcHJpdiwgUElQRV9CLCBwaXBlc3RhdF9tYXNrKTsKPiA+ICsgICAgICAgaTkxNV9kaXNhYmxl X3BpcGVzdGF0KGRldl9wcml2LCBQSVBFX0EsIFBJUEVfR01CVVNfSU5URVJSVVBUX1NUQVRVUyk7 Cj4gPiArICAgICAgIGZvcl9lYWNoX3BpcGUoZGV2X3ByaXYsIHBpcGUpCj4gPiArICAgICAgICAg ICAgICAgaTkxNV9kaXNhYmxlX3BpcGVzdGF0KGRldl9wcml2LCBwaXBlLCBwaXBlc3RhdF9tYXNr KTsKPiA+Cj4gPiAgICAgICAgIHBpcGVzdGF0X21hc2sgPSBQSVBFU1RBVF9JTlRfU1RBVFVTX01B U0sgfAo+ID4gICAgICAgICAgICAgICAgICAgICAgICAgUElQRV9GSUZPX1VOREVSUlVOX1NUQVRV UzsKPiA+IC0gICAgICAgSTkxNV9XUklURShQSVBFU1RBVChQSVBFX0EpLCBwaXBlc3RhdF9tYXNr KTsKPiA+IC0gICAgICAgSTkxNV9XUklURShQSVBFU1RBVChQSVBFX0IpLCBwaXBlc3RhdF9tYXNr KTsKPiA+ICsKPiA+ICsgICAgICAgZm9yX2VhY2hfcGlwZShkZXZfcHJpdiwgcGlwZSkKPiA+ICsg ICAgICAgICAgICAgICBJOTE1X1dSSVRFKFBJUEVTVEFUKHBpcGUpLCBwaXBlc3RhdF9tYXNrKTsK PiA+ICAgICAgICAgUE9TVElOR19SRUFEKFBJUEVTVEFUKFBJUEVfQSkpOwo+ID4gIH0KPiA+Cj4g PiAtLQo+ID4gMi4wLjQKPiA+Cj4gPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwo+ID4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+ID4gSW50ZWwtZ2Z4QGxp c3RzLmZyZWVkZXNrdG9wLm9yZwo+ID4gaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2ludGVsLWdmeAo+IAo+IAo+IAo+IC0tIAo+IFBhdWxvIFphbm9uaQoKLS0g ClZpbGxlIFN5cmrDpGzDpApJbnRlbCBPVEMKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9pbnRlbC1nZngK