From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 10/14] drm/i915: Refactor vlv_display_irq_uninstall() Date: Fri, 31 Oct 2014 11:43:04 +0200 Message-ID: <20141031094304.GC10649@intel.com> References: <1414690983-19260-1-git-send-email-ville.syrjala@linux.intel.com> <1414690983-19260-11-git-send-email-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTP id 7DB346E103 for ; Fri, 31 Oct 2014 02:43:08 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Paulo Zanoni Cc: Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBPY3QgMzAsIDIwMTQgYXQgMDY6Mzc6NDZQTSAtMDIwMCwgUGF1bG8gWmFub25pIHdy b3RlOgo+IDIwMTQtMTAtMzAgMTg6MjIgR01ULTAyOjAwIFBhdWxvIFphbm9uaSA8cHJ6YW5vbmlA Z21haWwuY29tPjoKPiA+IDIwMTQtMTAtMzAgMTU6NDIgR01ULTAyOjAwICA8dmlsbGUuc3lyamFs YUBsaW51eC5pbnRlbC5jb20+Ogo+ID4+IEZyb206IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3ly amFsYUBsaW51eC5pbnRlbC5jb20+Cj4gPj4KPiA+PiBQdWxsIHRoZSB2bHYgZGlzcGxheSBpcnEg dW5pbnN0YWxsIGNvZGUgaW50byBhIHNlcGFyYXRlIGZ1bmN0aW9uLCBmb3IKPiA+PiBldmVudHVh bCBzaGFyaW5nIHdpdGggY2h2Lgo+ID4+Cj4gPj4gU2lnbmVkLW9mZi1ieTogVmlsbGUgU3lyasOk bMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiA+PiAtLS0KPiA+PiAgZHJpdmVy cy9ncHUvZHJtL2k5MTUvaTkxNV9pcnEuYyB8IDI1ICsrKysrKysrKysrKysrKy0tLS0tLS0tLS0K PiA+PiAgMSBmaWxlIGNoYW5nZWQsIDE1IGluc2VydGlvbnMoKyksIDEwIGRlbGV0aW9ucygtKQo+ ID4+Cj4gPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfaXJxLmMgYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2lycS5jCj4gPj4gaW5kZXggMzhlNTdkZC4uYjA1ZGVl NSAxMDA2NDQKPiA+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2lycS5jCj4gPj4g KysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9pcnEuYwo+ID4+IEBAIC0zNTg1LDYgKzM1 ODUsMjAgQEAgc3RhdGljIHZvaWQgZ2VuOF9pcnFfdW5pbnN0YWxsKHN0cnVjdCBkcm1fZGV2aWNl ICpkZXYpCj4gPj4gICAgICAgICBnZW44X2lycV9yZXNldChkZXYpOwo+ID4+ICB9Cj4gPj4KPiA+ PiArc3RhdGljIHZvaWQgdmx2X2Rpc3BsYXlfaXJxX3VuaW5zdGFsbChzdHJ1Y3QgZHJtX2k5MTVf cHJpdmF0ZSAqZGV2X3ByaXYpCj4gCj4gQWN0dWFsbHksIG5vdyB3ZSBoYXZlIHZsdl9kaXNwbGF5 X2lycV91bmluc3RhbGwoKSBhbmQKPiB2YWxsZXl2aWV3X2Rpc3BsYXlfaXJxc191bmluc3RhbGwo KSwgd2hpY2ggaXMgdmVyeSBjb25mdXNpbmcuIFBsZWFzZQo+IHJlbmFtZSBzb21ldGhpbmcgOikK ClllYWggdGhhdCBkaWQgYnVnIG1lIGFzIHdlbGwuIEkgdGhpbmsgSSBuZWVkIHRvIGNvbWUgdXAg d2l0aCBhbm90aGVyCm5hbWUgZm9yIHRoZSB2YWxsZXl2aWV3X2Rpc3BsYXlfaXJxc18qIGZ1bmN0 aW9ucyBiZWNhdXNlIHRoZSBvdGhlciBvbmVzCmFscmVhZHkgZ2V0IHRoZWlyIG5hbWVzIGZyb20g dGhlIGRybSBpbnRlcnJ1cHQgc2V0dXAgc3BsaXQuIEJ1dCBJJ2xsCm5lZWQgdG8gZ2l2ZSBpdCBz b21lIHRob3VnaHQgc28gSSBkb24ndCBtYWtlIHRoaW5ncyBldmVuIHdvcnNlIHdpdGggYQpiYWQg bmFtZSA6KQoKPiAKPiA+PiArewo+ID4+ICsgICAgICAgLyogSW50ZXJydXB0IHNldHVwIGlzIGFs cmVhZHkgZ3VhcmFudGVlZCB0byBiZSBzaW5nbGUtdGhyZWFkZWQsIHRoaXMgaXMKPiA+PiArICAg ICAgICAqIGp1c3QgdG8gbWFrZSB0aGUgYXNzZXJ0X3NwaW5fbG9ja2VkIGNoZWNrIGhhcHB5LiAq Lwo+ID4+ICsgICAgICAgc3Bpbl9sb2NrX2lycSgmZGV2X3ByaXYtPmlycV9sb2NrKTsKPiA+PiAr ICAgICAgIGlmIChkZXZfcHJpdi0+ZGlzcGxheV9pcnFzX2VuYWJsZWQpCj4gPj4gKyAgICAgICAg ICAgICAgIHZhbGxleXZpZXdfZGlzcGxheV9pcnFzX3VuaW5zdGFsbChkZXZfcHJpdik7Cj4gPj4g KyAgICAgICBzcGluX3VubG9ja19pcnEoJmRldl9wcml2LT5pcnFfbG9jayk7Cj4gPgo+ID4gSSB3 b25kZXIgaG93IG11Y2ggSSdsbCBiZSBhYmxlIHRvIHJldmlldyB3aXRob3V0IG5lZWRpbmcgdG8g dW5kZXJzdGFuZAo+ID4gd2h5IHdlIGhhdmUgdGhlIGNodW5rIGFib3ZlLi4uCj4gPgo+ID4gUmV2 aWV3ZWQtYnk6IFBhdWxvIFphbm9uaSA8cGF1bG8uci56YW5vbmlAaW50ZWwuY29tPgo+ID4KPiA+ PiArCj4gPj4gKyAgICAgICB2bHZfZGlzcGxheV9pcnFfcmVzZXQoZGV2X3ByaXYpOwo+ID4+ICsK PiA+PiArICAgICAgIGRldl9wcml2LT5pcnFfbWFzayA9IDA7Cj4gPj4gK30KPiA+PiArCj4gPj4g IHN0YXRpYyB2b2lkIHZhbGxleXZpZXdfaXJxX3VuaW5zdGFsbChzdHJ1Y3QgZHJtX2RldmljZSAq ZGV2KQo+ID4+ICB7Cj4gPj4gICAgICAgICBzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3By aXYgPSBkZXYtPmRldl9wcml2YXRlOwo+ID4+IEBAIC0zNTk4LDE2ICszNjEyLDcgQEAgc3RhdGlj IHZvaWQgdmFsbGV5dmlld19pcnFfdW5pbnN0YWxsKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4g Pj4KPiA+PiAgICAgICAgIEk5MTVfV1JJVEUoSFdTVEFNLCAweGZmZmZmZmZmKTsKPiA+Pgo+ID4+ IC0gICAgICAgLyogSW50ZXJydXB0IHNldHVwIGlzIGFscmVhZHkgZ3VhcmFudGVlZCB0byBiZSBz aW5nbGUtdGhyZWFkZWQsIHRoaXMgaXMKPiA+PiAtICAgICAgICAqIGp1c3QgdG8gbWFrZSB0aGUg YXNzZXJ0X3NwaW5fbG9ja2VkIGNoZWNrIGhhcHB5LiAqLwo+ID4+IC0gICAgICAgc3Bpbl9sb2Nr X2lycSgmZGV2X3ByaXYtPmlycV9sb2NrKTsKPiA+PiAtICAgICAgIGlmIChkZXZfcHJpdi0+ZGlz cGxheV9pcnFzX2VuYWJsZWQpCj4gPj4gLSAgICAgICAgICAgICAgIHZhbGxleXZpZXdfZGlzcGxh eV9pcnFzX3VuaW5zdGFsbChkZXZfcHJpdik7Cj4gPj4gLSAgICAgICBzcGluX3VubG9ja19pcnEo JmRldl9wcml2LT5pcnFfbG9jayk7Cj4gPj4gLQo+ID4+IC0gICAgICAgdmx2X2Rpc3BsYXlfaXJx X3Jlc2V0KGRldl9wcml2KTsKPiA+PiAtCj4gPj4gLSAgICAgICBkZXZfcHJpdi0+aXJxX21hc2sg PSAwOwo+ID4+ICsgICAgICAgdmx2X2Rpc3BsYXlfaXJxX3VuaW5zdGFsbChkZXZfcHJpdik7Cj4g Pj4gIH0KPiA+Pgo+ID4+ICBzdGF0aWMgdm9pZCBjaGVycnl2aWV3X2lycV91bmluc3RhbGwoc3Ry dWN0IGRybV9kZXZpY2UgKmRldikKPiA+PiAtLQo+ID4+IDIuMC40Cj4gPj4KPiA+PiBfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+ID4+IEludGVsLWdmeCBt YWlsaW5nIGxpc3QKPiA+PiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gPj4gaHR0 cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo+ID4K PiA+Cj4gPgo+ID4gLS0KPiA+IFBhdWxvIFphbm9uaQo+IAo+IAo+IAo+IC0tIAo+IFBhdWxvIFph bm9uaQoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbCBPVEMKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1n ZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9pbnRlbC1nZngK