From mboxrd@z Thu Jan 1 00:00:00 1970 From: Damien Lespiau Subject: Re: [PATCH] drm/i915: Fix null pointer dereference in ring cleanup code Date: Fri, 31 Oct 2014 14:52:40 +0000 Message-ID: <20141031145240.GA25780@strange.ger.corp.intel.com> References: <545375D7.6070205@Intel.com> <1414756826-21062-1-git-send-email-John.C.Harrison@Intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id A253E6E075 for ; Fri, 31 Oct 2014 07:52:43 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1414756826-21062-1-git-send-email-John.C.Harrison@Intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: John.C.Harrison@Intel.com Cc: Intel-GFX@Lists.FreeDesktop.Org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBPY3QgMzEsIDIwMTQgYXQgMTI6MDA6MjZQTSArMDAwMCwgSm9obi5DLkhhcnJpc29u QEludGVsLmNvbSB3cm90ZToKPiBGcm9tOiBKb2huIEhhcnJpc29uIDxKb2huLkMuSGFycmlzb25A SW50ZWwuY29tPgo+IAo+IElmIGEgcmluZyBmYWlsZWQgdG8gaW5pdGlhbGlzZSBmb3IgYW55IHJl YXNvbiB0aGVuIHRoZSBlcnJvciBwYXRoIHdvdWxkIHRyeSB0bwo+IGNsZWFuIHVwIGFsbCByaW5n cyBpbmNsdWRpbmcgdGhvc2UgdGhhdCBoYWQgbm90IHlldCBiZWVuIGFsbG9jYXRlZC4gVGhlIHJp bmcKPiBjbGVhbiB1cCBjb2RlIGRpZCBhIGNoZWNrIHRoYXQgdGhlIHJpbmcgd2FzIHZhbGlkIGJl Zm9yZSBzdGFydGluZyBpdHMgd29yay4KPiBVbmZvcnR1bmF0ZWx5LCB0aGF0IHdhcyBhZnRlciBp dCBoYWQgYWxyZWFkeSBkZXJlZmVyZW5jZWQgdGhlIHJpbmcgdG8gb2J0YWluIGEKPiBkZXZfcHJp dmF0ZSBwb2ludGVyLgo+IAo+IFNpZ25lZC1vZmYtYnk6IEpvaG4gSGFycmlzb24gPEpvaG4uQy5I YXJyaXNvbkBJbnRlbC5jb20+CgpUaGlzIGxvb2tzIGdvb2QgdG8gbWUuCgpSZXZpZXdlZC1ieTog RGFtaWVuIExlc3BpYXUgPGRhbWllbi5sZXNwaWF1QGludGVsLmNvbT4KCgotLSAKRGFtaWVuCgo+ IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYyAgICAgICAgfCAgICA0ICsr Ky0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5jIHwgICAgNyArKysr Ky0tCj4gIDIgZmlsZXMgY2hhbmdlZCwgOCBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQo+ IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jCj4gaW5kZXggY2Q3NGU1Yy4uNzY3NzZmYSAxMDA2 NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYwo+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jCj4gQEAgLTEyMTQsMTEgKzEyMTQsMTMgQEAgc3Rh dGljIGludCBnZW44X2VtaXRfcmVxdWVzdChzdHJ1Y3QgaW50ZWxfcmluZ2J1ZmZlciAqcmluZ2J1 ZikKPiAgICovCj4gIHZvaWQgaW50ZWxfbG9naWNhbF9yaW5nX2NsZWFudXAoc3RydWN0IGludGVs X2VuZ2luZV9jcyAqcmluZykKPiAgewo+IC0Jc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9w cml2ID0gcmluZy0+ZGV2LT5kZXZfcHJpdmF0ZTsKPiArCXN0cnVjdCBkcm1faTkxNV9wcml2YXRl ICpkZXZfcHJpdjsKPiAgCj4gIAlpZiAoIWludGVsX3JpbmdfaW5pdGlhbGl6ZWQocmluZykpCj4g IAkJcmV0dXJuOwo+ICAKPiArCWRldl9wcml2ID0gcmluZy0+ZGV2LT5kZXZfcHJpdmF0ZTsKPiAr Cj4gIAlpbnRlbF9sb2dpY2FsX3Jpbmdfc3RvcChyaW5nKTsKPiAgCVdBUk5fT04oKEk5MTVfUkVB RF9NT0RFKHJpbmcpICYgTU9ERV9JRExFKSA9PSAwKTsKPiAgCXJpbmctPnByZWFsbG9jYXRlZF9s YXp5X3JlcXVlc3QgPSBOVUxMOwo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9yaW5nYnVmZmVyLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVy LmMKPiBpbmRleCBhOGY3MmU4Li5mNDU3MTQ2IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX3JpbmdidWZmZXIuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX3JpbmdidWZmZXIuYwo+IEBAIC0xODQ1LDEyICsxODQ1LDE1IEBAIGVycm9yOgo+ICAKPiAg dm9pZCBpbnRlbF9jbGVhbnVwX3JpbmdfYnVmZmVyKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKnJp bmcpCj4gIHsKPiAtCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUo cmluZy0+ZGV2KTsKPiAtCXN0cnVjdCBpbnRlbF9yaW5nYnVmZmVyICpyaW5nYnVmID0gcmluZy0+ YnVmZmVyOwo+ICsJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2Owo+ICsJc3RydWN0 IGludGVsX3JpbmdidWZmZXIgKnJpbmdidWY7Cj4gIAo+ICAJaWYgKCFpbnRlbF9yaW5nX2luaXRp YWxpemVkKHJpbmcpKQo+ICAJCXJldHVybjsKPiAgCj4gKwlkZXZfcHJpdiA9IHRvX2k5MTUocmlu Zy0+ZGV2KTsKPiArCXJpbmdidWYgPSByaW5nLT5idWZmZXI7Cj4gKwo+ICAJaW50ZWxfc3RvcF9y aW5nX2J1ZmZlcihyaW5nKTsKPiAgCVdBUk5fT04oIUlTX0dFTjIocmluZy0+ZGV2KSAmJiAoSTkx NV9SRUFEX01PREUocmluZykgJiBNT0RFX0lETEUpID09IDApOwo+ICAKPiAtLSAKPiAxLjcuOS41 Cj4gCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBJ bnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ IGh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK