From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 1/2] drm/i915: kill intel_resume_prepare() Date: Mon, 3 Nov 2014 12:13:47 +0100 Message-ID: <20141103111347.GL26941@phenom.ffwll.local> References: <20141023121346.GG26941@phenom.ffwll.local> <1414439673-1994-1-git-send-email-przanoni@gmail.com> <1414501935.8635.16.camel@intelbox> <1414507634.8635.44.camel@intelbox> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f172.google.com (mail-wi0-f172.google.com [209.85.212.172]) by gabe.freedesktop.org (Postfix) with ESMTP id 7EA106E727 for ; Mon, 3 Nov 2014 03:13:34 -0800 (PST) Received: by mail-wi0-f172.google.com with SMTP id bs8so6103859wib.11 for ; Mon, 03 Nov 2014 03:13:33 -0800 (PST) Content-Disposition: inline In-Reply-To: <1414507634.8635.44.camel@intelbox> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Imre Deak Cc: Intel Graphics Development , Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBPY3QgMjgsIDIwMTQgYXQgMDQ6NDc6MTRQTSArMDIwMCwgSW1yZSBEZWFrIHdyb3Rl Ogo+IE9uIFR1ZSwgMjAxNC0xMC0yOCBhdCAxMTo0MyAtMDIwMCwgUGF1bG8gWmFub25pIHdyb3Rl Ogo+ID4gMjAxNC0xMC0yOCAxMToxMiBHTVQtMDI6MDAgSW1yZSBEZWFrIDxpbXJlLmRlYWtAaW50 ZWwuY29tPjoKPiA+ID4gT24gTW9uLCAyMDE0LTEwLTI3IGF0IDE3OjU0IC0wMjAwLCBQYXVsbyBa YW5vbmkgd3JvdGU6Cj4gPiA+PiBGcm9tOiBQYXVsbyBaYW5vbmkgPHBhdWxvLnIuemFub25pQGlu dGVsLmNvbT4KPiA+ID4+Cj4gPiA+PiBCZWNhdXNlLCByZWFsbHksIHRoZSBhYnN0cmFjdGlvbiBp cyBub3Qgd29ya2luZyBmb3IgdXMuIEl0IGlzIG5pY2UgZm9yCj4gPiA+PiBWTFYsIGJ1dCBkb2Vz bid0IGFkZCBhbnl0aGluZyB1c2VmdWwgb24gU05CL0hTVy9CRFcuIFdlIHdhbnQgdG8gY2hhbmdl Cj4gPiA+PiB0aGlzIGNvZGUgZHVlIHRvIGEgcmVjZW50bHktZGlzY292ZXJlZCBidWcsIGJ1dCB3 ZSBjYW4ndCBzZWVtIHRvIGZpbmQKPiA+ID4+IGEgbmljZSBzb2x1dGlvbiB0aGF0IHJlcGVjdHMg dGhlIGN1cnJlbnQgYWJzdHJhY3Rpb24uIFNvIGxldCdzIGtpbGwKPiA+ID4+IGludGVsX3Jlc3Vt ZV9wcmVwYXJlKCkgYW5kIGl0cyBmcmllbmRzLCBhbmQgYWRkIGFuIGVxdWl2YWxlbnQKPiA+ID4+ IGltcGxlbWVudGF0aW9uIHRvIGJvdGggaXRzIGNhbGxlcnMuCj4gPiA+Pgo+ID4gPj4gQWxzbywg bG9vayBhdCB0aGUgZGlmZnN0YXQhCj4gPiA+Cj4gPiA+IFRoZSByZWFzb24gZm9yIGludGVsX3Jl c3VtZV9wcmVwYXJlKCkgYW5kIGludGVsX3N1c3BlbmRfY29tcGxldGUoKSB3YXMKPiA+ID4gdG8g Y29udGFpbiBwbGF0Zm9ybSBkZXBlbmRlbnQgY29kZSBpbiB0aG9zZSBhbmQgdG8gc2hhcmUgcGFy dHMgYmV0d2Vlbgo+ID4gPiB0aGUgc3lzdGVtIGFuZCBydW50aW1lIHN1c3BlbmQgY29kZSwgc2Vl IHRoZSBkaXNjdXNzaW9uIGF0IFsxXS4KPiA+IAo+ID4gV2VsbCwgSU1ITyB3ZSBhcmUganVzdCBw cmV0ZW5kaW5nIHRvICJzaGFyZSIgdGhlIGNvZGUgcGF0aHMgYmV0d2VlbiBTMwo+ID4gYW5kIFJQ TSBiZWNhdXNlIHdlIHN0aWxsIGhhdmUgdGhlICJib29sIHJwbV9yZXN1bWUiIGFyZ3VtZW50IG9u IHRoZQo+ID4gY3VycmVudCBjb2RlLiBJTUhPIHRoaXMgaXMgb25lIG9mIHRoZSBiaWdnZXN0IHJl YXNvbnMgd2h5IHRoZSBjb2RlCj4gPiBiZWNhbWUgc28gY29tcGxleDogdGFrZSBhIGxvb2sgYXQg dGhlIHNlY29uZCB2ZXJzaW9uIG9mIG15IHBhdGNoLCBpdAo+ID4gYWRkZWQgZXZlbiBtb3JlICJp ZiAocnBtX3Jlc3VtZSkiIGNoZWNrcy4KPiAKPiBZZXMsIGJ1dCB0aGF0J3Mgb25lIG1vcmUgdGhp bmcgd2UgY291bGQgdHJ5IHRvIHJlbW92ZSBhdCBvbmUgcG9pbnQuIEZvcgo+IGV4YW1wbGUgaW50 ZWxfaW5pdF9wY2hfcmVmY2xrKCkgaW4gc25iX3Jlc3VtZV9wcmVwYXJlKCkgY291bGQgYmUganVz dCBhcwo+IHdlbGwgY2FsbGVkIGZvciBib3RoIHBhdGhzLgo+IAo+ID4gSSBrbm93IHRoYXQgYWRk aW5nIG1vcmUKPiA+IElTX1ZMViBjaGVja3MgaXMgbm90IGNvb2wsIGJ1dCB0aGUgUzMgYW5kIFJQ TSBjb2RlIHBhdGhzIGFyZSB2ZXJ5Cj4gPiBkaWZmZXJlbnQgaGVyZSwgYW5kIHRoZSBWTFYgY29k ZSBldmVuIHJlcXVpcmVzIGEgcmVhbGx5LXdlaXJkCj4gPiBvcmRlcmluZy4gSSBfcmVhbGx5XyB0 aGluayB0aGUgY29kZSBiZWNvbWVzIG11Y2ggZWFzaWVyIHRvCj4gPiByZWFkL3VuZGVyc3RhbmQv bW9kaWZ5IGJ5IGp1c3Qga2lsbGluZyBpbnRlbF9yZXN1bWVfcHJlcGFyZSgpLgo+ID4gCj4gPiA+ IEkgc3RpbGwKPiA+ID4gdGhpbmsgdGhpcyBpcyBhIGdvb2QgaWRlYSwgYnV0IEkgYWRtaXQgd2Ug bmVlZCB0byB3b3JrIG9uIGl0IG1vcmUsIGJ5Cj4gPiA+IHNoYXJpbmcgbW9yZSBiZXR3ZWVuIHRo ZSB0d28gcGF0aHMuIFNvIGZvciBleGFtcGxlIGluc3RlYWQgb2YgZG9pbmcgdGhpcwo+ID4gPiBy ZXZlcnQgbm93IEkgd291bGQgY29uc2lkZXIgY2FsbGluZyBpbnRlbF91bmNvcmVfZWFybHlfc2Fu aXRpemUoKSBmb3IKPiA+ID4gYm90aCBzeXN0ZW0gYW5kIHJ1bnRpbWUgcmVzdW1lLgo+ID4gCj4g PiBUaGF0IHN0aWxsIHdvdWxkbid0IHNvbHZlIHRoZSBvcmRlcmluZyBwcm9ibGVtIHdlIGhhdmUg b24gUzMuIE15IGdvYWwKPiA+IGlzIGp1c3QgdG8gZml4IGEgdmVyeSBzaW1wbGUgYnVnIHdpdGgg b3VyIGZ1bmN0aW9uIG9yZGVyaW5nLi4uCj4gCj4gSSB0aGluayBpdCB3b3VsZCBieSBoYXZpbmcg aW4gaW50ZWxfcmVzdW1lX3ByZXBhcmUoKToKPiAKPiBpZiAoSVNfVkFMTEVZVklFVyhkZXZfcHJp dikpCj4gCXJldCA9IHZsdl9yZXN1bWVfcHJlcGFyZShkZXZfcHJpdiwgcnBtX3Jlc3VtZSk7Cj4g aW50ZWxfdW5jb3JlX2Vhcmx5X3Nhbml0aXplKGRldix0cnVlKTsKPiBpZiAoSVNfSEFTV0VMTChk ZXZfcHJpdikgfHxJU19CUk9BRFdFTEwoZGV2X3ByaXYpKQo+IAloc3dfZGlzYWJsZV9wYzgoZGV2 X3ByaXYpOwo+IAo+IGFuZCBjYWxsIGl0IGZvciBib3RoIHN5c3RlbSBhbmQgcnVudGltZSByZXN1 bWUuCj4gCj4gPiA+IEJ1dCBpZiB0aGF0J3Mgbm90IGZlYXNpYmxlIGFuZCB5b3Ugd2FudCB0byBn byBhaGVhZCB3aXRoIHRoZSByZW1vdmFsCj4gPiA+IHRoZW4gcGxlYXNlIGFsc28gcmVtb3ZlIGlu dGVsX3N1c3BlbmRfY29tcGxldGUoKSwgbGVhdmluZyBpdCBpbiB3b3VsZCBiZQo+ID4gPiBjb25m dXNpbmcgaW1vLgo+ID4gCj4gPiBJIGRvbid0IHRoaW5rIHNvLiBJdCBkb2Vzbid0IGhhdmUgYWxs IHRoZSAiYm9vbCBycG1fcmVzdW1lIiBjb25mdXNpb24sCj4gPiB0aGVyZSdzIG5vIGZ1bmN0aW9u IG9yZGVyaW5nIGlzc3VlcyB3aXRoIGl0LCBhbmQgYm90aCB0aGUgUzMgYW5kIFJQTQo+ID4gdmVy c2lvbnMgYXJlIGFjdHVhbGx5IGlkZW50aWNhbC4gSSBkb24ndCB0aGluayBraWxsaW5nIGl0IGlz IHJlbGV2YW50Cj4gPiB0byB0aGUgYnVnIHdlJ3JlIHRyeWluZyB0byBmaXggaGVyZSwgYW5kIEkg YWxzbyBkb24ndCB0aGluayB0aGF0Cj4gPiByZW1vdmluZyB0IHdvdWxkIGJlIGFuIGltcHJvdmVt ZW50IHRvIHRoZSBjb2RlIGJhc2UuCj4gCj4gSXQncyBjb25mdXNpbmcgdG8gY2FsbCB2bHZfcmVz dW1lX3ByZXBhcmUoKSwgaHN3X2Rpc2FibGVfcGM4KCkgZnJvbQo+IGk5MTVfZHJtX3Jlc3VtZV9l YXJseSgpIGRpcmVjdGx5IGFuZCBoYXZlIHRvIGp1bXAgb3ZlciBzb21lIHdyYXBwZXJzIHRvCj4g ZmluZCB0aGUgY29ycmVzcG9uZGluZyB2bHZfc3VzcGVuZF9jb21wbGV0ZSgpLCBoc3dfZW5hYmxl X3BjOCgpIGluCj4gaTkxNV9kcm1fc3VzcGVuZF9jb21wbGV0ZSgpLiBCdXQgdGhpcyBpcyBzb21l d2hhdCBiaWtlc2hlZGRpbmcsIHNvCj4gZWl0aGVyIHdheSBmZWVsIGZyZWUgdG8gYWRkIG9uIGJv dGggcGF0Y2hlczoKPiBSZXZpZXdlZC1ieTogSW1yZSBEZWFrIDxpbXJlLmRlYWtAaW50ZWwuY29t PgoKWWVhaCB0aGF0IGZpcnN0IGF0dGVtcHQgYXQgdW5pZnlpbmcgcnBtIGFuZCBzMyBkaWRuJ3Qg cmVhbGx5IHBhbiBvdXQgYXQKYWxsLiBJIGd1ZXNzIHdlIG5lZWQgdG8gcmV0cnkuCgpNZWFud2hp bGUgbWVyZ2VkIGJvdGggcGF0Y2hlcyB0byBkaW5xLgoKVGhhbmtzLCBEYW5pZWwKLS0gCkRhbmll bCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCis0MSAoMCkgNzkg MzY1IDU3IDQ4IC0gaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9pbnRlbC1nZngK