From: Daniel Vetter <daniel@ffwll.ch>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/6] drm/i915: factor out compute_config from __intel_set_mode
Date: Mon, 3 Nov 2014 12:39:33 +0100 [thread overview]
Message-ID: <20141103113933.GN26941@phenom.ffwll.local> (raw)
In-Reply-To: <20141030113820.164e69d8@jbarnes-t420>
On Thu, Oct 30, 2014 at 11:38:20AM -0700, Jesse Barnes wrote:
> On Wed, 29 Oct 2014 16:30:43 +0200
> Ander Conselvan de Oliveira <conselvan2@gmail.com> wrote:
> > On 10/23/2014 09:50 PM, Jesse Barnes wrote:
> > > +static int intel_modeset_compute_config(struct drm_crtc *crtc,
> >
> > s/drm_crtc/intel_crtc/
>
> Since 2/3 of the functions this one calls take a drm_crtc I figured I'd
> leave it for a big cleanup patch (maybe cocci could do it).
Imo if it's driver-internal just do it, otherwise there will always be
hold-outs. And the &crtc->base doesn't really look all that ugly imo.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2014-11-03 11:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-23 18:50 [PATCH 1/6] drm/i915: factor out compute_config from __intel_set_mode Jesse Barnes
2014-10-23 18:50 ` [PATCH 2/6] drm/i915: use compute_config in set_config Jesse Barnes
2014-10-29 14:31 ` Ander Conselvan de Oliveira
2014-10-30 18:47 ` Jesse Barnes
2014-10-23 18:50 ` [PATCH 3/6] drm/i915/hdmi: fetch infoframe status in get_config Jesse Barnes
2014-10-30 13:20 ` Ander Conselvan de Oliveira
2014-10-30 18:49 ` Jesse Barnes
2014-10-23 18:50 ` [PATCH 4/6] drm/i915: check for audio and infoframe changes across mode sets Jesse Barnes
2014-10-23 18:50 ` [PATCH 5/6] drm/i915: update pipe size at set_config time Jesse Barnes
2014-10-23 18:50 ` [PATCH 6/6] drm/i915: calculate pfit changes in set_config Jesse Barnes
2014-10-30 15:40 ` Ander Conselvan de Oliveira
2014-10-29 14:30 ` [PATCH 1/6] drm/i915: factor out compute_config from __intel_set_mode Ander Conselvan de Oliveira
2014-10-30 18:38 ` Jesse Barnes
2014-11-03 11:39 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141103113933.GN26941@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox