From: Daniel Vetter <daniel@ffwll.ch>
To: John.C.Harrison@Intel.com
Cc: Intel-GFX@Lists.FreeDesktop.Org
Subject: Re: [PATCH 01/29] drm/i915: Remove redundant parameter to i915_gem_object_wait_rendering__tail()
Date: Mon, 3 Nov 2014 18:03:04 +0100 [thread overview]
Message-ID: <20141103170304.GP26941@phenom.ffwll.local> (raw)
In-Reply-To: <1414694481-15724-2-git-send-email-John.C.Harrison@Intel.com>
On Thu, Oct 30, 2014 at 06:40:53PM +0000, John.C.Harrison@Intel.com wrote:
> From: John Harrison <John.C.Harrison@Intel.com>
>
> An earlier commit (c8725f3dc0911d4354315a65150aecd8b7d0d74a: Do not call
> retire_requests from wait_for_rendering) removed the use of the ring parameter
> within wait_rendering__tail() but did not remove the parameter itself. As the
> plan is to remove obj->ring which is where this parameter comes from, it is
> simpler to just remove the parameter completely than to update it with a new
> source.
>
> For: VIZ-4377
> Signed-off-by: John Harrison <John.C.Harrison@Intel.com>
> CC: Chris Wilson <chris@chris-wilson.co.uk>
> CC: Brad Volkin <bradley.d.volkin@intel.com>
Queued for -next, thanks for the patch.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2014-11-03 17:02 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-30 18:40 [PATCH 00/29] Replace seqno values with request structures John.C.Harrison
2014-10-30 18:40 ` [PATCH 01/29] drm/i915: Remove redundant parameter to i915_gem_object_wait_rendering__tail() John.C.Harrison
2014-11-03 17:03 ` Daniel Vetter [this message]
2014-10-30 18:40 ` [PATCH 02/29] drm/i915: Ensure OLS & PLR are always in sync John.C.Harrison
2014-10-30 18:40 ` [PATCH 03/29] drm/i915: Add reference count to request structure John.C.Harrison
2014-10-30 18:40 ` [PATCH 04/29] drm/i915: Add helper functions to aid seqno -> request transition John.C.Harrison
2014-10-30 18:40 ` [PATCH 05/29] drm/i915: Replace last_[rwf]_seqno with last_[rwf]_req John.C.Harrison
2014-11-11 11:39 ` Daniel, Thomas
2014-10-30 18:40 ` [PATCH 06/29] drm/i915: Convert i915_gem_ring_throttle to use requests John.C.Harrison
2014-10-30 18:40 ` [PATCH 07/29] drm/i915: Ensure requests stick around during waits John.C.Harrison
2014-10-30 18:41 ` [PATCH 08/29] drm/i915: Remove 'outstanding_lazy_seqno' John.C.Harrison
2014-10-30 18:41 ` [PATCH 09/29] drm/i915: Make 'i915_gem_check_olr' actually check by request not seqno John.C.Harrison
2014-10-30 18:41 ` [PATCH 10/29] drm/i915: Convert 'last_flip_req' to be a request not a seqno John.C.Harrison
2014-10-30 18:41 ` [PATCH 11/29] drm/i915: Convert i915_wait_seqno to i915_wait_request John.C.Harrison
2014-10-30 18:41 ` [PATCH 12/29] drm/i915: Convert __wait_seqno() to __wait_request() John.C.Harrison
2014-10-30 18:41 ` [PATCH 13/29] drm/i915: Remove obsolete seqno parameter from 'i915_add_request' John.C.Harrison
2014-10-30 18:41 ` [PATCH 14/29] drm/i915: Convert mmio_flip::seqno to struct request John.C.Harrison
2014-10-30 18:41 ` [PATCH 15/29] drm/i915: Add IRQ friendly request deference facility John.C.Harrison
2014-11-11 11:54 ` Daniel, Thomas
2014-10-30 18:41 ` [PATCH 16/29] drm/i915: Convert 'flip_queued_seqno' into 'flip_queued_request' John.C.Harrison
2014-10-30 18:41 ` [PATCH 17/29] drm/i915: Convert trace functions from seqno to request John.C.Harrison
2014-10-30 18:41 ` [PATCH 18/29] drm/i915: Convert 'trace_irq' to use requests rather than seqnos John.C.Harrison
2014-10-30 18:41 ` [PATCH 19/29] drm/i915: Convert 'ring_idle()' to use requests not seqnos John.C.Harrison
2014-10-30 18:41 ` [PATCH 20/29] drm/i915: Connect requests to rings at creation not submission John.C.Harrison
2014-10-30 18:41 ` [PATCH 21/29] drm/i915: Convert 'i915_seqno_passed' calls into 'i915_gem_request_completed' John.C.Harrison
2014-10-30 18:41 ` [PATCH 22/29] drm/i915: Remove the now redundant 'obj->ring' John.C.Harrison
2014-10-30 18:41 ` [PATCH 23/29] drm/i915: Cache request completion status John.C.Harrison
2014-10-30 18:41 ` [PATCH 24/29] drm/i915: Zero fill the request structure John.C.Harrison
2014-10-30 18:41 ` [PATCH 25/29] drm/i915: Spinlock protection for request list John.C.Harrison
2014-10-30 18:41 ` [PATCH 26/29] drm/i915: Add uniq id to request structure for debugging John.C.Harrison
2014-10-30 18:41 ` [PATCH 27/29] drm/i915: Interrupt driven request completion John.C.Harrison
2014-10-30 18:41 ` [PATCH 28/29] drm/i915: Remove obsolete parameter to i915_gem_request_completed() John.C.Harrison
2014-10-30 18:41 ` [PATCH 29/29] WIP: Defer seqno allocation until actual hardware submission time John.C.Harrison
2014-11-04 11:12 ` [PATCH 29/29] WIP: Defer seqno allocation until actual shuang.he
2014-10-30 18:55 ` [PATCH 00/29] Replace seqno values with request structures John Harrison
2014-11-03 17:07 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141103170304.GP26941@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=Intel-GFX@Lists.FreeDesktop.Org \
--cc=John.C.Harrison@Intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox