Re: [PATCH 04/17] drm/modeset_lock: document trylock_only in kerneldoc

Thierry Reding
2014-11-05T16:18:03Z

[-- Attachment #1.1: Type: text/plain, Size: 723 bytes --]

On Sun, Nov 02, 2014 at 02:19:17PM +0100, Daniel Vetter wrote:
> I've forgotten to do this in:
>
> commit cb597bb3a2fbfc871cc1c703fb330d247bd21394
> Author: Daniel Vetter <daniel.vetter@ffwll.ch>
> Date: Sun Jul 27 19:09:33 2014 +0200
>
> drm: trylock modest locking for fbdev panics
>
> Oops, fix this asap.
>
> In my defense kerneldoc is really awful and there's no way it can pick
> up structured comments per struct member. Which means we need both
> since people won't scroll up even a few lines.
>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
> include/drm/drm_modeset_lock.h | 1 +
> 1 file changed, 1 insertion(+)

Reviewed-by: Thierry Reding <treding@nvidia.com>

[-- Attachment #1.2: Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]