Re: [Intel-gfx] [PATCH] drm: Global atomic state handling

Jani Nikula
2015-02-06T09:58:58Z

On Wed, 05 Nov 2014, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:

[heavily edited to just show the debugs]

> +struct drm_atomic_state *
> +drm_atomic_state_alloc(struct drm_device *dev)
> +{
> + DRM_DEBUG_KMS("Allocate atomic state %p\n", state);
> +}

> +void drm_atomic_state_clear(struct drm_atomic_state *state)
> +{
> + DRM_DEBUG_KMS("Clearing atomic state %p\n", state);
> +}

> +void drm_atomic_state_free(struct drm_atomic_state *state)
> +{
> + DRM_DEBUG_KMS("Freeing atomic state %p\n", state);
> +}

> +struct drm_crtc_state *
> +drm_atomic_get_crtc_state(struct drm_atomic_state *state,
> + struct drm_crtc *crtc)
> +{
> + DRM_DEBUG_KMS("Added [CRTC:%d] %p state to %p\n",
> + crtc->base.id, crtc_state, state);
> +}

> +struct drm_plane_state *
> +drm_atomic_get_plane_state(struct drm_atomic_state *state,
> + struct drm_plane *plane)
> +{
> + DRM_DEBUG_KMS("Added [PLANE:%d] %p state to %p\n",
> + plane->base.id, plane_state, state);
> +}

> +struct drm_connector_state *
> +drm_atomic_get_connector_state(struct drm_atomic_state *state,
> + struct drm_connector *connector)
> +{
> + DRM_DEBUG_KMS("Added [CONNECTOR:%d] %p state to %p\n",
> + connector->base.id, connector_state, state);
> +}

> +int drm_atomic_check_only(struct drm_atomic_state *state)
> +{
> + DRM_DEBUG_KMS("checking %p\n", state);
> +}

> +int drm_atomic_commit(struct drm_atomic_state *state)
> +{
> + DRM_DEBUG_KMS("commiting %p\n", state);
> +}

These seem to be rather verbose [1], is this normal or indicative of
something going awry? If normal, it does seem quite noisy in the logs.

BR,
Jani.

[1] https://bugs.freedesktop.org/attachment.cgi?id=113217

--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org