Re: [PATCH 04/17] drm/modeset_lock: document trylock_only in kerneldoc

Sean Paul
2014-11-04T20:32:01Z

On Sun, Nov 02, 2014 at 02:19:17PM +0100, Daniel Vetter wrote:
> I've forgotten to do this in:
>
> commit cb597bb3a2fbfc871cc1c703fb330d247bd21394
> Author: Daniel Vetter <daniel.vetter@ffwll.ch>
> Date: Sun Jul 27 19:09:33 2014 +0200
>
> drm: trylock modest locking for fbdev panics
>
> Oops, fix this asap.
>
> In my defense kerneldoc is really awful and there's no way it can pick
> up structured comments per struct member. Which means we need both
> since people won't scroll up even a few lines.
>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>

Reviewed-by: Sean Paul <seanpaul@chromium.org>

> ---
> include/drm/drm_modeset_lock.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/drm/drm_modeset_lock.h b/include/drm/drm_modeset_lock.h
> index 75a5c45e21c7..28931a23d96c 100644
> --- a/include/drm/drm_modeset_lock.h
> +++ b/include/drm/drm_modeset_lock.h
> @@ -33,6 +33,7 @@ struct drm_modeset_lock;
> * @ww_ctx: base acquire ctx
> * @contended: used internally for -EDEADLK handling
> * @locked: list of held locks
> + * @trylock_only: trylock mode used in atomic contexts/panic notifiers
> *
> * Each thread competing for a set of locks must use one acquire
> * ctx. And if any lock fxn returns -EDEADLK, it must backoff and
> --
> 2.1.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel