public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: bradley.d.volkin@intel.com
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v3 2/5] drm/i915: Use batch pools with the command parser
Date: Tue, 4 Nov 2014 11:30:14 +0100	[thread overview]
Message-ID: <20141104103014.GH26941@phenom.ffwll.local> (raw)
In-Reply-To: <1415042385-26445-3-git-send-email-bradley.d.volkin@intel.com>

On Mon, Nov 03, 2014 at 11:19:42AM -0800, bradley.d.volkin@intel.com wrote:
> +			flags |= I915_DISPATCH_SECURE;

I've forgotten one: You must have a full ppgtt check here since the
binding for aliasing ppgtt is still broken - all PIN_GLOBAL stuff still
ends up in the ppgtt ptes too, so yourspace can still get at your shadow
batch.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2014-11-04 10:30 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-03 19:19 [PATCH v3 0/5] Command parser batch buffer copy bradley.d.volkin
2014-11-03 19:19 ` [PATCH v3 1/5] drm/i915: Implement a framework for batch buffer pools bradley.d.volkin
2014-11-03 19:19 ` [PATCH v3 2/5] drm/i915: Use batch pools with the command parser bradley.d.volkin
2014-11-04 10:17   ` Daniel Vetter
2014-11-04 16:35     ` Volkin, Bradley D
2014-11-05  9:50       ` Daniel Vetter
2014-11-05 10:20         ` Daniel Vetter
2014-11-05 22:42         ` Volkin, Bradley D
2014-11-06  7:36           ` Chris Wilson
2014-11-06 13:56             ` Daniel Vetter
2014-11-06 17:38               ` Volkin, Bradley D
2014-11-07  9:32                 ` Chris Wilson
2014-11-07  9:45                 ` Daniel Vetter
2014-11-04 10:30   ` Daniel Vetter [this message]
2014-11-04 16:46     ` Volkin, Bradley D
2014-11-05  9:53       ` Daniel Vetter
2014-11-03 19:19 ` [PATCH v3 3/5] drm/i915: Add a batch pool debugfs file bradley.d.volkin
2014-11-03 19:19 ` [PATCH v3 4/5] drm/i915: Add batch pool details to i915_gem_objects debugfs bradley.d.volkin
2014-11-03 19:19 ` [PATCH v3 5/5] drm/i915: Use batch length instead of object size in command parser bradley.d.volkin
2014-11-03 19:32   ` [PATCH v3 5/5] drm/i915: Use batch length instead of shuang.he
2014-11-03 22:44 ` [PATCH v3 0/5] Command parser batch buffer copy Volkin, Bradley D
2014-11-04  9:51   ` Daniel Vetter
2014-11-04 10:31 ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141104103014.GH26941@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=bradley.d.volkin@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox