From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH] drm/i915: Add haswell_pcode_write function
Date: Thu, 6 Nov 2014 20:18:46 +0200
Message-ID: <20141106181846.GQ10649@intel.com>
References: <1415237564-89631-1-git-send-email-Tom.O'Rourke@intel.com>
 <20141106082853.GO10649@intel.com>
 <20141106173548.GA91037@torourke-desk1>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by gabe.freedesktop.org (Postfix) with ESMTP id 3798F6F0C7
 for <intel-gfx@lists.freedesktop.org>; Thu,  6 Nov 2014 10:19:28 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <20141106173548.GA91037@torourke-desk1>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: "O'Rourke, Tom" <Tom.O'Rourke@intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gVGh1LCBOb3YgMDYsIDIwMTQgYXQgMDk6MzU6NDhBTSAtMDgwMCwgTydSb3Vya2UsIFRvbSB3
cm90ZToKPiBPbiBUaHUsIE5vdiAwNiwgMjAxNCBhdCAxMDoyODo1M0FNICswMjAwLCBWaWxsZSBT
eXJqw6Rsw6Qgd3JvdGU6Cj4gPiBPbiBXZWQsIE5vdiAwNSwgMjAxNCBhdCAwNTozMjo0NFBNIC0w
ODAwLCBUb20uTydSb3Vya2VAaW50ZWwuY29tIHdyb3RlOgo+ID4gPiBGcm9tOiBUb20gTydSb3Vy
a2UgPFRvbS5PJ1JvdXJrZUBpbnRlbC5jb20+Cj4gPiA+IAo+ID4gPiBCYXNlZCBvbiBzYW5keWJy
aWRnZV9wY29kZV93cml0ZSwgaGFzd2VsbF9wY29kZV93cml0ZSBoYXMgYW4KPiA+ID4gYWRkaXRp
b25hbCBmaWVsZCBmb3IgYWRkcmVzcyBjb250cm9sLgo+ID4gCj4gPiBJdCdzIGFscmVhZHkgdGhl
cmUgaW4gc25iLgo+IElmIHRoZSBhZGRyZXNzIGNvbnRyb2wgZmllbGQgaXMgYWxyZWFkeSB0aGVy
ZSBmb3IgU05CLAo+IHRoZW4gSSB3b3VsZCBwcmVmZXIgdG8gbW9kaWZ5IHNhbmR5YnJpZGdlX3Bj
b2RlX3dyaXRlCj4gaW5zdGVhZCBvZiBhZGRpbmcgYSBoYXN3ZWxsX3Bjb2RlX3dyaXRlLgoKQWdy
ZWVkLgoKPiAKPiBJIGJhc2VkIHRoaXMgcGF0Y2ggb24gdGhlIEhhc3dlbGwgZG9jdW1lbnRhdGlv
biBmb3IKPiBQQ1VfQ1JfR1REUklWRVJfTUFJTEJPWF9JTlRFUkZBQ0VfMF8yXzBfR1RUTU1BRFIg
b24KPiBwYWdlIDEwMSBvZgo+IGh0dHBzOi8vMDEub3JnL2xpbnV4Z3JhcGhpY3Mvc2l0ZXMvZGVm
YXVsdC9maWxlcy9kb2N1bWVudGF0aW9uL2ludGVsLWdmeC1wcm0tb3NyYy1oc3ctcGNpZS1jb25m
aWctcmVnaXN0ZXJzLnBkZgo+IAo+IENhbiB5b3UgcG9pbnQgbWUgdG8gdGhlIFNOQiBkb2N1bWVu
dGF0aW9uIGZvciB0aGUKPiBhZGRyZXNzIGNvbnRyb2wgZmllbGQ/ICAgSSBkbyBub3QgaGF2ZSBk
b2N1bWVudGF0aW9uCj4gZm9yIGFkZHJlc3MgY29udHJvbCBmb3IgZWFybGllciB0aGFuIEhhc3dl
bGwuCgpJIGZvdW5kIGl0IGluIEJTcGVjLiBOb3Qgc3VyZSBpdCBjYW4gYmUgZm91bmQgaW4gdGhl
IFBSTXMuCgo+IAo+ID4gCj4gPiBEbyB5b3UgaGF2ZSBhbiBhY3R1YWwgdXNlIGNhc2UgZm9yIHRo
aXM/IElmIHNvIEkgd29uZGVyIGlmIHdlIHNob3VsZAo+ID4ganVzdCBjaGFuZ2UgdGhlIG1ib3gg
cGFyYW1ldGVyIHRvIHUzMiBhbmQgYWxsb3cgdGhlIGNhbGxlciB0byBzcGVjaWZ5Cj4gPiBpdCBh
bGw/Cj4gPiAKPiBObywgSSBkbyBub3QgaGF2ZSBhbiBhY3R1YWwgdXNlIGNhc2UgZm9yIHRoaXMg
eWV0Lgo+IEkgYW0gd29ya2luZyBvbiBzb21ldGhpbmcgdGhhdCB3aWxsIHVzZSBpdCBidXQgdGhh
dAo+IGlzIG5vdCByZWFkeSB5ZXQuCj4gCj4gWWVzLCB3ZSBjb3VsZCBjaGFuZ2UgbWJveCB0byB1
MzIgYW5kIHNoaWZ0IHRoZSB3b3JrCj4gdG8gdGhlIGNhbGxlci4gIFRoZSBjYWxsZXIgd291bGQg
bmVlZCB0byBjb21iaW5lIHRoZQo+IHU4IG1haWxib3ggY29tbWFuZCB3aXRoIHRoZSBhZGRyZXNz
IGNvbnRyb2wgZmllbGQuCj4gSSBkbyBub3QgdGhpbmsgdGhhdCB3b3VsZCBiZSBiZXR0ZXIgKG9y
IHdvcnNlKSBidXQKPiBJIGNhbiBtYWtlIHRoYXQgY2hhbmdlIGlmIG90aGVycyB3YW50IGl0LgoK
V2VsbCwgSSBkb24ndCByZWFsbHkgbWluZCBlaXRoZXIgd2F5LiBTbyB1bmxlc3MgYW55b25lIGVs
c2Ugb2JqZWN0cyB0bwpvbmUgb2YgdGhlIGFwcHJvYWNoZXMgZmVlbCBmcmVlIHRvIHBpY2sgZWl0
aGVyIG9uZS4KCj4gCj4gPiA+IAo+ID4gPiBTaWduZWQtb2ZmLWJ5OiBUb20gTydSb3Vya2UgPFRv
bS5PJ1JvdXJrZUBpbnRlbC5jb20+Cj4gPiA+IC0tLQo+ID4gPiAgZHJpdmVycy9ncHUvZHJtL2k5
MTUvaTkxNV9kcnYuaCB8ICAgIDEgKwo+ID4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9y
ZWcuaCB8ICAgIDEgKwo+ID4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYyB8ICAg
IDkgKysrKysrKy0tCj4gPiA+ICAzIGZpbGVzIGNoYW5nZWQsIDkgaW5zZXJ0aW9ucygrKSwgMiBk
ZWxldGlvbnMoLSkKPiA+ID4gCj4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkx
NS9pOTE1X2Rydi5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+ID4gPiBpbmRl
eCAwZjAwZTU4Li5mZDhiNTUwIDEwMDY0NAo+ID4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkx
NS9pOTE1X2Rydi5oCj4gPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgK
PiA+ID4gQEAgLTI5NTAsNiArMjk1MCw3IEBAIHZvaWQgZ2VuNl9ndF9mb3JjZV93YWtlX3B1dChz
dHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsIGludCBmd19lbmdpbmUpOwo+ID4gPiAg
dm9pZCBhc3NlcnRfZm9yY2Vfd2FrZV9pbmFjdGl2ZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAq
ZGV2X3ByaXYpOwo+ID4gPiAgCj4gPiA+ICBpbnQgc2FuZHlicmlkZ2VfcGNvZGVfcmVhZChzdHJ1
Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsIHU4IG1ib3gsIHUzMiAqdmFsKTsKPiA+ID4g
K2ludCBoYXN3ZWxsX3Bjb2RlX3dyaXRlKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJp
diwgdTggbWJveCwgdTMyIHZhbCwgdTMyIGNvbnRyb2wpOwo+ID4gPiAgaW50IHNhbmR5YnJpZGdl
X3Bjb2RlX3dyaXRlKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwgdTggbWJveCwg
dTMyIHZhbCk7Cj4gPiA+ICAKPiA+ID4gIC8qIGludGVsX3NpZGViYW5kLmMgKi8KPiA+ID4gZGlm
ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmggYi9kcml2ZXJzL2dwdS9k
cm0vaTkxNS9pOTE1X3JlZy5oCj4gPiA+IGluZGV4IDZmYmZkZWMuLmI2NzQwNTAgMTAwNjQ0Cj4g
PiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmgKPiA+ID4gKysrIGIvZHJp
dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZWcuaAo+ID4gPiBAQCAtNjAxMSw2ICs2MDExLDcgQEAg
ZW51bSBwdW5pdF9wb3dlcl93ZWxsIHsKPiA+ID4gICNkZWZpbmUgICBHRU42X0RFQ09ERV9SQzZf
VklEKHZpZHMpCQkoKCh2aWRzKSAqIDUpICsgMjQ1KQo+ID4gPiAgI2RlZmluZSAgIERJU1BMQVlf
SVBTX0NPTlRST0wJCQkweDE5Cj4gPiA+ICAjZGVmaW5lCSAgSFNXX1BDT0RFX0RZTkFNSUNfRFVU
WV9DWUNMRV9DT05UUk9MCTB4MUEKPiA+ID4gKyNkZWZpbmUgICBIU1dfUENPREVfQUREUl9DTlRM
KGNudGwpCQkoKGNudGwgPDwgOCkgJiAweDFmZmZmZjAwKQoKSSBkb24ndCB0aGluayB3ZSBuZWVk
IHRoZSBtYXNrIGhlcmUuIFdlIGdlbmVyYWxseSBkb24ndCBoYXZlIGl0LCB3aXRoIHNvbWUKZXhj
ZXB0aW9ucyBsaWtlIHRoZSBjc2Mgc3R1ZmYgSSBkaWQgcmVjZW50bHkgd2hpY2ggZGVhbHMgaW4g
c2lnbmVkIHZhbHVlcywKYW5kIHNvIG5lZWRzIGl0IHRvIGF2b2lkIHRoZSBzaWduIGJpdHMgZnJv
bSBjbG9iYmVyaW5nIGV2ZXJ5dGhpbmcgYWJvdmUuCgpCdXQgSSBoYXZlIGJlZW4gZHJlYW1pbmcg
b2NjYXNpb25hbGx5IGFib3V0IGhhdmluZyBzdWNoIG1hY3JvcyBkZWZpbmVkCmluIGEgd2F5IHRo
YXQgd291bGQgYWxsb3cgdXMgdG8gdmVyaWZ5IHRoYXQgd2UgZG9uJ3Qgb3ZlcmZsb3cgYW55dGhp
bmcKYnkgYWNjaWRlbnQuIEVnLiBzb21ldGhpbmcgbGlrZSB0aGlzOgoKI2lmIENPTkZJR19JOTE1
X0NIRUNLX1JFR0lTVEVSUwojZGVmaW5lIF9CSVRGSUVMRCh2YWx1ZSxvZmZzZXQsc2l6ZSkgKHsg
V0FSTl9PTigodmFsdWUpICYgfigoMSA8PCAoc2l6ZSkpIC0gMSkpOyAoKHZhbHVlKSA8PCAoc2hp
ZnQpKSB9KQojZWxzZQojZGVmaW5lIF9CSVRGSUVMRCh2YWx1ZSxvZmZzZXQsc2l6ZSkgKCh2YWx1
ZSkgPDwgKHNoaWZ0KSkKI2VuZGlmCgojZGVmaW5lIFBDT0RFX0FERFJfQ05UTCh4KSBfQklURklF
TEQoKHgpLCA4LCAyMSkKCkJ1dCBjb252ZXJ0aW5nIGV2ZXJ5dGhpbmcgd291bGQgYmUgYSBiaWcg
dGFzaywgZXNwZWNpYWxseSBhcyB3ZSBkb24ndApoYXZlIHN1Y2ggbWFjcm9zIGZvciBldmVyeXRo
aW5nLiBTb21ldGltZXMgd2UganVzdCBoYXZlIGEgc2hpZnQgdmFsdWUsCmFuZCBzb21ldGltZXMg
bm90IGV2ZW4gdGhhdCBhbmQgd2UgY2FsY3VsYXRlIGEgc2hpZnQgdXNpbmcgc29tZSBjYXNlCnNw
ZWNpZmljIG1hZ2ljLCBhbmQgc29tZXRpbWVzIHRoZSBzaGlmdCBpc24ndCBzdHJpY3RseSBuZWVk
ZWQgKGVnLgppdCdzIDAsIG9yIGp1c3QgaGFwcGVucyB0byBtYXRjaCBuYXR1cmFsbHkgdGhlIGRh
dGEgd2Ugc3R1ZmYgaW4gdGhlcmUKbGlrZSBpbiB0aGUgY2FzZSBvZiBwYWdlIGFsaWduZWQgYWRk
cmVzc2VzKS4KCj4gPiA+ICAjZGVmaW5lIEdFTjZfUENPREVfREFUQQkJCQkweDEzODEyOAo+ID4g
PiAgI2RlZmluZSAgIEdFTjZfUENPREVfRlJFUV9JQV9SQVRJT19TSElGVAk4Cj4gPiA+ICAjZGVm
aW5lICAgR0VONl9QQ09ERV9GUkVRX1JJTkdfUkFUSU9fU0hJRlQJMTYKPiA+ID4gZGlmZiAtLWdp
dCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkx
NS9pbnRlbF9wbS5jCj4gPiA+IGluZGV4IDEyNDRmZjguLjljNDdiYzggMTAwNjQ0Cj4gPiA+IC0t
LSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMKPiA+ID4gKysrIGIvZHJpdmVycy9n
cHUvZHJtL2k5MTUvaW50ZWxfcG0uYwo+ID4gPiBAQCAtNzI3Nyw3ICs3Mjc3LDcgQEAgaW50IHNh
bmR5YnJpZGdlX3Bjb2RlX3JlYWQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LCB1
OCBtYm94LCB1MzIgKnZhbCkKPiA+ID4gIAlyZXR1cm4gMDsKPiA+ID4gIH0KPiA+ID4gIAo+ID4g
PiAtaW50IHNhbmR5YnJpZGdlX3Bjb2RlX3dyaXRlKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpk
ZXZfcHJpdiwgdTggbWJveCwgdTMyIHZhbCkKPiA+ID4gK2ludCBoYXN3ZWxsX3Bjb2RlX3dyaXRl
KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwgdTggbWJveCwgdTMyIHZhbCwgdTMy
IGNvbnRyb2wpCj4gPiA+ICB7Cj4gPiA+ICAJV0FSTl9PTighbXV0ZXhfaXNfbG9ja2VkKCZkZXZf
cHJpdi0+cnBzLmh3X2xvY2spKTsKPiA+ID4gIAo+ID4gPiBAQCAtNzI4Nyw3ICs3Mjg3LDcgQEAg
aW50IHNhbmR5YnJpZGdlX3Bjb2RlX3dyaXRlKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZf
cHJpdiwgdTggbWJveCwgdTMyIHZhbCkKPiA+ID4gIAl9Cj4gPiA+ICAKPiA+ID4gIAlJOTE1X1dS
SVRFKEdFTjZfUENPREVfREFUQSwgdmFsKTsKPiA+ID4gLQlJOTE1X1dSSVRFKEdFTjZfUENPREVf
TUFJTEJPWCwgR0VONl9QQ09ERV9SRUFEWSB8IG1ib3gpOwo+ID4gPiArCUk5MTVfV1JJVEUoR0VO
Nl9QQ09ERV9NQUlMQk9YLCBHRU42X1BDT0RFX1JFQURZIHwgbWJveCB8IEhTV19QQ09ERV9BRERS
X0NOVEwoY29udHJvbCkpOwo+ID4gPiAgCj4gPiA+ICAJaWYgKHdhaXRfZm9yKChJOTE1X1JFQUQo
R0VONl9QQ09ERV9NQUlMQk9YKSAmIEdFTjZfUENPREVfUkVBRFkpID09IDAsCj4gPiA+ICAJCSAg
ICAgNTAwKSkgewo+ID4gPiBAQCAtNzMwMCw2ICs3MzAwLDExIEBAIGludCBzYW5keWJyaWRnZV9w
Y29kZV93cml0ZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsIHU4IG1ib3gsIHUz
MiB2YWwpCj4gPiA+ICAJcmV0dXJuIDA7Cj4gPiA+ICB9Cj4gPiA+ICAKPiA+ID4gK2ludCBzYW5k
eWJyaWRnZV9wY29kZV93cml0ZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsIHU4
IG1ib3gsIHUzMiB2YWwpCj4gPiA+ICt7Cj4gPiA+ICsJcmV0dXJuIGhhc3dlbGxfcGNvZGVfd3Jp
dGUoZGV2X3ByaXYsIG1ib3gsIHZhbCwgMCk7Cj4gPiA+ICt9Cj4gPiA+ICsKPiA+ID4gIHN0YXRp
YyBpbnQgYnl0X2dwdV9mcmVxKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwgaW50
IHZhbCkKPiA+ID4gIHsKPiA+ID4gIAlpbnQgZGl2Owo+ID4gPiAtLSAKPiA+ID4gMS43LjkuNQo+
ID4gPiAKPiA+ID4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X18KPiA+ID4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+ID4gPiBJbnRlbC1nZnhAbGlzdHMuZnJl
ZWRlc2t0b3Aub3JnCj4gPiA+IGh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s
aXN0aW5mby9pbnRlbC1nZngKPiA+IAo+ID4gLS0gCj4gPiBWaWxsZSBTeXJqw6Rsw6QKPiA+IElu
dGVsIE9UQwoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbCBPVEMKX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRl
bC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv
bWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK