Re: [PATCH] drm/i915: Extend pcode mailbox interface

Daniel Vetter
2014-11-19T13:40:23Z

On Tue, Nov 18, 2014 at 09:24:26PM +0200, Ville Syrjälä wrote:
> On Thu, Nov 13, 2014 at 06:50:10PM -0800, Tom.O'Rourke@intel.com wrote:
> > From: Tom O'Rourke <Tom.O'Rourke@intel.com>
> >
> > In sandybridge_pcode_read and sandybridge_pcode_write,
> > extend the mbox parameter from u8 to u32.
> >
> > On Haswell and Sandybridge, bits 7:0 encode the mailbox
> > command and bits 28:8 are used for address control for
> > specific commands.
> >
> > Based on suggestion from Ville Syrjälä.
> >
> > Signed-off-by: Tom O'Rourke <Tom.O'Rourke@intel.com>
>
> Not sure what we're going to do with this, but the spec does allow
> passing some stuff in the high bits, so
>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Queued for -next, thanks for the patch.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch