From mboxrd@z Thu Jan 1 00:00:00 1970 From: "O'Rourke, Tom" Subject: Re: [PATCH] drm/i915: Add haswell_pcode_write function Date: Thu, 6 Nov 2014 12:21:26 -0800 Message-ID: <20141106202126.GA91377@torourke-desk1> References: <1415237564-89631-1-git-send-email-Tom.O'Rourke@intel.com> <20141106082853.GO10649@intel.com> <20141106173548.GA91037@torourke-desk1> <20141106181846.GQ10649@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 0F6B86E279 for ; Thu, 6 Nov 2014 12:20:53 -0800 (PST) Content-Disposition: inline In-Reply-To: <20141106181846.GQ10649@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBOb3YgMDYsIDIwMTQgYXQgMDg6MTg6NDZQTSArMDIwMCwgVmlsbGUgU3lyasOkbMOk IHdyb3RlOgo+IE9uIFRodSwgTm92IDA2LCAyMDE0IGF0IDA5OjM1OjQ4QU0gLTA4MDAsIE8nUm91 cmtlLCBUb20gd3JvdGU6Cj4gPiBPbiBUaHUsIE5vdiAwNiwgMjAxNCBhdCAxMDoyODo1M0FNICsw MjAwLCBWaWxsZSBTeXJqw6Rsw6Qgd3JvdGU6Cj4gPiA+IE9uIFdlZCwgTm92IDA1LCAyMDE0IGF0 IDA1OjMyOjQ0UE0gLTA4MDAsIFRvbS5PJ1JvdXJrZUBpbnRlbC5jb20gd3JvdGU6Cj4gPiA+ID4g RnJvbTogVG9tIE8nUm91cmtlIDxUb20uTydSb3Vya2VAaW50ZWwuY29tPgo+ID4gPiA+IAo+ID4g PiA+IEJhc2VkIG9uIHNhbmR5YnJpZGdlX3Bjb2RlX3dyaXRlLCBoYXN3ZWxsX3Bjb2RlX3dyaXRl IGhhcyBhbgo+ID4gPiA+IGFkZGl0aW9uYWwgZmllbGQgZm9yIGFkZHJlc3MgY29udHJvbC4KPiA+ ID4gCj4gPiA+IEl0J3MgYWxyZWFkeSB0aGVyZSBpbiBzbmIuCj4gPiBJZiB0aGUgYWRkcmVzcyBj b250cm9sIGZpZWxkIGlzIGFscmVhZHkgdGhlcmUgZm9yIFNOQiwKPiA+IHRoZW4gSSB3b3VsZCBw cmVmZXIgdG8gbW9kaWZ5IHNhbmR5YnJpZGdlX3Bjb2RlX3dyaXRlCj4gPiBpbnN0ZWFkIG9mIGFk ZGluZyBhIGhhc3dlbGxfcGNvZGVfd3JpdGUuCj4gCj4gQWdyZWVkLgo+IAo+ID4gCj4gPiBJIGJh c2VkIHRoaXMgcGF0Y2ggb24gdGhlIEhhc3dlbGwgZG9jdW1lbnRhdGlvbiBmb3IKPiA+IFBDVV9D Ul9HVERSSVZFUl9NQUlMQk9YX0lOVEVSRkFDRV8wXzJfMF9HVFRNTUFEUiBvbgo+ID4gcGFnZSAx MDEgb2YKPiA+IGh0dHBzOi8vMDEub3JnL2xpbnV4Z3JhcGhpY3Mvc2l0ZXMvZGVmYXVsdC9maWxl cy9kb2N1bWVudGF0aW9uL2ludGVsLWdmeC1wcm0tb3NyYy1oc3ctcGNpZS1jb25maWctcmVnaXN0 ZXJzLnBkZgo+ID4gCj4gPiBDYW4geW91IHBvaW50IG1lIHRvIHRoZSBTTkIgZG9jdW1lbnRhdGlv biBmb3IgdGhlCj4gPiBhZGRyZXNzIGNvbnRyb2wgZmllbGQ/ICAgSSBkbyBub3QgaGF2ZSBkb2N1 bWVudGF0aW9uCj4gPiBmb3IgYWRkcmVzcyBjb250cm9sIGZvciBlYXJsaWVyIHRoYW4gSGFzd2Vs bC4KPiAKPiBJIGZvdW5kIGl0IGluIEJTcGVjLiBOb3Qgc3VyZSBpdCBjYW4gYmUgZm91bmQgaW4g dGhlIFBSTXMuCj4KVGhhbmsgeW91IGZvciB0aGUgcG9pbnRlci4gIEkgd2lsbCByZXdyaXRlIHRo ZSBwYXRjaC4KVGhpcyBjdXJyZW50IHBhdGNoIHNob3VsZCBiZSBhYmFuZG9uZWQuCgo+ID4gCj4g PiA+IAo+ID4gPiBEbyB5b3UgaGF2ZSBhbiBhY3R1YWwgdXNlIGNhc2UgZm9yIHRoaXM/IElmIHNv IEkgd29uZGVyIGlmIHdlIHNob3VsZAo+ID4gPiBqdXN0IGNoYW5nZSB0aGUgbWJveCBwYXJhbWV0 ZXIgdG8gdTMyIGFuZCBhbGxvdyB0aGUgY2FsbGVyIHRvIHNwZWNpZnkKPiA+ID4gaXQgYWxsPwo+ ID4gPiAKPiA+IE5vLCBJIGRvIG5vdCBoYXZlIGFuIGFjdHVhbCB1c2UgY2FzZSBmb3IgdGhpcyB5 ZXQuCj4gPiBJIGFtIHdvcmtpbmcgb24gc29tZXRoaW5nIHRoYXQgd2lsbCB1c2UgaXQgYnV0IHRo YXQKPiA+IGlzIG5vdCByZWFkeSB5ZXQuCj4gPiAKPiA+IFllcywgd2UgY291bGQgY2hhbmdlIG1i b3ggdG8gdTMyIGFuZCBzaGlmdCB0aGUgd29yawo+ID4gdG8gdGhlIGNhbGxlci4gIFRoZSBjYWxs ZXIgd291bGQgbmVlZCB0byBjb21iaW5lIHRoZQo+ID4gdTggbWFpbGJveCBjb21tYW5kIHdpdGgg dGhlIGFkZHJlc3MgY29udHJvbCBmaWVsZC4KPiA+IEkgZG8gbm90IHRoaW5rIHRoYXQgd291bGQg YmUgYmV0dGVyIChvciB3b3JzZSkgYnV0Cj4gPiBJIGNhbiBtYWtlIHRoYXQgY2hhbmdlIGlmIG90 aGVycyB3YW50IGl0Lgo+IAo+IFdlbGwsIEkgZG9uJ3QgcmVhbGx5IG1pbmQgZWl0aGVyIHdheS4g U28gdW5sZXNzIGFueW9uZSBlbHNlIG9iamVjdHMgdG8KPiBvbmUgb2YgdGhlIGFwcHJvYWNoZXMg ZmVlbCBmcmVlIHRvIHBpY2sgZWl0aGVyIG9uZS4KPiAKPiA+IAo+ID4gPiA+IAo+ID4gPiA+IFNp Z25lZC1vZmYtYnk6IFRvbSBPJ1JvdXJrZSA8VG9tLk8nUm91cmtlQGludGVsLmNvbT4KPiA+ID4g PiAtLS0KPiA+ID4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaCB8ICAgIDEgKwo+ ID4gPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oIHwgICAgMSArCj4gPiA+ID4g IGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMgfCAgICA5ICsrKysrKystLQo+ID4gPiA+ ICAzIGZpbGVzIGNoYW5nZWQsIDkgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPiA+ID4g PiAKPiA+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaCBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPiA+ID4gPiBpbmRleCAwZjAwZTU4Li5m ZDhiNTUwIDEwMDY0NAo+ID4gPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2 LmgKPiA+ID4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4gPiA+ID4g QEAgLTI5NTAsNiArMjk1MCw3IEBAIHZvaWQgZ2VuNl9ndF9mb3JjZV93YWtlX3B1dChzdHJ1Y3Qg ZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsIGludCBmd19lbmdpbmUpOwo+ID4gPiA+ICB2b2lk IGFzc2VydF9mb3JjZV93YWtlX2luYWN0aXZlKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZf cHJpdik7Cj4gPiA+ID4gIAo+ID4gPiA+ICBpbnQgc2FuZHlicmlkZ2VfcGNvZGVfcmVhZChzdHJ1 Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsIHU4IG1ib3gsIHUzMiAqdmFsKTsKPiA+ID4g PiAraW50IGhhc3dlbGxfcGNvZGVfd3JpdGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9w cml2LCB1OCBtYm94LCB1MzIgdmFsLCB1MzIgY29udHJvbCk7Cj4gPiA+ID4gIGludCBzYW5keWJy aWRnZV9wY29kZV93cml0ZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsIHU4IG1i b3gsIHUzMiB2YWwpOwo+ID4gPiA+ICAKPiA+ID4gPiAgLyogaW50ZWxfc2lkZWJhbmQuYyAqLwo+ ID4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oIGIvZHJp dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZWcuaAo+ID4gPiA+IGluZGV4IDZmYmZkZWMuLmI2NzQw NTAgMTAwNjQ0Cj4gPiA+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZWcuaAo+ ID4gPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmgKPiA+ID4gPiBAQCAt NjAxMSw2ICs2MDExLDcgQEAgZW51bSBwdW5pdF9wb3dlcl93ZWxsIHsKPiA+ID4gPiAgI2RlZmlu ZSAgIEdFTjZfREVDT0RFX1JDNl9WSUQodmlkcykJCSgoKHZpZHMpICogNSkgKyAyNDUpCj4gPiA+ ID4gICNkZWZpbmUgICBESVNQTEFZX0lQU19DT05UUk9MCQkJMHgxOQo+ID4gPiA+ICAjZGVmaW5l CSAgSFNXX1BDT0RFX0RZTkFNSUNfRFVUWV9DWUNMRV9DT05UUk9MCTB4MUEKPiA+ID4gPiArI2Rl ZmluZSAgIEhTV19QQ09ERV9BRERSX0NOVEwoY250bCkJCSgoY250bCA8PCA4KSAmIDB4MWZmZmZm MDApCj4gCj4gSSBkb24ndCB0aGluayB3ZSBuZWVkIHRoZSBtYXNrIGhlcmUuIFdlIGdlbmVyYWxs eSBkb24ndCBoYXZlIGl0LCB3aXRoIHNvbWUKPiBleGNlcHRpb25zIGxpa2UgdGhlIGNzYyBzdHVm ZiBJIGRpZCByZWNlbnRseSB3aGljaCBkZWFscyBpbiBzaWduZWQgdmFsdWVzLAo+IGFuZCBzbyBu ZWVkcyBpdCB0byBhdm9pZCB0aGUgc2lnbiBiaXRzIGZyb20gY2xvYmJlcmluZyBldmVyeXRoaW5n IGFib3ZlLgo+IAo+IEJ1dCBJIGhhdmUgYmVlbiBkcmVhbWluZyBvY2Nhc2lvbmFsbHkgYWJvdXQg aGF2aW5nIHN1Y2ggbWFjcm9zIGRlZmluZWQKPiBpbiBhIHdheSB0aGF0IHdvdWxkIGFsbG93IHVz IHRvIHZlcmlmeSB0aGF0IHdlIGRvbid0IG92ZXJmbG93IGFueXRoaW5nCj4gYnkgYWNjaWRlbnQu IEVnLiBzb21ldGhpbmcgbGlrZSB0aGlzOgo+IAo+ICNpZiBDT05GSUdfSTkxNV9DSEVDS19SRUdJ U1RFUlMKPiAjZGVmaW5lIF9CSVRGSUVMRCh2YWx1ZSxvZmZzZXQsc2l6ZSkgKHsgV0FSTl9PTigo dmFsdWUpICYgfigoMSA8PCAoc2l6ZSkpIC0gMSkpOyAoKHZhbHVlKSA8PCAoc2hpZnQpKSB9KQo+ ICNlbHNlCj4gI2RlZmluZSBfQklURklFTEQodmFsdWUsb2Zmc2V0LHNpemUpICgodmFsdWUpIDw8 IChzaGlmdCkpCj4gI2VuZGlmCj4gCj4gI2RlZmluZSBQQ09ERV9BRERSX0NOVEwoeCkgX0JJVEZJ RUxEKCh4KSwgOCwgMjEpCj4gCj4gQnV0IGNvbnZlcnRpbmcgZXZlcnl0aGluZyB3b3VsZCBiZSBh IGJpZyB0YXNrLCBlc3BlY2lhbGx5IGFzIHdlIGRvbid0Cj4gaGF2ZSBzdWNoIG1hY3JvcyBmb3Ig ZXZlcnl0aGluZy4gU29tZXRpbWVzIHdlIGp1c3QgaGF2ZSBhIHNoaWZ0IHZhbHVlLAo+IGFuZCBz b21ldGltZXMgbm90IGV2ZW4gdGhhdCBhbmQgd2UgY2FsY3VsYXRlIGEgc2hpZnQgdXNpbmcgc29t ZSBjYXNlCj4gc3BlY2lmaWMgbWFnaWMsIGFuZCBzb21ldGltZXMgdGhlIHNoaWZ0IGlzbid0IHN0 cmljdGx5IG5lZWRlZCAoZWcuCj4gaXQncyAwLCBvciBqdXN0IGhhcHBlbnMgdG8gbWF0Y2ggbmF0 dXJhbGx5IHRoZSBkYXRhIHdlIHN0dWZmIGluIHRoZXJlCj4gbGlrZSBpbiB0aGUgY2FzZSBvZiBw YWdlIGFsaWduZWQgYWRkcmVzc2VzKS4KPiAKSSBsaWtlIHRoZSBDT05GSUdfSTkxNV9DSEVDS19S RUdJU1RFUlMgaWRlYS4gIFVudGlsIHdlCmhhdmUgc29tZXRoaW5nIGxpa2UgdGhhdCwgSSB3b3Vs ZCBsaWtlIHRvIGtlZXAgdGhlIG1hc2suCkluIGFkZGl0aW9uIHRvIGFkZGluZyBhIGxpdHRsZSBz YWZldHksIHRoZSBtYXNrIG1ha2VzIGl0CmNsZWFyIGluIHRoZSBjb2RlIGhvdyBiaWcgdGhlIGZp ZWxkIHNob3VsZCBiZS4KCj4gPiA+ID4gICNkZWZpbmUgR0VONl9QQ09ERV9EQVRBCQkJCTB4MTM4 MTI4Cj4gPiA+ID4gICNkZWZpbmUgICBHRU42X1BDT0RFX0ZSRVFfSUFfUkFUSU9fU0hJRlQJOAo+ ID4gPiA+ICAjZGVmaW5lICAgR0VONl9QQ09ERV9GUkVRX1JJTkdfUkFUSU9fU0hJRlQJMTYKPiA+ ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMKPiA+ID4gPiBpbmRleCAxMjQ0ZmY4Li45YzQ3YmM4 IDEwMDY0NAo+ID4gPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMKPiA+ ID4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wbS5jCj4gPiA+ID4gQEAgLTcy NzcsNyArNzI3Nyw3IEBAIGludCBzYW5keWJyaWRnZV9wY29kZV9yZWFkKHN0cnVjdCBkcm1faTkx NV9wcml2YXRlICpkZXZfcHJpdiwgdTggbWJveCwgdTMyICp2YWwpCj4gPiA+ID4gIAlyZXR1cm4g MDsKPiA+ID4gPiAgfQo+ID4gPiA+ICAKPiA+ID4gPiAtaW50IHNhbmR5YnJpZGdlX3Bjb2RlX3dy aXRlKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwgdTggbWJveCwgdTMyIHZhbCkK PiA+ID4gPiAraW50IGhhc3dlbGxfcGNvZGVfd3JpdGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUg KmRldl9wcml2LCB1OCBtYm94LCB1MzIgdmFsLCB1MzIgY29udHJvbCkKPiA+ID4gPiAgewo+ID4g PiA+ICAJV0FSTl9PTighbXV0ZXhfaXNfbG9ja2VkKCZkZXZfcHJpdi0+cnBzLmh3X2xvY2spKTsK PiA+ID4gPiAgCj4gPiA+ID4gQEAgLTcyODcsNyArNzI4Nyw3IEBAIGludCBzYW5keWJyaWRnZV9w Y29kZV93cml0ZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsIHU4IG1ib3gsIHUz MiB2YWwpCj4gPiA+ID4gIAl9Cj4gPiA+ID4gIAo+ID4gPiA+ICAJSTkxNV9XUklURShHRU42X1BD T0RFX0RBVEEsIHZhbCk7Cj4gPiA+ID4gLQlJOTE1X1dSSVRFKEdFTjZfUENPREVfTUFJTEJPWCwg R0VONl9QQ09ERV9SRUFEWSB8IG1ib3gpOwo+ID4gPiA+ICsJSTkxNV9XUklURShHRU42X1BDT0RF X01BSUxCT1gsIEdFTjZfUENPREVfUkVBRFkgfCBtYm94IHwgSFNXX1BDT0RFX0FERFJfQ05UTChj b250cm9sKSk7Cj4gPiA+ID4gIAo+ID4gPiA+ICAJaWYgKHdhaXRfZm9yKChJOTE1X1JFQUQoR0VO Nl9QQ09ERV9NQUlMQk9YKSAmIEdFTjZfUENPREVfUkVBRFkpID09IDAsCj4gPiA+ID4gIAkJICAg ICA1MDApKSB7Cj4gPiA+ID4gQEAgLTczMDAsNiArNzMwMCwxMSBAQCBpbnQgc2FuZHlicmlkZ2Vf cGNvZGVfd3JpdGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LCB1OCBtYm94LCB1 MzIgdmFsKQo+ID4gPiA+ICAJcmV0dXJuIDA7Cj4gPiA+ID4gIH0KPiA+ID4gPiAgCj4gPiA+ID4g K2ludCBzYW5keWJyaWRnZV9wY29kZV93cml0ZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2 X3ByaXYsIHU4IG1ib3gsIHUzMiB2YWwpCj4gPiA+ID4gK3sKPiA+ID4gPiArCXJldHVybiBoYXN3 ZWxsX3Bjb2RlX3dyaXRlKGRldl9wcml2LCBtYm94LCB2YWwsIDApOwo+ID4gPiA+ICt9Cj4gPiA+ ID4gKwo+ID4gPiA+ICBzdGF0aWMgaW50IGJ5dF9ncHVfZnJlcShzdHJ1Y3QgZHJtX2k5MTVfcHJp dmF0ZSAqZGV2X3ByaXYsIGludCB2YWwpCj4gPiA+ID4gIHsKPiA+ID4gPiAgCWludCBkaXY7Cj4g PiA+ID4gLS0gCj4gPiA+ID4gMS43LjkuNQo+ID4gPiA+IAo+ID4gPiA+IF9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gPiA+ID4gSW50ZWwtZ2Z4IG1haWxp bmcgbGlzdAo+ID4gPiA+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiA+ID4gPiBo dHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cj4g PiA+IAo+ID4gPiAtLSAKPiA+ID4gVmlsbGUgU3lyasOkbMOkCj4gPiA+IEludGVsIE9UQwo+IAo+ IC0tIAo+IFZpbGxlIFN5cmrDpGzDpAo+IEludGVsIE9UQwpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdm eEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=