From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 6/6] drm/i915: Remove most INVALID_PIPE checks from VLV backlight code Date: Fri, 7 Nov 2014 14:51:23 +0200 Message-ID: <20141107125123.GV10649@intel.com> References: <1415351764-3514-1-git-send-email-ville.syrjala@linux.intel.com> <1415351764-3514-7-git-send-email-ville.syrjala@linux.intel.com> <87lhnn19m9.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id 608006E43C for ; Fri, 7 Nov 2014 04:51:26 -0800 (PST) Content-Disposition: inline In-Reply-To: <87lhnn19m9.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBOb3YgMDcsIDIwMTQgYXQgMDI6MjQ6NDZQTSArMDIwMCwgSmFuaSBOaWt1bGEgd3Jv dGU6Cj4gT24gRnJpLCAwNyBOb3YgMjAxNCwgdmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20g d3JvdGU6Cj4gPiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50 ZWwuY29tPgo+ID4KPiA+IE5vdyB0aGF0IHRoZSBiYWNrbGlnaHQgZGV2aWNlIG5vIGxvbmdlciBn ZXRzIHJlZ2lzdGVyZWQgdG9vIGVhcmx5IHdlCj4gPiBzaG91bGQgYmUgYWJsZSB0byBkcm9wIG1v c3Qgb2YgdGhlIElOVkFMSURfUElQRSBjaGVja3MgZm9ybSB0aGUgVkxWL0NIVgo+ID4gYmFja2xp Z2h0IGNvZGUuCj4gCj4gVGhlIHN1YmplY3QgYW5kIHRoaXMgcGFyYWdyYXBoIHJlZmVyIHRvIFZM Vi9DSFYgYnV0IHRoaXMgaXNuJ3QgcmVhbGx5Cj4gc3BlY2lmaWMgdG8gdGhvc2UgcGxhdGZvcm1z LgoKSG1tLiBNeSBhc3N1bXB0aW9uIHdhcyB0aGF0IHdlIGNhbid0IGdldCB0aGVzZSB3aXRoIG90 aGVyIHBsYXRmb3JtcywgYnV0CnRoZSBvcHJlZ2lvbiBtaWdodCBiZSBhIGJpdCBzcGVjaWFsIEkg YWdyZWUuCgo+IAo+ID4gSWYgd2Ugc3RpbGwgbWFuYWdlIHRvIGdldCBoZXJlIHdpdGggSU5WQUxJ RF9QSVBFIHdlIHdpbGwgbm93IGdldCBhIFdBUk4KPiA+IGZyb20gdGhlIGxvd2VyIGxldmVsIGZ1 bmN0aW9ucyBhbmQgY2FuIHRoZW4gYWN0dWFsbHkgaW52ZXN0aWdhdGUgZnVydGhlci4KPiA+Cj4g PiB2bHZfZ2V0X2JhY2tsaWdodCgpIHN0aWxsIG5lZWRzIHRoZSBjaGVjayBzaW5jZSB0aGF0IGdl dHMgY2FsbGVkIGluCj4gPiByZXNwb25zZSB0byB1c2Vyc3BhY2UgYWN0dWFsX2JyaWdodG5lc3Mg cmVhZHMuCj4gCj4gSUlVQyB0aGlzIGJpdCB3b24ndCBiZSB0cnVlIGlmIHlvdSBhZGQgdGhlIGJh Y2tsaWdodC5lbmFibGVkIGNoZWNrIGFzIEkKPiBzdWdnZXN0ZWQgZWFybGllci4KClllYWgsIEkg dGhpbmsgdGhhdCBzaG91bGQgY292ZXIgaXQuCgo+IAo+ID4KPiA+IFNpZ25lZC1vZmYtYnk6IFZp bGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gPiAtLS0KPiA+ ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wYW5lbC5jIHwgMTEgKysrKy0tLS0tLS0KPiA+ ICAxIGZpbGUgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspLCA3IGRlbGV0aW9ucygtKQo+ID4KPiA+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wYW5lbC5jIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfcGFuZWwuYwo+ID4gaW5kZXggMmJjMzMwOS4uMGUyY2IxMiAx MDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BhbmVsLmMKPiA+ICsr KyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BhbmVsLmMKPiA+IEBAIC02MzQsMTAgKzYz NCw5IEBAIHN0YXRpYyB2b2lkIGludGVsX3BhbmVsX3NldF9iYWNrbGlnaHQoc3RydWN0IGludGVs X2Nvbm5lY3RvciAqY29ubmVjdG9yLAo+ID4gIAlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2ID0gY29u bmVjdG9yLT5iYXNlLmRldjsKPiA+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2 ID0gZGV2LT5kZXZfcHJpdmF0ZTsKPiA+ICAJc3RydWN0IGludGVsX3BhbmVsICpwYW5lbCA9ICZj b25uZWN0b3ItPnBhbmVsOwo+ID4gLQllbnVtIHBpcGUgcGlwZSA9IGludGVsX2dldF9waXBlX2Zy b21fY29ubmVjdG9yKGNvbm5lY3Rvcik7Cj4gPiAgCXUzMiBod19sZXZlbDsKPiA+ICAKPiA+IC0J aWYgKCFwYW5lbC0+YmFja2xpZ2h0LnByZXNlbnQgfHwgcGlwZSA9PSBJTlZBTElEX1BJUEUpCj4g PiArCWlmICghcGFuZWwtPmJhY2tsaWdodC5wcmVzZW50KQo+ID4gIAkJcmV0dXJuOwo+ID4gIAo+ ID4gIAltdXRleF9sb2NrKCZkZXZfcHJpdi0+YmFja2xpZ2h0X2xvY2spOwo+ID4gQEAgLTY2Miwx MCArNjYxLDkgQEAgdm9pZCBpbnRlbF9wYW5lbF9zZXRfYmFja2xpZ2h0X2FjcGkoc3RydWN0IGlu dGVsX2Nvbm5lY3RvciAqY29ubmVjdG9yLAo+ID4gIAlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2ID0g Y29ubmVjdG9yLT5iYXNlLmRldjsKPiA+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9w cml2ID0gZGV2LT5kZXZfcHJpdmF0ZTsKPiA+ICAJc3RydWN0IGludGVsX3BhbmVsICpwYW5lbCA9 ICZjb25uZWN0b3ItPnBhbmVsOwo+ID4gLQllbnVtIHBpcGUgcGlwZSA9IGludGVsX2dldF9waXBl X2Zyb21fY29ubmVjdG9yKGNvbm5lY3Rvcik7Cj4gPiAgCXUzMiBod19sZXZlbDsKPiA+ICAKPiA+ IC0JaWYgKCFwYW5lbC0+YmFja2xpZ2h0LnByZXNlbnQgfHwgcGlwZSA9PSBJTlZBTElEX1BJUEUp Cj4gPiArCWlmICghcGFuZWwtPmJhY2tsaWdodC5wcmVzZW50KQo+ID4gIAkJcmV0dXJuOwo+IAo+ IEkgaGF2ZSBhIGZlZWxpbmcgd2UgbWF5IGdldCB0aGVzZSByZXF1ZXN0cyBmcm9tIHRoZSBCSU9T IHdoZW5ldmVyLiBJbgo+IHRoZW9yeSB3ZSBzaG91bGQgdXNlIHRoZSBvcHJlZ2lvbiBBUkRZIGZp ZWxkIG9yIHNvbWVzdWNoIHRvIGNvbW11bmljYXRlCj4gd2hldGhlciB3ZSdyZSByZWFkeSBvciBu b3QgKHdlIGFsd2F5cyBzYXkgd2UncmUgcmVhZHkgbGlrZSBhIHNjb3V0KSBidXQKPiBldmVuIHNv IHdlIGNhbid0IHRydXN0IHRoZSBCSU9TIHRvIGxpc3RlbiB0byB3aGF0IHdlIHNheS4gTG9uZyBz dG9yeQo+IHNob3J0IHdlIHNob3VsZCBwcm9iYWJseSBsZWF2ZSB0aGlzIGNoZWNrIGluLgoKV2Ug ZG8gY2hlY2sgYmFja2xpZ2h0LmVuYWJsZWQgaGVyZSBhcyB3ZWxsLCBhbmQgSSB0aGluayB3ZSBn cmFiIGFsbCB0aGUKcmVxdWlyZWQgbG9ja3Mgd2hlbiBzZXJ2aWNpbmcgdGhlIG9wcmVnaW9uIHJl cXVlc3RzLiBTbyBJJ20gdGhpbmtpbmcgd2UKZG9uJ3QgbmVlZCB0aGUgY2hlY2sgaGVyZSBlaXRo ZXIuIE9yIGFtIEkgbWlzc2luZyBzb21ldGhpbmc/Cgo+IAo+IFdpdGggdGhvc2UgZml4ZWQgdGhp cyBMR1RNLgo+IAo+IEJSLAo+IEphbmkuCj4gCj4gCj4gPiAgCj4gPiAgCW11dGV4X2xvY2soJmRl dl9wcml2LT5iYWNrbGlnaHRfbG9jayk7Cj4gPiBAQCAtNzQwLDkgKzczOCw4IEBAIHZvaWQgaW50 ZWxfcGFuZWxfZGlzYWJsZV9iYWNrbGlnaHQoc3RydWN0IGludGVsX2Nvbm5lY3RvciAqY29ubmVj dG9yKQo+ID4gIAlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2ID0gY29ubmVjdG9yLT5iYXNlLmRldjsK PiA+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gZGV2LT5kZXZfcHJpdmF0 ZTsKPiA+ICAJc3RydWN0IGludGVsX3BhbmVsICpwYW5lbCA9ICZjb25uZWN0b3ItPnBhbmVsOwo+ ID4gLQllbnVtIHBpcGUgcGlwZSA9IGludGVsX2dldF9waXBlX2Zyb21fY29ubmVjdG9yKGNvbm5l Y3Rvcik7Cj4gPiAgCj4gPiAtCWlmICghcGFuZWwtPmJhY2tsaWdodC5wcmVzZW50IHx8IHBpcGUg PT0gSU5WQUxJRF9QSVBFKQo+ID4gKwlpZiAoIXBhbmVsLT5iYWNrbGlnaHQucHJlc2VudCkKPiA+ ICAJCXJldHVybjsKPiA+ICAKPiA+ICAJLyoKPiA+IEBAIC05NDksNyArOTQ2LDcgQEAgdm9pZCBp bnRlbF9wYW5lbF9lbmFibGVfYmFja2xpZ2h0KHN0cnVjdCBpbnRlbF9jb25uZWN0b3IgKmNvbm5l Y3RvcikKPiA+ICAJc3RydWN0IGludGVsX3BhbmVsICpwYW5lbCA9ICZjb25uZWN0b3ItPnBhbmVs Owo+ID4gIAllbnVtIHBpcGUgcGlwZSA9IGludGVsX2dldF9waXBlX2Zyb21fY29ubmVjdG9yKGNv bm5lY3Rvcik7Cj4gPiAgCj4gPiAtCWlmICghcGFuZWwtPmJhY2tsaWdodC5wcmVzZW50IHx8IHBp cGUgPT0gSU5WQUxJRF9QSVBFKQo+ID4gKwlpZiAoIXBhbmVsLT5iYWNrbGlnaHQucHJlc2VudCkK PiA+ICAJCXJldHVybjsKPiA+ICAKPiA+ICAJRFJNX0RFQlVHX0tNUygicGlwZSAlY1xuIiwgcGlw ZV9uYW1lKHBpcGUpKTsKPiA+IC0tIAo+ID4gMi4wLjQKPiA+Cj4gPiBfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+ID4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlz dAo+ID4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ID4gaHR0cDovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo+IAo+IC0tIAo+IEphbmkg TmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5IENlbnRlcgoKLS0gClZpbGxlIFN5 cmrDpGzDpApJbnRlbCBPVEMKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRl bC1nZngK