public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915: Don't initialize pipe config after choosing DPLLs.
@ 2014-11-08  0:07 Bob Paauwe
  2014-11-08  8:55 ` [PATCH] drm/i915: Don't initialize pipe config after shuang.he
                   ` (2 more replies)
  0 siblings, 3 replies; 11+ messages in thread
From: Bob Paauwe @ 2014-11-08  0:07 UTC (permalink / raw)
  To: intel-gfx; +Cc: Ander Conselvan de Oliveira

The pipe config needs to be initialized before calling crtc_compute_clock
since this will update the new_config structure DPLL values. Initializing
the new_config structure after calling crtc_compute_clock can result in
incorrect timing values.

This regression was introduced in

commit 0dbdf89f27b17ae1eceed6782c2917f74cbb5d59
Author: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
Date:   Wed Oct 29 11:32:33 2014 +0200

    drm/i915: Add infrastructure for choosing DPLLs before disabling crtcs

	and

	commit 00d958817dd3daaa452c221387ddaf23d1e4c06f
	Author: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
	Date:   Wed Oct 29 11:32:36 2014 +0200

	    drm/i915: Covert remaining platforms to choose DPLLS before disabling CRTCs

Signed-off-by: Bob Paauwe <bob.j.paauwe@intel.com>
CC: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
---
 drivers/gpu/drm/i915/intel_display.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index ff071a7..53f3d3a 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -10774,7 +10774,11 @@ static int __intel_set_mode(struct drm_crtc *crtc,
 		}
 		intel_dump_pipe_config(to_intel_crtc(crtc), pipe_config,
 				       "[modeset]");
-		to_intel_crtc(crtc)->new_config = pipe_config;
+
+		/* mode_set/enable/disable functions rely on a correct pipe
+		 * config. */
+		to_intel_crtc(crtc)->config = *pipe_config;
+		to_intel_crtc(crtc)->new_config = &to_intel_crtc(crtc)->config;
 	}
 
 	/*
@@ -10820,10 +10824,6 @@ static int __intel_set_mode(struct drm_crtc *crtc,
 	 */
 	if (modeset_pipes) {
 		crtc->mode = *mode;
-		/* mode_set/enable/disable functions rely on a correct pipe
-		 * config. */
-		to_intel_crtc(crtc)->config = *pipe_config;
-		to_intel_crtc(crtc)->new_config = &to_intel_crtc(crtc)->config;
 
 		/*
 		 * Calculate and store various constants which
-- 
1.8.3.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 11+ messages in thread
end of thread, other threads:[~2014-11-12 14:10 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-08  0:07 [PATCH] drm/i915: Don't initialize pipe config after choosing DPLLs Bob Paauwe
2014-11-08  8:55 ` [PATCH] drm/i915: Don't initialize pipe config after shuang.he
2014-11-10 10:40 ` [PATCH] drm/i915: Don't initialize pipe config after choosing DPLLs Ville Syrjälä
2014-11-10 22:50   ` Bob Paauwe
2014-11-10 23:09 ` [PATCH] drm/i915: Use correct pipe config to update pll dividers Bob Paauwe
2014-11-11  9:16   ` Ander Conselvan de Oliveira
2014-11-11 17:29     ` [PATCH] drm/i915: Use correct pipe config to update pll dividers. V2 Bob Paauwe
2014-11-11 18:34       ` Jesse Barnes
2014-11-12  9:23         ` Daniel Vetter
2014-11-12 14:08       ` [PATCH] drm/i915: Use correct pipe config to update pll shuang.he
2014-11-11 21:19   ` shuang.he

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox