From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] Revert "drm/i915/vlv: Remove check for Old Ack during forcewake" Date: Tue, 11 Nov 2014 11:24:32 +0100 Message-ID: <20141111102432.GL25711@phenom.ffwll.local> References: <20141105124202.GK26941@phenom.ffwll.local> <1415201452-28754-1-git-send-email-mika.kuoppala@intel.com> <20141106140915.GC26941@phenom.ffwll.local> <545CDE1D.9060506@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f180.google.com (mail-wi0-f180.google.com [209.85.212.180]) by gabe.freedesktop.org (Postfix) with ESMTP id C64446E4B1 for ; Tue, 11 Nov 2014 02:24:14 -0800 (PST) Received: by mail-wi0-f180.google.com with SMTP id hi2so1119989wib.7 for ; Tue, 11 Nov 2014 02:24:14 -0800 (PST) Content-Disposition: inline In-Reply-To: <545CDE1D.9060506@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Dave Gordon Cc: Ben Widawsky , intel-gfx@lists.freedesktop.org, Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBOb3YgMDcsIDIwMTQgYXQgMDI6NTg6MzdQTSArMDAwMCwgRGF2ZSBHb3Jkb24gd3Jv dGU6Cj4gT24gMDYvMTEvMTQgMTQ6MDksIERhbmllbCBWZXR0ZXIgd3JvdGU6Cj4gPiBPbiBXZWQs IE5vdiAwNSwgMjAxNCBhdCAwNTozMDo1MlBNICswMjAwLCBNaWthIEt1b3BwYWxhIHdyb3RlOgo+ ID4+IFRoaXMgcmV2ZXJ0cyBjb21taXQgNWNiMTNjMDdkYWU3MzM4MGQ4YjNkZGM3OTI3NDA0ODdi ODc0MjkzOC4KPiA+Pgo+ID4+IFdoaWxlIHRoZSByZWxldmFuY2UgZm9yIFdhUnNEb250UG9sbEZv ckFja09uQ2xlYXJpbmdGV0JpdHMgaXMgdW5kZXIKPiA+PiBpbnZlc3RpZ2F0aW9uLCByZXZlcnQg dGhpcyBhcyByZWdyZXNzaW9uLgo+ID4+Cj4gPj4gQnVnemlsbGE6IGh0dHBzOi8vYnVncy5mcmVl ZGVza3RvcC5vcmcvc2hvd19idWcuY2dpP2lkPTg1Njg0Cj4gPj4gVGVzdGVkLWJ5OiAgIFRlc3Rl ZC1ieTogbHUgaHVhIDxodWF4Lmx1QGludGVsLmNvbT4KPiA+PiBDYzogQ2hyaXMgV2lsc29uIDxj aHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4gPj4gQ2M6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUu c3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gPj4gQ2M6IFMsIERlZXBhayA8ZGVlcGFrLnNAaW50 ZWwuY29tPgo+ID4+IFNpZ25lZC1vZmYtYnk6IE1pa2EgS3VvcHBhbGEgPG1pa2Eua3VvcHBhbGFA aW50ZWwuY29tPgo+ID4gCj4gPiBRdWV1ZWQgZm9yIC1uZXh0LCB0aGFua3MgZm9yIHRoZSBwYXRj aC4KPiA+IC1EYW5pZWwKPiA+IAo+IAo+IEhpLAo+IAo+IHdoaWxlIGxvb2tpbmcgYXQgdGhlIChz ZW1pLWdlbmVyaWMpIGZvcmNlIHdha2UgY29kZSBpbiB0aGUgZnVuY3Rpb24KPiBnZW42X2d0X2Zv cmNlX3dha2VfZ2V0KCksIEkgbm90aWNlZCB0aGF0IGlmIHRoZSBwbGF0Zm9ybSBkb2Vzbid0IHBy b3ZpZGUKPiBhIGxvdy1sZXZlbCBmb3JjZXdha2UgcmVnaXN0ZXItYWNjZXNzIGZ1bmN0aW9uLCB0 aGVuIHdlIG9taXQgdGhlIFBNCj4gZ2V0L3B1dCBjYWxscyBhcyB3ZWxsLgo+IAo+ID4gdm9pZCBn ZW42X2d0X2ZvcmNlX3dha2VfZ2V0KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwg aW50IGZ3X2VuZ2luZSkKPiA+IHsKPiA+ICAgICAgICAgdW5zaWduZWQgbG9uZyBpcnFmbGFnczsK PiA+IAo+ID4gICAgICAgICBpZiAoIWRldl9wcml2LT51bmNvcmUuZnVuY3MuZm9yY2Vfd2FrZV9n ZXQpCj4gPiAgICAgICAgICAgICAgICAgcmV0dXJuOwo+ID4gCj4gPiAgICAgICAgIGludGVsX3J1 bnRpbWVfcG1fZ2V0KGRldl9wcml2KTsKPiA+IAo+ID4gICAgICAgICAvKiBSZWRpcmVjdCB0byBH ZW45IHNwZWNpZmljIHJvdXRpbmUgKi8KPiA+ICAgICAgICAgaWYgKElTX0dFTjkoZGV2X3ByaXYt PmRldikpCj4gPiAgICAgICAgICAgICAgICAgcmV0dXJuIGdlbjlfZm9yY2Vfd2FrZV9nZXQoZGV2 X3ByaXYsIGZ3X2VuZ2luZSk7Cj4gPiAKPiA+ICAgICAgICAgLyogUmVkaXJlY3QgdG8gVkxWIHNw ZWNpZmljIHJvdXRpbmUgKi8KPiA+ICAgICAgICAgaWYgKElTX1ZBTExFWVZJRVcoZGV2X3ByaXYt PmRldikpCj4gPiAgICAgICAgICAgICAgICAgcmV0dXJuIHZsdl9mb3JjZV93YWtlX2dldChkZXZf cHJpdiwgZndfZW5naW5lKTsKPiA+IAo+ID4gICAgICAgICBzcGluX2xvY2tfaXJxc2F2ZSgmZGV2 X3ByaXYtPnVuY29yZS5sb2NrLCBpcnFmbGFncyk7Cj4gPiAgICAgICAgIGlmIChkZXZfcHJpdi0+ dW5jb3JlLmZvcmNld2FrZV9jb3VudCsrID09IDApCj4gPiAgICAgICAgICAgICAgICAgZGV2X3By aXYtPnVuY29yZS5mdW5jcy5mb3JjZV93YWtlX2dldChkZXZfcHJpdiwgRk9SQ0VXQUtFX0FMTCk7 Cj4gPiAgICAgICAgIHNwaW5fdW5sb2NrX2lycXJlc3RvcmUoJmRldl9wcml2LT51bmNvcmUubG9j aywgaXJxZmxhZ3MpOwo+ID4gfQo+IAo+IERvZXMgYW55b25lIGtub3cgd2hldGhlciB0aGlzIGlz IGludGVudGlvbmFsLCBvciBqdXN0IGFuIGFjY2lkZW50IG9mIHRoZQo+IGN1cnJlbnQgaW1wbGVt ZW50YXRpb24/IFByZXN1bWFibHkgd2UgZG9uJ3QgaGF2ZSBhbnkgcGxhdGZvcm1zIHdoZXJlCj4g dGhpcyBhcHBsaWVzLCBidXQgd2UgaXMgaXQgcGxhdXNpYmxlIHRoYXQgc29tZSBmdXR1cmUgZGV2 aWNlIG1pZ2h0IHdhbnQKPiB0aGUgcnVudGltZSBQTSBlZmZlY3RzIHdpdGhvdXQgYWN0dWFsbHkg aGF2aW5nIGgvdyBzdXBwb3J0Cj4gZm9yIGZvcmNld2FrZT8KPiAKPiBBbHRlcm5hdGl2ZWx5LCB3 aHkgZG8gd2UgbmVlZCB0aGUgcnVudGltZSBQTSBjYWxscyBpbiBoZXJlPyBJIGNhbiBzZWUKPiBQ YW9sbydzIGNvbW1pdCAiYzhjOGZiMyBkcm0vaTkxNTogYWRkIHNvbWUgcnVudGltZSBQTSBnZXQv cHV0IGNhbGxzIgo+IGFkZGVkIGxvdHMgb2YgZ2V0L3B1dCBwYWlycyByb3VuZCB2YXJpb3VzIHNl cXVlbmNlcyBvZiBvcGVyYXRpb25zIGluCj4gZGVidWdmcyBldGMsIHNvIHdoeSBkbyB3ZSBhbHNv IG5lZWQgdGhlbSBhdCB0aGlzIGlubmVyIGxldmVsPyBJcyBpdCBqdXN0Cj4gdG8gY2F0Y2ggYW55 IGNhc2VzIHdoZXJlIHRoZSBjYWxsZXIgc2hvdWxkIGhhdmUgKGJ1dCBkaWRuJ3QpIGRlYWwgd2l0 aAo+IHJ1bnRpbWUgUE0gYWxyZWFkeT8KClRoZSBpZGVhIGlzIHRoYXQgcG93ZXIgZG9tYWlucyBu ZXN0LCBhbmQgdGhlIGlubmVyIHBvd2VyIGRvbWFpbnMgZ3JhYiB0aGUKcmVmZXJlbmNlIGZvciB0 aGUgb3V0ZXIgZG9tYWlucyBmb3IgeW91LgoKQWxsIHRoZSBwbGFjZXMgcGF1bG8gc3ByaW5rbGVk IHJ1bnRpbWUgcG0gb3ZlciBkb24ndCBuZWVkIGFueXRoaW5nIGVsc2UKdGhhbiB0aGUgZGV2aWNl IG91dCBvZiBEMywgb3IgYXQgbGVhc3QgdGhhdCB3YXMgdGhlIGlkZWEuIFNvIGlmIHlvdSB3YW50 CnRvIHdha2UgdGhlIGd0IHdlJ2xsIGF1dG9tYXRpY2FsbHkgZ2V0IHRoZSBkZXZpY2Ugb3V0IG9m IEQzLiBBbmQgb24gdGhlCmRpc3BsYXkgc2lkZSB3aGVyZSBwb3dlciBkb21haW5zIGNhbiBuZXN0 IGV2ZW4gbW9yZSBpdCdsbCB3YWtlIHVwIHRoZQplbnRpcmUgY2hhaW4uIFdpdGhvdXQgdGhpcyB0 aGUgZW50aXJlIGFic3RyYWN0aW9uIG9mIG1hcHBpbmcgZ2VuZXJpYyBwb3dlcgpkb21haW5zIG9u dG8gd2hhdCB0aGUgaHcgYWN0dWFsbHkgbG9va3MgbGlrZSBmYWxscyBhcGFydC4gQW5kIHdpdGhv dXQgdGhhdApvdXIgZHJpdmVyIHdvdWxkIGJlIGEgcHJldHR5IGNyYXp5IG1lc3MgOy0pCi1EYW5p ZWwKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9u Cis0MSAoMCkgNzkgMzY1IDU3IDQ4IC0gaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlz dApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK