Re: [PATCH 00/10] drm-intel-collector - update

From: Daniel Vetter <daniel@ffwll.ch>
To: "Chris Wilson" <chris@chris-wilson.co.uk>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
	intel-gfx@lists.freedesktop.org,
	"Rodrigo Vivi" <rodrigo.vivi@intel.com>
Subject: Re: [PATCH 00/10] drm-intel-collector - update
Date: Tue, 11 Nov 2014 12:54:13 +0100	[thread overview]
Message-ID: <20141111115413.GO25711@phenom.ffwll.local> (raw)
In-Reply-To: <20141111102211.GC8220@nuc-i3427.alporthouse.com>

On Tue, Nov 11, 2014 at 10:22:11AM +0000, Chris Wilson wrote:
> On Tue, Nov 11, 2014 at 11:20:14AM +0100, Daniel Vetter wrote:
> > On Thu, Nov 06, 2014 at 09:57:29AM +0200, Ville Syrjälä wrote:
> > > On Tue, Nov 04, 2014 at 04:51:38AM -0800, Rodrigo Vivi wrote:
> > > > Patch     drm/i915: Make the physical object coherent with GTT - Reviewer:
> > > 
> > > Already has my r-b.
> > 
> > I still would like to see a little testcase here, e.g. a new mode to
> > kms_cursor_crc which uses gtt mmap uploads instead of pwrite.
> 
> But that doesn't block this patch, as the kernel already exposes and
> userspace already uses gtt mmap updates to the cursor. The patch just
> removes the barrier to do so using early chipsets as well.

Well yeah, but that existing code has piles of tests already to make sure
that gtt writes are somewhat coherent with pwrite, and another test that
pwrite is coherent with the actual cursor scanned out by hw.

This otoh adds new code, without igt test coverage. So there is a new test
coverage gap.

Anyway I've decided that the cleanup is worth it on its own and the
platform this applies to are too old to really care, so merged the patch
without tests.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx