From: Daniel Vetter <daniel@ffwll.ch>
To: Michel Thierry <michel.thierry@intel.com>
Cc: "S, Deepak" <deepak.s@intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915: Initialize workarounds in logical ring mode too
Date: Tue, 11 Nov 2014 15:44:47 +0100 [thread overview]
Message-ID: <20141111144447.GS25711@phenom.ffwll.local> (raw)
In-Reply-To: <5461F462.4080603@intel.com>
On Tue, Nov 11, 2014 at 11:34:58AM +0000, Michel Thierry wrote:
> On 11/10/2014 4:38 PM, Mika Kuoppala wrote:
> >>- int (*init_context)(struct intel_engine_cs *ring);
> >>+ int (*init_context)(struct intel_ringbuffer *ringbuf);
> >What is the rationale of this? This seems odd.
> >
> >Why not:
> >
> >int (*init_context)(struct intel_engine_cs *ring,
> > struct intel_context *ctx);
> >
> >-Mika
>
> We want to have the emit function for both legacy and execlist submission
> modes (intel_ring_workarounds_emit & intel_logical_ring_workarounds_emit).
> It's easy to get the ring from a ringbuf, but not the other way around.
ctx already has the ringbuf pointer for execlist that you are looking for.
And for legacy contexts there's only one, per-engine. So from that quick
look Mika's interface proposal does make more sense to me.
-Daneil
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2014-11-11 14:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-28 17:19 [PATCH] drm/i915: Initialize workarounds in logical ring mode too Arun Siluvery
2014-11-10 16:38 ` Mika Kuoppala
2014-11-11 11:34 ` Michel Thierry
2014-11-11 14:44 ` Daniel Vetter [this message]
2014-11-11 15:49 ` [PATCH v3] " Michel Thierry
2014-11-11 16:10 ` Mika Kuoppala
2014-11-12 8:29 ` Daniel Vetter
2014-11-12 11:15 ` [PATCH v3] drm/i915: Initialize workarounds in logical shuang.he
2014-11-11 16:47 ` [PATCH v4] drm/i915: Initialize workarounds in logical ring mode too Michel Thierry
2014-11-11 16:59 ` Mika Kuoppala
2014-11-12 8:30 ` Daniel Vetter
2014-11-12 8:32 ` Daniel Vetter
2014-11-12 13:08 ` [PATCH v4] drm/i915: Initialize workarounds in logical shuang.he
-- strict thread matches above, loose matches on Subject: below --
2014-10-28 16:40 [PATCH] drm/i915: Initialize workarounds in logical ring mode too Arun Siluvery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141111144447.GS25711@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=deepak.s@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=michel.thierry@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox