From: Daniel Vetter <daniel@ffwll.ch>
To: "Chris Wilson" <chris@chris-wilson.co.uk>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
intel-gfx@lists.freedesktop.org,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>
Subject: Re: [PATCH 00/10] drm-intel-collector - update
Date: Tue, 11 Nov 2014 15:48:47 +0100 [thread overview]
Message-ID: <20141111144847.GT25711@phenom.ffwll.local> (raw)
In-Reply-To: <20141111115716.GD8220@nuc-i3427.alporthouse.com>
On Tue, Nov 11, 2014 at 11:57:16AM +0000, Chris Wilson wrote:
> On Tue, Nov 11, 2014 at 12:54:13PM +0100, Daniel Vetter wrote:
> > On Tue, Nov 11, 2014 at 10:22:11AM +0000, Chris Wilson wrote:
> > > On Tue, Nov 11, 2014 at 11:20:14AM +0100, Daniel Vetter wrote:
> > > > On Thu, Nov 06, 2014 at 09:57:29AM +0200, Ville Syrjälä wrote:
> > > > > On Tue, Nov 04, 2014 at 04:51:38AM -0800, Rodrigo Vivi wrote:
> > > > > > Patch drm/i915: Make the physical object coherent with GTT - Reviewer:
> > > > >
> > > > > Already has my r-b.
> > > >
> > > > I still would like to see a little testcase here, e.g. a new mode to
> > > > kms_cursor_crc which uses gtt mmap uploads instead of pwrite.
> > >
> > > But that doesn't block this patch, as the kernel already exposes and
> > > userspace already uses gtt mmap updates to the cursor. The patch just
> > > removes the barrier to do so using early chipsets as well.
> >
> > Well yeah, but that existing code has piles of tests already to make sure
> > that gtt writes are somewhat coherent with pwrite, and another test that
> > pwrite is coherent with the actual cursor scanned out by hw.
>
> Really? I doubt the current coverage since I keep seeing cursor bugs...
Well they do tend to randomly fail here. Not sure whether that's the same
bug or a different one ... Ofc tests without people looking aren't too
useful, but we have to start somewhere.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2014-11-11 14:48 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-04 12:51 [PATCH 00/10] drm-intel-collector - update Rodrigo Vivi
2014-11-04 12:51 ` [PATCH 01/10] drm/i915: Check the minimum pitch for the user framebuffer Rodrigo Vivi
2014-11-04 12:51 ` [PATCH 02/10] drm/i915: Make the physical object coherent with GTT Rodrigo Vivi
2014-11-04 12:51 ` [PATCH 03/10] drm/i915/chv: Use timeout mode for RC6 on chv Rodrigo Vivi
2014-11-04 22:36 ` O'Rourke, Tom
2014-11-04 12:51 ` [PATCH 04/10] drm/i915: Specify bsd rings through exec flag Rodrigo Vivi
2014-11-04 12:51 ` [PATCH 05/10] drm/i915: add I915_PARAM_HAS_BSD2 to i915_getparam Rodrigo Vivi
2014-11-04 12:51 ` [PATCH 06/10] drm/i915: Enable vblank interrupts for CRC generation Rodrigo Vivi
2014-11-06 8:31 ` Damien Lespiau
2014-11-04 12:51 ` [PATCH 07/10] drm/i915: Move the ban period onto the context Rodrigo Vivi
2014-11-04 12:51 ` [PATCH 08/10] drm/i915: Add ioctl to set per-context parameters Rodrigo Vivi
2014-11-04 12:51 ` [PATCH 09/10] drm/i915: Put logical pipe_control emission into a helper Rodrigo Vivi
2014-11-04 12:51 ` [PATCH 10/10] drm/i915: Add WaCsStallBeforeStateCacheInvalidate:bdw, chv to logical ring Rodrigo Vivi
2014-11-06 0:42 ` [PATCH 00/10] drm-intel-collector - update Rodrigo Vivi
2014-11-06 7:57 ` Ville Syrjälä
2014-11-11 10:20 ` Daniel Vetter
2014-11-11 10:22 ` Chris Wilson
2014-11-11 11:54 ` Daniel Vetter
2014-11-11 11:57 ` Chris Wilson
2014-11-11 14:48 ` Daniel Vetter [this message]
2014-11-11 12:16 ` Ville Syrjälä
2014-11-11 12:26 ` Chris Wilson
2014-11-11 12:38 ` Ville Syrjälä
2014-11-11 12:43 ` Chris Wilson
2014-11-11 14:50 ` Daniel Vetter
-- strict thread matches above, loose matches on Subject: below --
2014-07-03 21:32 Rodrigo Vivi
2014-07-08 19:09 ` Daniel Vetter
2014-07-03 21:31 Rodrigo Vivi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141111144847.GT25711@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox