From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org, shuang.he@linux.intel.com
Subject: Re: [PATCH 3/6] drm/i915/hdmi: fetch infoframe status in get_config v2
Date: Tue, 11 Nov 2014 17:19:46 +0200 [thread overview]
Message-ID: <20141111151946.GJ10649@intel.com> (raw)
In-Reply-To: <20141111150012.GV25711@phenom.ffwll.local>
On Tue, Nov 11, 2014 at 04:00:12PM +0100, Daniel Vetter wrote:
> On Wed, Nov 05, 2014 at 02:26:08PM -0800, Jesse Barnes wrote:
> > This is useful for checking things later.
> >
> > v2:
> > - fix hsw infoframe enabled check (Ander)
> >
> > Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> > ---
> > drivers/gpu/drm/i915/intel_drv.h | 4 +++
> > drivers/gpu/drm/i915/intel_hdmi.c | 62 +++++++++++++++++++++++++++++++++++++++
> > 2 files changed, 66 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h
> > index d53ac23..8aa80e1 100644
> > --- a/drivers/gpu/drm/i915/intel_drv.h
> > +++ b/drivers/gpu/drm/i915/intel_drv.h
> > @@ -292,6 +292,9 @@ struct intel_crtc_config {
> > * between pch encoders and cpu encoders. */
> > bool has_pch_encoder;
> >
> > + /* Are we sending infoframes on the attached port */
> > + bool has_infoframe;
>
> The cross-checking of this new hw state is missing. I've added that while
> applying.
Where is the compute_config part of this? I can't see it in any patch,
but maybe I'm just blind.
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2014-11-11 15:19 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-05 22:26 [PATCH 1/6] drm/i915: factor out compute_config from __intel_set_mode v3 Jesse Barnes
2014-11-05 22:26 ` [PATCH 2/6] drm/i915: use compute_config in set_config v3 Jesse Barnes
2014-11-07 9:41 ` Ander Conselvan de Oliveira
2014-11-07 16:59 ` Jesse Barnes
2014-11-07 21:11 ` [PATCH] drm/i915: use compute_config in set_config v4 Jesse Barnes
2014-11-10 16:09 ` Ander Conselvan de Oliveira
2014-11-05 22:26 ` [PATCH 3/6] drm/i915/hdmi: fetch infoframe status in get_config v2 Jesse Barnes
2014-11-10 16:09 ` Ander Conselvan de Oliveira
2014-11-11 15:00 ` Daniel Vetter
2014-11-11 15:19 ` Ville Syrjälä [this message]
2014-11-11 15:23 ` Daniel Vetter
2014-11-11 15:59 ` Jesse Barnes
2014-11-05 22:26 ` [PATCH 4/6] drm/i915: check for audio and infoframe changes across mode sets v2 Jesse Barnes
2014-11-10 16:09 ` Ander Conselvan de Oliveira
2014-12-01 10:25 ` Jani Nikula
2014-12-01 16:04 ` Jesse Barnes
2014-12-01 16:09 ` Chris Wilson
2014-12-01 16:30 ` Daniel Vetter
2014-12-01 16:37 ` Chris Wilson
2014-12-01 17:23 ` Daniel Vetter
2014-12-01 17:35 ` Jani Nikula
2014-12-01 19:26 ` Daniel Vetter
2014-12-01 16:16 ` Daniel Vetter
2014-12-01 17:22 ` Jesse Barnes
2014-11-05 22:26 ` [PATCH 5/6] drm/i915: update pipe size at set_config time Jesse Barnes
2014-11-10 16:09 ` Ander Conselvan de Oliveira
2014-11-11 15:08 ` Daniel Vetter
2014-11-05 22:26 ` [PATCH 6/6] drm/i915: calculate pfit changes in set_config v2 Jesse Barnes
2014-11-06 8:43 ` [PATCH 6/6] drm/i915: calculate pfit changes in shuang.he
2014-11-10 16:20 ` [PATCH 6/6] drm/i915: calculate pfit changes in set_config v2 Ander Conselvan de Oliveira
2014-11-10 16:32 ` Jesse Barnes
2014-11-06 9:04 ` [PATCH 1/6] drm/i915: factor out compute_config from __intel_set_mode v3 Chris Wilson
2014-11-06 14:34 ` Daniel Vetter
2014-11-10 16:08 ` Ander Conselvan de Oliveira
-- strict thread matches above, loose matches on Subject: below --
2014-10-30 18:53 [PATCH 1/6] drm/i915: factor out compute_config from __intel_set_mode v2 Jesse Barnes
2014-10-30 18:54 ` [PATCH 3/6] drm/i915/hdmi: fetch infoframe status in get_config v2 Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141111151946.GJ10649@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=shuang.he@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox