From: Daniel Vetter <daniel@ffwll.ch>
To: Neil Roberts <neil@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2] drm/i915: Add the predicate source registers to the register whitelist
Date: Tue, 11 Nov 2014 16:26:50 +0100 [thread overview]
Message-ID: <20141111152650.GC25711@phenom.ffwll.local> (raw)
In-Reply-To: <1415386826-18648-1-git-send-email-neil@linux.intel.com>
On Fri, Nov 07, 2014 at 07:00:26PM +0000, Neil Roberts wrote:
> The predicate source registers are needed to implement conditional
> rendering without stalling. The two source registers are used to load
> the previous values of the PS_DEPTH_COUNT register saved from
> PIPE_CONTROL commands. These can then be compared and used to set the
> predicate enable bit via the MI_PREDICATE command.
>
> The command parser version number is increased to 2 to make it easier
> to detect the new functionality in user space.
>
> Signed-off-by: Neil Roberts <neil@linux.intel.com>
> ---
>
> Here is a v2 of the patch that also updates the command parser version
> to make it easier to detect whether we can use the register in Mesa.
> I have posted a second version of the Mesa patch which uses this here:
>
> http://lists.freedesktop.org/archives/mesa-dev/2014-November/070362.html
>
> This was suggested by Glenn Kennard.
Ok, I've merged this one, since that means you at least won't get an
-EINVAL. But you can't yet enable the feature in mesa since it's still
no-opped out. Let's hope that v3 actually starts granting rights (but
please don't encode that in any merge mesa patch before it's official in
the kernel, Dave Airlie _will_ revert it even if it breaks the build) and
that this happens soon.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2014-11-11 15:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-07 15:34 [PATCH] drm/i915: Add the predicate source registers to the register whitelist Neil Roberts
2014-11-07 16:34 ` Volkin, Bradley D
2014-11-07 19:00 ` [PATCH v2] " Neil Roberts
2014-11-11 15:26 ` Daniel Vetter [this message]
2015-01-09 16:41 ` Neil Roberts
2015-01-12 23:00 ` Daniel Vetter
2014-11-07 19:33 ` [PATCH] " Kenneth Graunke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141111152650.GC25711@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=neil@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox