From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Borislav Petkov <bp@alien8.de>
Cc: intel-gfx@lists.freedesktop.org, X86 ML <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
DRI <dri-devel@lists.freedesktop.org>,
Andy Lutomirski <luto@amacapital.net>,
Thomas Gleixner <tglx@linutronix.de>,
Ross Zwisler <ross.zwisler@linux.intel.com>,
H Peter Anvin <h.peter.anvin@intel.com>,
Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH 6/6] x86: Use clwb in drm_clflush_virt_range
Date: Thu, 13 Nov 2014 20:14:11 +0200 [thread overview]
Message-ID: <20141113181411.GU10649@intel.com> (raw)
In-Reply-To: <20141113174734.GF14070@pd.tnic>
On Thu, Nov 13, 2014 at 06:47:34PM +0100, Borislav Petkov wrote:
> On Thu, Nov 13, 2014 at 07:33:54PM +0200, Ville Syrjälä wrote:
> > We use it both ways in i915. So please don't break it.
>
> Haha, we started from Intel with Ross' patch and made a full circle
> back. Maybe you guys should talk about it.
>
> LOL. :-)
Indeed. The problem I see with these patches is that they don't actually
tell what the new instruction does, so a casual glance doesn't really
raise any red flags. Another excuse I can use is that I just got used
to the fact that the x86 hasn't historically bothered separating
invalidate and writeback and just does both. In my previous life on the
dark^Warm side I did actually know the difference :)
But there's plenty of blame to go around to the other side of the fence
too. We should have documented what we expect from these functions.
Currently you just have to know/guess, and that's just not good enough.
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2014-11-13 18:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1415731396-19364-1-git-send-email-ross.zwisler@linux.intel.com>
[not found] ` <1415731396-19364-7-git-send-email-ross.zwisler@linux.intel.com>
[not found] ` <5464220D.6090204@amacapital.net>
[not found] ` <20141113112017.GA14416@pd.tnic>
[not found] ` <CALCETrV2E-LBHLTV6zJ=nfw8ijjV8VZoYAinXdg9ZaOryfqquw@mail.gmail.com>
2014-11-13 17:11 ` [PATCH 6/6] x86: Use clwb in drm_clflush_virt_range Borislav Petkov
2014-11-13 17:33 ` Ville Syrjälä
2014-11-13 17:47 ` Borislav Petkov
2014-11-13 18:14 ` Ville Syrjälä [this message]
2014-11-13 18:43 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141113181411.GU10649@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=bp@alien8.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=h.peter.anvin@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@kernel.org \
--cc=ross.zwisler@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox