From: Daniel Vetter <daniel@ffwll.ch>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org, shuang.he@linux.intel.com
Subject: Re: [PATCH 1/4] drm/i915: preserve SSC if previously set v3
Date: Fri, 14 Nov 2014 10:36:11 +0100 [thread overview]
Message-ID: <20141114093610.GE25711@phenom.ffwll.local> (raw)
In-Reply-To: <87wq6zwkyb.fsf@intel.com>
On Thu, Nov 13, 2014 at 10:42:20AM +0200, Jani Nikula wrote:
> On Thu, 09 Oct 2014, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> > Some machines may have a broken VBT or no VBT at all, but we still want
> > to use SSC there. So check for it and keep it enabled if we see it
> > already on. Based on an earlier fix from Kristian.
> >
> > v2: honor modparam if set too (Daniel)
> > read out at init time and store for panel_use_ssc() use (Jesse)
> > v3: trust BIOS configuration over VBT like we do for DP (Jani)
> >
> > Reported-by: Kristian Høgsberg <hoegsberg@gmail.com>
> > Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
>
> Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Queued for -next, thanks for the patch.
> In the long run I'd like to restrict changing dev_priv->vbt within
> intel_bios.c only, regardless of whether that info comes from VBT or
> what was set by the BIOS. We have a few exceptions here and there now,
> and there's not a good place to plug this one in, really.
Yeah, otoh the entire clock tree handling on earlier pch platforms is a
bit murky overall.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2014-11-14 9:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-09 19:57 [PATCH 1/4] drm/i915: preserve SSC if previously set v3 Jesse Barnes
2014-10-09 19:57 ` [PATCH 2/4] drm/i915: preserve swizzle settings if necessary v4 Jesse Barnes
2014-10-21 14:49 ` Daniel Vetter
2014-10-30 21:25 ` Jesse Barnes
2014-10-09 19:57 ` [PATCH 3/4] drm: add drm_mode_same_size function Jesse Barnes
2014-10-21 14:49 ` Daniel Vetter
2014-10-22 15:40 ` Jesse Barnes
2014-10-09 19:57 ` [PATCH 4/4] drm/i915: use current mode if the size matches the preferred mode Jesse Barnes
2014-10-10 14:44 ` [PATCH 4/4] drm/i915: use current mode if the size shuang.he
2014-10-21 14:53 ` [PATCH 4/4] drm/i915: use current mode if the size matches the preferred mode Daniel Vetter
2014-10-22 15:42 ` Jesse Barnes
2014-10-23 10:23 ` Daniel Vetter
2014-11-13 8:42 ` [PATCH 1/4] drm/i915: preserve SSC if previously set v3 Jani Nikula
2014-11-14 9:36 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141114093610.GE25711@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=shuang.he@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox