From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Paul Subject: Re: [PATCH] drm: Simplify return value handling in drm_crtc.c Date: Fri, 14 Nov 2014 06:50:26 -0500 Message-ID: <20141114115026.GA20877@philcollins> References: <1415789987-17389-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1415789987-17389-1-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: Daniel Vetter , Intel Graphics Development , DRI Development List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBOb3YgMTIsIDIwMTQgYXQgMTE6NTk6NDdBTSArMDEwMCwgRGFuaWVsIFZldHRlciB3 cm90ZToKPiBXaGlsZSBsb29raW5nIHRocm91Z2ggZHJtX2NydGMuYyB0byBkb3VibGUtY2hlY2sg bWFrZSBsb2NraW5nIGNoYW5nZXMKPiBJJ3ZlIG5vdGljZWQgdGhhdCB0aGVyZSdzIGEgZmV3IG90 aGVyIHBsYWNlcyB0aGF0IHdvdWxkIG5vdyBiZW5lZml0Cj4gZnJvbSBzaW1wbGlmaWVkIHJldHVy biB2YWx1ZSBoYW5kbGluZy4KPiAKPiBTbyBsZXQncyBmbGF0dGVuIHRoZSBjb250cm9sIGZsb3cg YW5kIHJlcGxhY2UgYW5kIGFsd2F5cyAwIHJldCB3aXRoIDAKPiB3aGVyZSBwb3NzaWJsZS4KPiAK PiBTaWduZWQtb2ZmLWJ5OiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGludGVsLmNvbT4K ClJldmlld2VkLWJ5OiBTZWFuIFBhdWwgPHNlYW5wYXVsQGNocm9taXVtLm9yZz4KCj4gLS0tCj4g IGRyaXZlcnMvZ3B1L2RybS9kcm1fY3J0Yy5jIHwgMjYgKysrKysrKysrLS0tLS0tLS0tLS0tLS0t LS0KPiAgMSBmaWxlIGNoYW5nZWQsIDkgaW5zZXJ0aW9ucygrKSwgMTcgZGVsZXRpb25zKC0pCj4g Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fY3J0Yy5jIGIvZHJpdmVycy9ncHUv ZHJtL2RybV9jcnRjLmMKPiBpbmRleCAyYmViMjE5ZGYxYmQuLjQ2ZTAwYTI5Y2NlMiAxMDA2NDQK PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2NydGMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9kcm1fY3J0Yy5jCj4gQEAgLTY4Myw3ICs2ODMsNyBAQCBpbnQgZHJtX2NydGNfaW5pdF93aXRo X3BsYW5lcyhzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCBzdHJ1Y3QgZHJtX2NydGMgKmNydGMsCj4g IAlkcm1fbW9kZXNldF9sb2NrX2luaXQoJmNydGMtPm11dGV4KTsKPiAgCXJldCA9IGRybV9tb2Rl X29iamVjdF9nZXQoZGV2LCAmY3J0Yy0+YmFzZSwgRFJNX01PREVfT0JKRUNUX0NSVEMpOwo+ICAJ aWYgKHJldCkKPiAtCQlnb3RvIG91dDsKPiArCQlyZXR1cm4gcmV0Owo+ICAKPiAgCWNydGMtPmJh c2UucHJvcGVydGllcyA9ICZjcnRjLT5wcm9wZXJ0aWVzOwo+ICAKPiBAQCAtNjk3LDkgKzY5Nyw3 IEBAIGludCBkcm1fY3J0Y19pbml0X3dpdGhfcGxhbmVzKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYs IHN0cnVjdCBkcm1fY3J0YyAqY3J0YywKPiAgCWlmIChjdXJzb3IpCj4gIAkJY3Vyc29yLT5wb3Nz aWJsZV9jcnRjcyA9IDEgPDwgZHJtX2NydGNfaW5kZXgoY3J0Yyk7Cj4gIAo+IC0gb3V0Ogo+IC0K PiAtCXJldHVybiByZXQ7Cj4gKwlyZXR1cm4gMDsKPiAgfQo+ICBFWFBPUlRfU1lNQk9MKGRybV9j cnRjX2luaXRfd2l0aF9wbGFuZXMpOwo+ICAKPiBAQCAtMTE1NCw3ICsxMTUyLDcgQEAgaW50IGRy bV91bml2ZXJzYWxfcGxhbmVfaW5pdChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCBzdHJ1Y3QgZHJt X3BsYW5lICpwbGFuZSwKPiAgCj4gIAlyZXQgPSBkcm1fbW9kZV9vYmplY3RfZ2V0KGRldiwgJnBs YW5lLT5iYXNlLCBEUk1fTU9ERV9PQkpFQ1RfUExBTkUpOwo+ICAJaWYgKHJldCkKPiAtCQlnb3Rv IG91dDsKPiArCQlyZXR1cm4gcmV0Owo+ICAKPiAgCWRybV9tb2Rlc2V0X2xvY2tfaW5pdCgmcGxh bmUtPm11dGV4KTsKPiAgCj4gQEAgLTExNjYsOCArMTE2NCw3IEBAIGludCBkcm1fdW5pdmVyc2Fs X3BsYW5lX2luaXQoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgc3RydWN0IGRybV9wbGFuZSAqcGxh bmUsCj4gIAlpZiAoIXBsYW5lLT5mb3JtYXRfdHlwZXMpIHsKPiAgCQlEUk1fREVCVUdfS01TKCJv dXQgb2YgbWVtb3J5IHdoZW4gYWxsb2NhdGluZyBwbGFuZVxuIik7Cj4gIAkJZHJtX21vZGVfb2Jq ZWN0X3B1dChkZXYsICZwbGFuZS0+YmFzZSk7Cj4gLQkJcmV0ID0gLUVOT01FTTsKPiAtCQlnb3Rv IG91dDsKPiArCQlyZXR1cm4gLUVOT01FTTsKPiAgCX0KPiAgCj4gIAltZW1jcHkocGxhbmUtPmZv cm1hdF90eXBlcywgZm9ybWF0cywgZm9ybWF0X2NvdW50ICogc2l6ZW9mKHVpbnQzMl90KSk7Cj4g QEAgLTExODQsOSArMTE4MSw3IEBAIGludCBkcm1fdW5pdmVyc2FsX3BsYW5lX2luaXQoc3RydWN0 IGRybV9kZXZpY2UgKmRldiwgc3RydWN0IGRybV9wbGFuZSAqcGxhbmUsCj4gIAkJCQkgICBkZXYt Pm1vZGVfY29uZmlnLnBsYW5lX3R5cGVfcHJvcGVydHksCj4gIAkJCQkgICBwbGFuZS0+dHlwZSk7 Cj4gIAo+IC0gb3V0Ogo+IC0KPiAtCXJldHVybiByZXQ7Cj4gKwlyZXR1cm4gMDsKPiAgfQo+ICBF WFBPUlRfU1lNQk9MKGRybV91bml2ZXJzYWxfcGxhbmVfaW5pdCk7Cj4gIAo+IEBAIC0xODg3LDcg KzE4ODIsNiBAQCBpbnQgZHJtX21vZGVfZ2V0Y3J0YyhzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ ICB7Cj4gIAlzdHJ1Y3QgZHJtX21vZGVfY3J0YyAqY3J0Y19yZXNwID0gZGF0YTsKPiAgCXN0cnVj dCBkcm1fY3J0YyAqY3J0YzsKPiAtCWludCByZXQgPSAwOwo+ICAKPiAgCWlmICghZHJtX2NvcmVf Y2hlY2tfZmVhdHVyZShkZXYsIERSSVZFUl9NT0RFU0VUKSkKPiAgCQlyZXR1cm4gLUVJTlZBTDsK PiBAQCAtMTkxNSw3ICsxOTA5LDcgQEAgaW50IGRybV9tb2RlX2dldGNydGMoc3RydWN0IGRybV9k ZXZpY2UgKmRldiwKPiAgCX0KPiAgCWRybV9tb2Rlc2V0X3VubG9ja19jcnRjKGNydGMpOwo+ICAK PiAtCXJldHVybiByZXQ7Cj4gKwlyZXR1cm4gMDsKPiAgfQo+ICAKPiAgc3RhdGljIGJvb2wgZHJt X21vZGVfZXhwb3NlX3RvX3VzZXJzcGFjZShjb25zdCBzdHJ1Y3QgZHJtX2Rpc3BsYXlfbW9kZSAq bW9kZSwKPiBAQCAtMjA5Myw3ICsyMDg3LDYgQEAgaW50IGRybV9tb2RlX2dldGVuY29kZXIoc3Ry dWN0IGRybV9kZXZpY2UgKmRldiwgdm9pZCAqZGF0YSwKPiAgewo+ICAJc3RydWN0IGRybV9tb2Rl X2dldF9lbmNvZGVyICplbmNfcmVzcCA9IGRhdGE7Cj4gIAlzdHJ1Y3QgZHJtX2VuY29kZXIgKmVu Y29kZXI7Cj4gLQlpbnQgcmV0ID0gMDsKPiAgCj4gIAlpZiAoIWRybV9jb3JlX2NoZWNrX2ZlYXR1 cmUoZGV2LCBEUklWRVJfTU9ERVNFVCkpCj4gIAkJcmV0dXJuIC1FSU5WQUw7Cj4gQEAgLTIxMTQs NyArMjEwNyw3IEBAIGludCBkcm1fbW9kZV9nZXRlbmNvZGVyKHN0cnVjdCBkcm1fZGV2aWNlICpk ZXYsIHZvaWQgKmRhdGEsCj4gIAllbmNfcmVzcC0+cG9zc2libGVfY3J0Y3MgPSBlbmNvZGVyLT5w b3NzaWJsZV9jcnRjczsKPiAgCWVuY19yZXNwLT5wb3NzaWJsZV9jbG9uZXMgPSBlbmNvZGVyLT5w b3NzaWJsZV9jbG9uZXM7Cj4gIAo+IC0JcmV0dXJuIHJldDsKPiArCXJldHVybiAwOwo+ICB9Cj4g IAo+ICAvKioKPiBAQCAtMjE5Nyw3ICsyMTkwLDYgQEAgaW50IGRybV9tb2RlX2dldHBsYW5lKHN0 cnVjdCBkcm1fZGV2aWNlICpkZXYsIHZvaWQgKmRhdGEsCj4gIAlzdHJ1Y3QgZHJtX21vZGVfZ2V0 X3BsYW5lICpwbGFuZV9yZXNwID0gZGF0YTsKPiAgCXN0cnVjdCBkcm1fcGxhbmUgKnBsYW5lOwo+ ICAJdWludDMyX3QgX191c2VyICpmb3JtYXRfcHRyOwo+IC0JaW50IHJldCA9IDA7Cj4gIAo+ICAJ aWYgKCFkcm1fY29yZV9jaGVja19mZWF0dXJlKGRldiwgRFJJVkVSX01PREVTRVQpKQo+ICAJCXJl dHVybiAtRUlOVkFMOwo+IEBAIC0yMjM3LDcgKzIyMjksNyBAQCBpbnQgZHJtX21vZGVfZ2V0cGxh bmUoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgdm9pZCAqZGF0YSwKPiAgCX0KPiAgCXBsYW5lX3Jl c3AtPmNvdW50X2Zvcm1hdF90eXBlcyA9IHBsYW5lLT5mb3JtYXRfY291bnQ7Cj4gIAo+IC0JcmV0 dXJuIHJldDsKPiArCXJldHVybiAwOwo+ICB9Cj4gIAo+ICAvKgo+IEBAIC0yOTU3LDcgKzI5NDks NyBAQCBpbnQgZHJtX21vZGVfYWRkZmIoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiAgCj4gIAlv ci0+ZmJfaWQgPSByLmZiX2lkOwo+ICAKPiAtCXJldHVybiByZXQ7Cj4gKwlyZXR1cm4gMDsKPiAg fQo+ICAKPiAgc3RhdGljIGludCBmb3JtYXRfY2hlY2soY29uc3Qgc3RydWN0IGRybV9tb2RlX2Zi X2NtZDIgKnIpCj4gLS0gCj4gMi4xLjEKPiAKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwo+IGRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKPiBkcmktZGV2ZWxA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2RyaS1kZXZlbApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2RyaS1kZXZlbAo=