From: Matt Roper <matthew.d.roper@intel.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Propagate invalid setcrtc cloning errors back to userspace
Date: Mon, 17 Nov 2014 11:17:22 -0800 [thread overview]
Message-ID: <20141117191722.GJ4983@intel.com> (raw)
In-Reply-To: <20141117190647.GO25711@phenom.ffwll.local>
On Mon, Nov 17, 2014 at 08:06:47PM +0100, Daniel Vetter wrote:
> On Mon, Nov 17, 2014 at 09:59:28AM -0800, Matt Roper wrote:
> > When invalid cloning configurations were detected during modeset, we
> > never copied the error code into the return value variable, leading us
> > to return 0 (success) to userspace.
> >
> > Testcase: igt/kms_setmode
> > Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
>
> I guess this is a regression from
>
> commit 50f5275698df4490046cc5b4ed2018abb642a803
> Author: Jesse Barnes <jbarnes@virtuousgeek.org>
> Date: Fri Nov 7 13:11:00 2014 -0800
>
> drm/i915: use compute_config in set_config v4
>
> Is this the one we have a bugzilla for already? Jesse?
> -Daniel
Looks like it might be this one:
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=86226
Matt
>
> > ---
> > drivers/gpu/drm/i915/intel_display.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> > index dda97b3..cf57b74 100644
> > --- a/drivers/gpu/drm/i915/intel_display.c
> > +++ b/drivers/gpu/drm/i915/intel_display.c
> > @@ -11477,6 +11477,7 @@ static int intel_crtc_set_config(struct drm_mode_set *set)
> > &prepare_pipes,
> > &disable_pipes);
> > if (IS_ERR(pipe_config)) {
> > + ret = PTR_ERR(pipe_config);
> > goto fail;
> > } else if (pipe_config) {
> > if (to_intel_crtc(set->crtc)->new_config->has_audio !=
> > --
> > 1.8.5.1
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> +41 (0) 79 365 57 48 - http://blog.ffwll.ch
--
Matt Roper
Graphics Software Engineer
IoTG Platform Enabling & Development
Intel Corporation
(916) 356-2795
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2014-11-17 19:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-17 17:59 [PATCH] drm/i915: Propagate invalid setcrtc cloning errors back to userspace Matt Roper
2014-11-17 18:47 ` Ville Syrjälä
2014-11-17 19:06 ` Daniel Vetter
2014-11-17 19:17 ` Matt Roper [this message]
2014-11-17 20:10 ` Jesse Barnes
2014-11-17 20:22 ` Daniel Vetter
2014-11-18 1:19 ` [PATCH] drm/i915: Propagate invalid setcrtc cloning shuang.he
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141117191722.GJ4983@intel.com \
--to=matthew.d.roper@intel.com \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox