From: Daniel Vetter <daniel@ffwll.ch>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Extend pcode mailbox interface
Date: Wed, 19 Nov 2014 14:40:45 +0100 [thread overview]
Message-ID: <20141119134045.GP25711@phenom.ffwll.local> (raw)
In-Reply-To: <20141118192426.GP10649@intel.com>
On Tue, Nov 18, 2014 at 09:24:26PM +0200, Ville Syrjälä wrote:
> On Thu, Nov 13, 2014 at 06:50:10PM -0800, Tom.O'Rourke@intel.com wrote:
> > From: Tom O'Rourke <Tom.O'Rourke@intel.com>
> >
> > In sandybridge_pcode_read and sandybridge_pcode_write,
> > extend the mbox parameter from u8 to u32.
> >
> > On Haswell and Sandybridge, bits 7:0 encode the mailbox
> > command and bits 28:8 are used for address control for
> > specific commands.
> >
> > Based on suggestion from Ville Syrjälä.
> >
> > Signed-off-by: Tom O'Rourke <Tom.O'Rourke@intel.com>
>
> Not sure what we're going to do with this, but the spec does allow
> passing some stuff in the high bits, so
>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Queued for -next, thanks for the patch.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2014-11-19 13:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-06 1:32 [PATCH] drm/i915: Add haswell_pcode_write function Tom.O'Rourke
2014-11-06 8:28 ` Ville Syrjälä
2014-11-06 17:35 ` O'Rourke, Tom
2014-11-06 18:18 ` Ville Syrjälä
2014-11-06 20:21 ` O'Rourke, Tom
2014-11-14 2:50 ` [PATCH] drm/i915: Extend pcode mailbox interface Tom.O'Rourke
2014-11-18 19:24 ` Ville Syrjälä
2014-11-19 13:40 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141119134045.GP25711@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox