From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v4] drm/i915/skl: Implement the skl version of MMIO flips Date: Thu, 20 Nov 2014 16:45:52 +0200 Message-ID: <20141120144552.GX10649@intel.com> References: <1416491315-4031-1-git-send-email-damien.lespiau@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id D39A96F480 for ; Thu, 20 Nov 2014 06:45:55 -0800 (PST) Content-Disposition: inline In-Reply-To: <1416491315-4031-1-git-send-email-damien.lespiau@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Damien Lespiau Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBOb3YgMjAsIDIwMTQgYXQgMDE6NDg6MzVQTSArMDAwMCwgRGFtaWVuIExlc3BpYXUg d3JvdGU6Cj4gQmVjYXVzZSB0aGUgcGxhbmUgcmVnaXN0ZXJzIGFyZSBkaWZmZXJlbnQgaW4gU2t5 bGFrZSB3ZSBuZWVkIHRvIGFkYXB0Cj4gdGhlIE1NSU8gY29kZSBhcyB3ZWxsLgo+IAo+IHYyOiBE b24ndCBpbnRyb2R1Y2UgeWV0IGFub3RoZXIgdmZ1bmMgd2hlbiB0aGUgZGlyZWN0aW9uIGlzIGRv Cj4gY29uc29saWRhdGUgdGhlIHBsYW5lIHVwZGF0ZXMgdG8gdXNlIHRoZSBzYW1lIGNvZGUgcGF0 aCAoRGFuaWVsKQo+IAo+IHYzOgo+ICAgLSBVc2UgZW51bSBwaXBlIGluc3RlYWQgb2YgaW50IChW aWxsZSkKPiAgIC0gQWxzbyB1cGRhdGUgUExBTkVfU1RSSURFIHdoZW4gdGhlIHRpbGluZyBoYXMg Y2hhbmdlZCAoVmlsbGUpCj4gICAtIFB1dCBpbnRlbF9tYXJrX3BhZ2VfZmxpcF9hY3RpdmUoKSBp biB0aGUgc2hhcmVkIGNvZGUgKERhbWllbikKPiAKPiB2NDoKPiAgIC0gUmVtb3ZlIHVudXNlZCB2 YXJpYWJsZQo+IAo+IFNpZ25lZC1vZmYtYnk6IERhbWllbiBMZXNwaWF1IDxkYW1pZW4ubGVzcGlh dUBpbnRlbC5jb20+CgpMb29rcyBPSy4gSSdtIG5vdCBzdXBlciBoYXBweSBhYm91dCBsb29raW5n IGF0IHBsYW5lLT5mYiBoZXJlLCBidXQgdGhlCmNvZGUgYWxyZWFkeSBkaWQgdGhhdC4gQW5kIGl0 IHNob3VsZCB3b3JrIGFzIGxvbmcgYXMgd2UgZG9uJ3QgYWxsb3cKcXVldWluZyBtdWx0aXBsZSBm bGlwcyBhbmQgdGhlIHBsYW5lLT5mYiBnZXRzIHVwZGF0ZSBhZnRlciB0aGUgcGVuZGluZwpmbGlw IHdhaXQuIEJ1dCBhcyB0aGUgY29tbWVudCBub3cgc2F5cyB0aGlzIGlzIGEgdGVtcG9yYXJ5IHNv bHV0aW9uIGFuZApzaG91bGQgaG9wZWZ1bGx5IGdldCBzb3J0ZWQgb3V0IGluIHRoZSBlbmQuCgpU aGUgcGF0Y2ggc2VlbXMgd2hpdGVzcGFjZSBkYW1hZ2VkIHRob3VnaCAobG90cyBvZiBzcGFjZXMg d2hlcmUgdGFicwpzaG91bGQgYmUpLiBXaXRoIHRoYXQgZml4ZWQ6ClJldmlld2VkLWJ5OiBWaWxs ZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgoKPiAtLS0KPiAgZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIHwgNjQgKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKystLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCA1NyBpbnNlcnRpb25zKCspLCA3 IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9kaXNwbGF5LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiBpbmRl eCBjMGFmNGM2Li45YTUyZDdlIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2Rpc3BsYXkuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXku Ywo+IEBAIC05NDM2LDIyICs5NDM2LDUwIEBAIHN0YXRpYyBib29sIHVzZV9tbWlvX2ZsaXAoc3Ry dWN0IGludGVsX2VuZ2luZV9jcyAqcmluZywKPiAgCQlyZXR1cm4gcmluZyAhPSBvYmotPnJpbmc7 Cj4gIH0KPiAgCj4gLXN0YXRpYyB2b2lkIGludGVsX2RvX21taW9fZmxpcChzdHJ1Y3QgaW50ZWxf Y3J0YyAqaW50ZWxfY3J0YykKPiArc3RhdGljIHZvaWQgc2tsX2RvX21taW9fZmxpcChzdHJ1Y3Qg aW50ZWxfY3J0YyAqaW50ZWxfY3J0YykKPiArewo+ICsgICAgICAgc3RydWN0IGRybV9kZXZpY2Ug KmRldiA9IGludGVsX2NydGMtPmJhc2UuZGV2Owo+ICsgICAgICAgc3RydWN0IGRybV9pOTE1X3By aXZhdGUgKmRldl9wcml2ID0gZGV2LT5kZXZfcHJpdmF0ZTsKPiArICAgICAgIHN0cnVjdCBkcm1f ZnJhbWVidWZmZXIgKmZiID0gaW50ZWxfY3J0Yy0+YmFzZS5wcmltYXJ5LT5mYjsKPiArICAgICAg IHN0cnVjdCBpbnRlbF9mcmFtZWJ1ZmZlciAqaW50ZWxfZmIgPSB0b19pbnRlbF9mcmFtZWJ1ZmZl cihmYik7Cj4gKyAgICAgICBzdHJ1Y3QgZHJtX2k5MTVfZ2VtX29iamVjdCAqb2JqID0gaW50ZWxf ZmItPm9iajsKPiArICAgICAgIGNvbnN0IGVudW0gcGlwZSBwaXBlID0gaW50ZWxfY3J0Yy0+cGlw ZTsKPiArICAgICAgIHUzMiBjdGwsIHN0cmlkZTsKPiArCj4gKyAgICAgICBjdGwgPSBJOTE1X1JF QUQoUExBTkVfQ1RMKHBpcGUsIDApKTsKPiArICAgICAgIGN0bCAmPSB+UExBTkVfQ1RMX1RJTEVE X01BU0s7Cj4gKyAgICAgICBpZiAob2JqLT50aWxpbmdfbW9kZSA9PSBJOTE1X1RJTElOR19YKQo+ ICsgICAgICAgICAgICAgICBjdGwgfD0gUExBTkVfQ1RMX1RJTEVEX1g7Cj4gKwo+ICsJLyoKPiAr CSAqIFRoZSBzdHJpZGUgaXMgZWl0aGVyIGV4cHJlc3NlZCBhcyBhIG11bHRpcGxlIG9mIDY0IGJ5 dGVzIGNodW5rcyBmb3IKPiArCSAqIGxpbmVhciBidWZmZXJzIG9yIGluIG51bWJlciBvZiB0aWxl cyBmb3IgdGlsZWQgYnVmZmVycy4KPiArCSAqLwo+ICsgICAgICAgc3RyaWRlID0gZmItPnBpdGNo ZXNbMF0gPj4gNjsKPiArICAgICAgIGlmIChvYmotPnRpbGluZ19tb2RlID09IEk5MTVfVElMSU5H X1gpCj4gKwkJc3RyaWRlID0gZmItPnBpdGNoZXNbMF0gPj4gOTsgLyogWCB0aWxlcyBhcmUgNTEy IGJ5dGVzIHdpZGUgKi8KPiArCj4gKwkvKgo+ICsJICogQm90aCBQTEFORV9DVEwgYW5kIFBMQU5F X1NUUklERSBhcmUgbm90IHVwZGF0ZWQgb24gdmJsYW5rIGJ1dCBvbgo+ICsJICogUExBTkVfU1VS RiB1cGRhdGVzLCB0aGUgdXBkYXRlIGlzIHRoZW4gZ3VhcmFudGVlZCB0byBiZSBhdG9taWMuCj4g KwkgKi8KPiArICAgICAgIEk5MTVfV1JJVEUoUExBTkVfQ1RMKHBpcGUsIDApLCBjdGwpOwo+ICsg ICAgICAgSTkxNV9XUklURShQTEFORV9TVFJJREUocGlwZSwgMCksIHN0cmlkZSk7Cj4gKwo+ICsg ICAgICAgSTkxNV9XUklURShQTEFORV9TVVJGKHBpcGUsIDApLCBpbnRlbF9jcnRjLT51bnBpbl93 b3JrLT5ndHRfb2Zmc2V0KTsKPiArICAgICAgIFBPU1RJTkdfUkVBRChQTEFORV9TVVJGKHBpcGUs IDApKTsKPiArfQo+ICsKPiArc3RhdGljIHZvaWQgaWxrX2RvX21taW9fZmxpcChzdHJ1Y3QgaW50 ZWxfY3J0YyAqaW50ZWxfY3J0YykKPiAgewo+ICAJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IGlu dGVsX2NydGMtPmJhc2UuZGV2Owo+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2 ID0gZGV2LT5kZXZfcHJpdmF0ZTsKPiAgCXN0cnVjdCBpbnRlbF9mcmFtZWJ1ZmZlciAqaW50ZWxf ZmIgPQo+ICAJCXRvX2ludGVsX2ZyYW1lYnVmZmVyKGludGVsX2NydGMtPmJhc2UucHJpbWFyeS0+ ZmIpOwo+ICAJc3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKm9iaiA9IGludGVsX2ZiLT5vYmo7 Cj4gLQlib29sIGF0b21pY191cGRhdGU7Cj4gLQl1MzIgc3RhcnRfdmJsX2NvdW50Owo+ICAJdTMy IGRzcGNudHI7Cj4gIAl1MzIgcmVnOwo+ICAKPiAtCWludGVsX21hcmtfcGFnZV9mbGlwX2FjdGl2 ZShpbnRlbF9jcnRjKTsKPiAtCj4gLQlhdG9taWNfdXBkYXRlID0gaW50ZWxfcGlwZV91cGRhdGVf c3RhcnQoaW50ZWxfY3J0YywgJnN0YXJ0X3ZibF9jb3VudCk7Cj4gLQo+ICAJcmVnID0gRFNQQ05U UihpbnRlbF9jcnRjLT5wbGFuZSk7Cj4gIAlkc3BjbnRyID0gSTkxNV9SRUFEKHJlZyk7Cj4gIAo+ IEBAIC05NDY2LDYgKzk0OTQsMjggQEAgc3RhdGljIHZvaWQgaW50ZWxfZG9fbW1pb19mbGlwKHN0 cnVjdCBpbnRlbF9jcnRjICppbnRlbF9jcnRjKQo+ICAJCSAgIGludGVsX2NydGMtPnVucGluX3dv cmstPmd0dF9vZmZzZXQpOwo+ICAJUE9TVElOR19SRUFEKERTUFNVUkYoaW50ZWxfY3J0Yy0+cGxh bmUpKTsKPiAgCj4gK30KPiArCj4gKy8qCj4gKyAqIFhYWDogVGhpcyBpcyB0aGUgdGVtcG9yYXJ5 IHdheSB0byB1cGRhdGUgdGhlIHBsYW5lIHJlZ2lzdGVycyB1bnRpbCB3ZSBnZXQKPiArICogYXJv dW5kIHRvIHVzaW5nIHRoZSB1c3VhbCBwbGFuZSB1cGRhdGUgZnVuY3Rpb25zIGZvciBNTUlPIGZs aXBzCj4gKyAqLwo+ICtzdGF0aWMgdm9pZCBpbnRlbF9kb19tbWlvX2ZsaXAoc3RydWN0IGludGVs X2NydGMgKmludGVsX2NydGMpCj4gK3sKPiArCXN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBpbnRl bF9jcnRjLT5iYXNlLmRldjsKPiArCWJvb2wgYXRvbWljX3VwZGF0ZTsKPiArCXUzMiBzdGFydF92 YmxfY291bnQ7Cj4gKwo+ICsJaW50ZWxfbWFya19wYWdlX2ZsaXBfYWN0aXZlKGludGVsX2NydGMp Owo+ICsKPiArCWF0b21pY191cGRhdGUgPSBpbnRlbF9waXBlX3VwZGF0ZV9zdGFydChpbnRlbF9j cnRjLCAmc3RhcnRfdmJsX2NvdW50KTsKPiArCj4gKwlpZiAoSU5URUxfSU5GTyhkZXYpLT5nZW4g Pj0gOSkKPiArCQlza2xfZG9fbW1pb19mbGlwKGludGVsX2NydGMpOwo+ICsJZWxzZQo+ICsJCS8q IHVzZV9tbWlvX2ZsaXAoKSByZXRyaWN0cyBNTUlPIGZsaXBzIHRvIGlsaysgKi8KPiArCQlpbGtf ZG9fbW1pb19mbGlwKGludGVsX2NydGMpOwo+ICsKPiAgCWlmIChhdG9taWNfdXBkYXRlKQo+ICAJ CWludGVsX3BpcGVfdXBkYXRlX2VuZChpbnRlbF9jcnRjLCBzdGFydF92YmxfY291bnQpOwo+ICB9 Cj4gLS0gCj4gMS44LjMuMQo+IAo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+IEludGVsLWdmeEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKPiBodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vaW50ZWwtZ2Z4CgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsIE9UQwpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBs aXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=