Re: [PATCH 2/2] drm/i915: vlv: increase timeout when setting idle GPU freq

Ville Syrjälä
2014-11-20T14:52:31Z

On Wed, Nov 19, 2014 at 04:25:38PM +0200, Imre Deak wrote:
> I saw punit timeouts in vlv_set_rps_idle() while running various
> subtests of pm_rpm. Increasing the timeout to 100ms got rid of the
> issue.
>
> Testcase: igt/pm_rpm
> Reference: https://bugs.freedesktop.org/show_bug.cgi?id=82939
> Signed-off-by: Imre Deak <imre.deak@intel.com>
> ---
> drivers/gpu/drm/i915/intel_pm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index 5cc0ebc..3a58797 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -4451,7 +4451,7 @@ static void vlv_set_rps_idle(struct drm_i915_private *dev_priv)
> dev_priv->rps.min_freq_softlimit);
>
> if (wait_for(((vlv_punit_read(dev_priv, PUNIT_REG_GPU_FREQ_STS))
> - & GENFREQSTATUS) == 0, 5))
> + & GENFREQSTATUS) == 0, 100))

If it takes a while then it takes a while. Nothing we can do about
that.

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> DRM_ERROR("timed out waiting for Punit\n");
>
> vlv_force_gfx_clock(dev_priv, false);
> --
> 1.8.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--
Ville Syrjälä
Intel OTC