From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH] drm/i915: Don't clobber crtc->new_config when nothing changes Date: Fri, 21 Nov 2014 11:57:51 -0800 Message-ID: <20141121115751.7d067df4@jbarnes-hsw> References: <1416596436-11708-1-git-send-email-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from gproxy1-pub.mail.unifiedlayer.com (gproxy1-pub.mail.unifiedlayer.com [69.89.25.95]) by gabe.freedesktop.org (Postfix) with SMTP id 78B056F200 for ; Fri, 21 Nov 2014 11:56:58 -0800 (PST) In-Reply-To: <1416596436-11708-1-git-send-email-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: ville.syrjala@linux.intel.com Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCAyMSBOb3YgMjAxNCAyMTowMDozNiArMDIwMAp2aWxsZS5zeXJqYWxhQGxpbnV4Lmlu dGVsLmNvbSB3cm90ZToKCj4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxp bnV4LmludGVsLmNvbT4KPiAKPiBXaGVuIGRvaW5nIGEgbm9wIG1vZGVzZXQgd2UgY3VycmVudGx5 IGxlYXZlIGNydGMtPm5ld19jb25maWcgcG9pbnQgYXQKPiB0aGUgYWxyZWFkeSBmcmVlZCB0ZW1w b3JhcnkgcGlwZV9jb25maWcuIFRoYXQgd2lsbCBhbmdlciB0aGUgc2FuaXR5Cj4gY2hlY2tzIGlu IGludGVsX21vZGVzZXRfdXBkYXRlX3N0YXRlKCkgd2hlbiB0aGUgbm9wIG1vZGVzZXQgZ2V0cwo+ IGZvbGxvd2VkIGJ5IGEgR1BVIHJlc2V0IG9uIGdlbjMvNCB3aGVyZSB0aGUgZGlzcGxheSBibG9j ayBnZXRzIGZ1bGx5Cj4gcmVpbml0aWFsaXplZCBkdXJpbmcgdGhlIHJlc2V0Lgo+IAo+IFNvIGxl YXZlIGNydGMtPm5ld19jb25maWcgYWxvbmUgdW50aWwgd2Uga25vdyBhIG1vZGVzZXQgaXMgYWN0 dWFsbHkKPiByZXF1aXJlZC4KPiAKPiBDYzogSmVzc2UgQmFybmVzIDxqYmFybmVzQHZpcnR1b3Vz Z2Vlay5vcmc+Cj4gU2lnbmVkLW9mZi1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxh QGxpbnV4LmludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlz cGxheS5jIHwgOCArKysrKy0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgNSBpbnNlcnRpb25zKCspLCAz IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9kaXNwbGF5LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiBpbmRl eCA4NTM2OTdmLi4zMjE4NDU1IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2Rpc3BsYXkuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXku Ywo+IEBAIC0xMDkwNyw3ICsxMDkwNyw2IEBAIGludGVsX21vZGVzZXRfY29tcHV0ZV9jb25maWco c3RydWN0IGRybV9jcnRjICpjcnRjLAo+ICAJfQo+ICAJaW50ZWxfZHVtcF9waXBlX2NvbmZpZyh0 b19pbnRlbF9jcnRjKGNydGMpLCBwaXBlX2NvbmZpZywKPiAgCQkJICAgICAgICJbbW9kZXNldF0i KTsKPiAtCXRvX2ludGVsX2NydGMoY3J0YyktPm5ld19jb25maWcgPSBwaXBlX2NvbmZpZzsKPiAg Cj4gIG91dDoKPiAgCXJldHVybiBwaXBlX2NvbmZpZzsKPiBAQCAtMTA5MzMsNiArMTA5MzIsOSBA QCBzdGF0aWMgaW50IF9faW50ZWxfc2V0X21vZGUoc3RydWN0IGRybV9jcnRjICpjcnRjLAo+ICAK PiAgCSpzYXZlZF9tb2RlID0gY3J0Yy0+bW9kZTsKPiAgCj4gKwlpZiAobW9kZXNldF9waXBlcykK PiArCQl0b19pbnRlbF9jcnRjKGNydGMpLT5uZXdfY29uZmlnID0gcGlwZV9jb25maWc7Cj4gKwo+ ICAJLyoKPiAgCSAqIFNlZSBpZiB0aGUgY29uZmlnIHJlcXVpcmVzIGFueSBhZGRpdGlvbmFsIHBy ZXBhcmF0aW9uLCBlLmcuCj4gIAkgKiB0byBhZGp1c3QgZ2xvYmFsIHN0YXRlIHdpdGggcGlwZXMg b2ZmLiAgV2UgbmVlZCB0byBkbyB0aGlzCj4gQEAgLTExNDY2LDEyICsxMTQ2OCwxMiBAQCBzdGF0 aWMgaW50IGludGVsX2NydGNfc2V0X2NvbmZpZyhzdHJ1Y3QgZHJtX21vZGVfc2V0ICpzZXQpCj4g IAkJcmV0ID0gUFRSX0VSUihwaXBlX2NvbmZpZyk7Cj4gIAkJZ290byBmYWlsOwo+ICAJfSBlbHNl IGlmIChwaXBlX2NvbmZpZykgewo+IC0JCWlmICh0b19pbnRlbF9jcnRjKHNldC0+Y3J0YyktPm5l d19jb25maWctPmhhc19hdWRpbyAhPQo+ICsJCWlmIChwaXBlX2NvbmZpZy0+aGFzX2F1ZGlvICE9 Cj4gIAkJICAgIHRvX2ludGVsX2NydGMoc2V0LT5jcnRjKS0+Y29uZmlnLmhhc19hdWRpbykKPiAg CQkJY29uZmlnLT5tb2RlX2NoYW5nZWQgPSB0cnVlOwo+ICAKPiAgCQkvKiBGb3JjZSBtb2RlIHNl dHMgZm9yIGFueSBpbmZvZnJhbWUgc3R1ZmYgKi8KPiAtCQlpZiAodG9faW50ZWxfY3J0YyhzZXQt PmNydGMpLT5uZXdfY29uZmlnLT5oYXNfaW5mb2ZyYW1lIHx8Cj4gKwkJaWYgKHBpcGVfY29uZmln LT5oYXNfaW5mb2ZyYW1lIHx8Cj4gIAkJICAgIHRvX2ludGVsX2NydGMoc2V0LT5jcnRjKS0+Y29u ZmlnLmhhc19pbmZvZnJhbWUpCj4gIAkJCWNvbmZpZy0+bW9kZV9jaGFuZ2VkID0gdHJ1ZTsKPiAg CX0KClllYWggbG9va3MgZmluZS4KClJldmlld2VkLWJ5OiBKZXNzZSBCYXJuZXMgPGpiYXJuZXNA dmlydHVvdXNnZWVrLm9yZz4KClRoYW5rcywKLS0gCkplc3NlIEJhcm5lcywgSW50ZWwgT3BlbiBT b3VyY2UgVGVjaG5vbG9neSBDZW50ZXIKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9pbnRlbC1nZngK