From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v4 7/7] drm/i915: Tidy up execbuffer command parsing code Date: Mon, 24 Nov 2014 10:20:19 +0100 Message-ID: <20141124092018.GH25711@phenom.ffwll.local> References: <1415398927-16572-1-git-send-email-bradley.d.volkin@intel.com> <1415398927-16572-8-git-send-email-bradley.d.volkin@intel.com> <20141112093729.GJ8220@nuc-i3427.alporthouse.com> <546FE43E.7090600@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wg0-f46.google.com (mail-wg0-f46.google.com [74.125.82.46]) by gabe.freedesktop.org (Postfix) with ESMTP id 00F236EBFA for ; Mon, 24 Nov 2014 01:19:54 -0800 (PST) Received: by mail-wg0-f46.google.com with SMTP id x12so11715076wgg.33 for ; Mon, 24 Nov 2014 01:19:53 -0800 (PST) Content-Disposition: inline In-Reply-To: <546FE43E.7090600@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Michael H. Nguyen" Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBOb3YgMjEsIDIwMTQgYXQgMDU6MTc6NTBQTSAtMDgwMCwgTWljaGFlbCBILiBOZ3V5 ZW4gd3JvdGU6Cj4gSGkgQ2hyaXMsCj4gCj4gPj4KPiA+PitzdGF0aWMgc3RydWN0IGRybV9pOTE1 X2dlbV9vYmplY3QqCj4gPj4raTkxNV9nZW1fZXhlY2J1ZmZlcl9wYXJzZShzdHJ1Y3QgaW50ZWxf ZW5naW5lX2NzICpyaW5nLAo+ID4+KwkJCSAgc3RydWN0IGRybV9pOTE1X2dlbV9leGVjX29iamVj dDIgKnNoYWRvd19leGVjX2VudHJ5LAo+ID4+KwkJCSAgc3RydWN0IGViX3ZtYXMgKmViLAo+ID4+ KwkJCSAgc3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKmJhdGNoX29iaiwKPiA+PisJCQkgIHUz MiBiYXRjaF9zdGFydF9vZmZzZXQsCj4gPj4rCQkJICB1MzIgYmF0Y2hfbGVuLAo+ID4+KwkJCSAg Ym9vbCBpc19tYXN0ZXIsCj4gPj4rCQkJICB1MzIgKmZsYWdzKQo+ID4+K3sKPiA+PisJc3RydWN0 IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShiYXRjaF9vYmotPmJhc2UuZGV2 KTsKPiA+PisJc3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKnNoYWRvd19iYXRjaF9vYmo7Cj4g Pj4rCWludCByZXQ7Cj4gPj4rCj4gPj4rCXNoYWRvd19iYXRjaF9vYmogPSBpOTE1X2dlbV9iYXRj aF9wb29sX2dldCgmZGV2X3ByaXYtPm1tLmJhdGNoX3Bvb2wsCj4gPj4rCQkJCQkJICAgYmF0Y2hf b2JqLT5iYXNlLnNpemUpOwo+ID4+KwlpZiAoSVNfRVJSKHNoYWRvd19iYXRjaF9vYmopKQo+ID4+ KwkJcmV0dXJuIHNoYWRvd19iYXRjaF9vYmo7Cj4gPj4rCj4gPj4rCXNoYWRvd19iYXRjaF9vYmot Pm1hZHYgPSBJOTE1X01BRFZfV0lMTE5FRUQ7Cj4gPj4rCj4gPj4rCXJldCA9IGk5MTVfZ2VtX29i al9nZ3R0X3BpbihzaGFkb3dfYmF0Y2hfb2JqLCA0MDk2LCAwKTsKPiA+PisJaWYgKHJldCkKPiA+ PisJCWdvdG8gZXJyOwo+ID4KPiA+UGFyZG9uPyBUaGlzIGZlZWxzIGFuIGltcGxlbWVudGF0aW9u IGlzc3VlIG9mIGk5MTVfcGFyc2VfY21kcygpIGFuZCBzaG91bGQKPiA+YmUgcmVzb2x2ZWQgdGhl cmUuIFByZXN1bWFibHkgeW91IGFyZSBub3QgYWN0dWFsbHkgcmVhZGluZyBiYWNrIHRocm91Z2gK PiA+dGhlIEdUVD8gVGhhdCB3b3VsZCBiZSBpbnNhbmUuLi4KPiA+Cj4gPj4rCXJldCA9IGk5MTVf cGFyc2VfY21kcyhyaW5nLAo+ID4+KwkJCSAgICAgIGJhdGNoX29iaiwKPiA+PisJCQkgICAgICBz aGFkb3dfYmF0Y2hfb2JqLAo+ID4+KwkJCSAgICAgIGJhdGNoX3N0YXJ0X29mZnNldCwKPiA+PisJ CQkgICAgICBiYXRjaF9sZW4sCj4gPj4rCQkJICAgICAgaXNfbWFzdGVyKTsKPiA+PisJaTkxNV9n ZW1fb2JqZWN0X2dndHRfdW5waW4oc2hhZG93X2JhdGNoX29iaik7Cj4gPgo+ID5ZZXQgcGluK3Vu cGluIGFyb3VuZCB0aGUgcGFyc2VyIHNlZW1zIHRvIHNlcnZlIG5vIG90aGVyIHB1cnBvc2UuCj4g QXJlIHlvdSBzdWdnZXN0aW5nIHRvIHJlbW92ZSB0aGUgcGluL3VucGluIGNhbGxzPyBJZiBzbywg aXNuJ3QgcGlubmluZwo+IG5lZWRlZCB0byBlbnN1cmUgdGhlIGJhY2tpbmcgc3RvcmUgcGFnZXMg YXJlIGF2YWlsYWJsZSBpbiB2bWFwX2JhdGNoKCk/IGkuZS4KPiBvYmotPnBhZ2VzLT5zZ2wgaXMg cG9wdWxhdGVkIHcvIHBoeXNpY2FsIHBhZ2VzLgo+IAo+IE9yLCBhcmUgeW91IHN1Z2dlc3Rpbmcg dG8gbW92ZSB0aGUgcGluL3VucGluIGNhbGxzIGluc2lkZSBpOTE1X3BhcnNlX2NtZHMoKQo+ID8K ClllYWggcGxlYXNlIHB1c2ggdGhlbSBkb3duIGludG8gdGhlIGNtZCBwYXJzZXIgYXJvdW5kIHRo ZSBwYXJ0IHRoYXQKY29waWVzL2NoZWNrcyB0aGUgc2hhZG93IGJhdGNoLiBJZiB3ZSBldmVyIGNo YW5nZSB0aGUgd2F5IHdlIGRvIHRoYXQKY29weS9wYXJzaW5nIChsaWtlbHkgZHVlIHRvIHBlcmZv cm1hbmNlIGlzc3VlcyBvbiB2bHYpIHRoZW4gd2UgYWxzbyBtaWdodApuZWVkIHRvIGNoYW5nZSB0 aGUgdHlwZSBvZiBwaW5uaW5nLiBTbyBiZXR0ZXIgdG8ga2VlcCB0aGluZ3MgdG9nZXRoZXIuCi1E YW5pZWwKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0 aW9uCis0MSAoMCkgNzkgMzY1IDU3IDQ4IC0gaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcg bGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK