From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 5/5] drm/i915: Flatten engine init control flow Date: Mon, 1 Dec 2014 17:34:01 +0100 Message-ID: <20141201163401.GA32117@phenom.ffwll.local> References: <1416439988-10979-1-git-send-email-daniel.vetter@ffwll.ch> <1416439988-10979-5-git-send-email-daniel.vetter@ffwll.ch> <20141120081027.GJ20532@nuc-i3427.alporthouse.com> <20141120091916.GA25711@phenom.ffwll.local> <547C9323.3090506@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wg0-f53.google.com (mail-wg0-f53.google.com [74.125.82.53]) by gabe.freedesktop.org (Postfix) with ESMTP id AA5766E5E0 for ; Mon, 1 Dec 2014 08:33:34 -0800 (PST) Received: by mail-wg0-f53.google.com with SMTP id l18so14638390wgh.40 for ; Mon, 01 Dec 2014 08:33:34 -0800 (PST) Content-Disposition: inline In-Reply-To: <547C9323.3090506@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Dave Gordon Cc: Daniel Vetter , Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBEZWMgMDEsIDIwMTQgYXQgMDQ6MTE6MTVQTSArMDAwMCwgRGF2ZSBHb3Jkb24gd3Jv dGU6Cj4gT24gMjAvMTEvMTQgMDk6MTksIERhbmllbCBWZXR0ZXIgd3JvdGU6Cj4gPiBPbiBUaHUs IE5vdiAyMCwgMjAxNCBhdCAwODoxMDoyN0FNICswMDAwLCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4g Pj4gT24gVGh1LCBOb3YgMjAsIDIwMTQgYXQgMTI6MzM6MDhBTSArMDEwMCwgRGFuaWVsIFZldHRl ciB3cm90ZToKPiA+Pj4gTm93IHRoYXQgc2FuaXR5IHByZXZhaWxzIGFuZCB3ZSBoYXZlIHRoZSBj bGVhbiBzcGxpdCBiZXR3ZWVuIHNvZnR3YXJlCj4gPj4+IGluaXQgYW5kIHN0YXJ0aW5nIHRoZSBl bmdpbmVzIHdlIGNhbiBkcm9wIGFsbCB0aGUgImhhdmUgd2UgYWxsb2NhdGUKPiA+Pj4gdGhpcyBz dHJ1Y3QgYWxyZWFkeT8iIG5vbnNlbnNlLgo+ID4+Cj4gPj4gQWN0dWFsbHksIEkgd2FzIGhvcGlu ZyBmb3Igc29tZXRoaW5nIGNvbXBsZXRlbHkgZGlmZmVyZW50IHdoZW4geW91IHNhZAo+ID4+IGZs YXR0ZW5pbmcgdGhlIGluaXQuLi4KPiA+IAo+ID4gSSBwcmVzdW1lIHlvdSd2ZSBob3BlZCBmb3Ig bW9yZSA7LSkgRXNzZW50aWFsbHkgdGhpcyBpcyBqdXN0IHRoZSBsZWdhY3kKPiA+IHJpbmdidWZm ZXIgYmx1ZXByaW50LCBhcHBseWluZyB0byBleGVjbGlzdCBsZWZ0IGFzIGFuIGV4ZXJjaXNlIGZv ciB0aGUKPiA+IHJlYWRlci4gQW5kIGl0J3MganVzdCBhIHZlcnkgc21hbGwgcGF0Y2guCj4gPiAK PiA+PiBDb21wYXJlIHdpdGgKPiA+PiBodHRwOi8vY2dpdC5mcmVlZGVza3RvcC5vcmcvfmlja2xl L2xpbnV4LTIuNi90cmVlL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuYyNu MTk4Mwo+ID4+Cj4gPj4gVGhlcmUgaXMgYSBsb3Qgb2YgZHVwbGljYXRlZCBjb2RlIGluIHRoZSBy aW5nYnVmZmVyIHNldHVwLCBhbmQgdGhlIGNvZGUKPiA+PiBtb3ZlbWVudCBoZXJlIHdhbnRzIHRv IGJlIHNwbGl0IGRpZmZlcmVudGx5IHNvIHRoYXQgdGhlIHNlcXVlbmNlIGlzCj4gPj4gaWRlbnRp Y2FsIHRvIGV4ZWNsaXN0cy4gKFRoZSBvbmx5IGRpZmZlcmVuY2UgaXMgdGhhdCB3ZSBvbmx5IHVz ZSBvbmUKPiA+PiByaW5nIHdpdGggbGVnYWN5LCByYXRoZXIgdGhhbiBvbmUgcmluZyBpbiBlYWNo IGNvbnRleHQgW3Blci1lbmdpbmVdLikKPiA+PiBNYWtpbmcgc3VyZSB0aGUgbG9naWMgaXMgZm9v bHByb29mIGZvciBib3RoIGlzIGVzc3NlbnRpYWwuCj4gPiAKPiA+IEltbyB3ZSBmaXJzdCBuZWVk IHRvIGJlYXQgZXhlY2xpc3QgaW50byBzaGFwZSAod2l0aCBzbWFsbCBwYXRjaGVzLCBub3QgYnkK PiA+IHJld3JpdGluZyBpdCBhbGwpLiBPbmNlIHN0dWZmIHNldHRsZXMgd2UgY2FuIHRha2UgYW5v dGhlciBsb29rIGF0IHdoZXRoZXIKPiA+IHVuaWZpY2F0aW9uIG1ha2VzIHNlbnNlLCBidXQgZm9y IG5vdyBJIHdhbnQgYSBiaWcgcGllY2Ugb2YgaW5zdWxhdGlvbgo+ID4gYmV0d2VlbiBleGVjbGlz dCBhbmQgc3R1ZmYgd2UgYWN0dWFsbHkgZGVwZW5kIG9uLiBPciBhdCBsZWFzdCBzdHVmZiBEYXZl Cj4gPiBtaWdodCByaXAgbXkgaGVhZCBvZmYgb3Zlci4KPiA+IAo+ID4gU28gZm9yIG5vdyBJIHN0 aWxsIHdhbnQgdG8gZW1icmFjZSB0aGUgZHVwbGljYXRpb24uCj4gPiAtRGFuaWVsCj4gCj4gQXMg YSBtYXR0ZXIgb2YgcG9saWN5OiB3aGlsZSB3ZSBoYXZlIHRoZSBkdXBsaWNhdGlvbiBhbmQgdGhl IHNwbGl0Cj4gYmV0d2VlbiBsZWdhY3kgcmluZ2J1ZmZlciBhbmQgbHJjIHZlcnNpb25zLCBzaG91 bGQgZGV2ZWxvcGVycyB0cnkgdG8KPiBzdWJtaXQgY29ycmVzcG9uZGluZyBjaGFuZ2VzIHRvIGJv dGggcGF0aHMgdG9nZXRoZXIgKGUuZy4gaW4gdGhlIHNhbWUKPiBwYXRjaHNldCkuIE9yIGlzIGl0 IE9LIHRvIHN1Ym1pdCBpbXByb3ZlbWVudHMgb25seSB0byBvbmUgb2YgdGhlIHR3bwo+IHBhdGhz LCBjYXVzaW5nIHRoZW0gdG8gZGl2ZXJnZSBhbmQgaGVuY2UgcG9zc2libHkgbWFraW5nIGRlZHVw bGljYXRpb24KPiBtb3JlIGRpZmZpY3VsdD8KClllYWggaW4gdGhpcyBjYXNlIEkndmUgZmlndXJl ZCBJJ2xsIGNhdXNlIG1vcmUgdHJvdWJsZSB0aGFuIGJlbmVmaXQgd2hlbiBJCnRyYW1wbGUgYWxs IG92ZXIgaW50ZWxfbHJjLmMuIEFsc28sIEkgZG9uJ3QgaGF2ZSBhIG1hY2hpbmUgZm9yIHRlc3Rp bmcKZXhlY2xpc3QgOy0pCj4gCj4gQW55d2F5LCB0aGlzIGNoYW5nZSBsb29rcyBPSyBpbiBpdHNl bGYsIHNvIHN1YmplY3QgdG8gdGhlICJleGVyY2lzZSBmb3IKPiB0aGUgcmVhZGVyIiBhcHByb2Fj aCBiZWluZyBhY2NlcHRhYmxlIChvbiB3aGljaCBwb2ludCBJIGRlZmVyIHRvIHlvdXIKPiBhbmQg b3RoZXJzIGp1ZGdlbWVudCksIHRoZW46Cj4gCj4gUmV2aWV3ZWQtYnk6IERhdmUgR29yZG9uIDxk YXZpZC5zLmdvcmRvbkBpbnRlbC5jb20+CgpRdWV1ZWQgZm9yIC1uZXh0LCB0aGFua3MgZm9yIHRo ZSByZXZpZXcuCi1EYW5pZWwKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIElu dGVsIENvcnBvcmF0aW9uCis0MSAoMCkgNzkgMzY1IDU3IDQ4IC0gaHR0cDovL2Jsb2cuZmZ3bGwu Y2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwt Z2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK