From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>,
ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2] drm/i915: Reject modeset when the same digital port is used more than once
Date: Tue, 2 Dec 2014 13:55:29 +0100 [thread overview]
Message-ID: <20141202125529.GP32117@phenom.ffwll.local> (raw)
In-Reply-To: <20141202121728.GF18921@nuc-i3427.alporthouse.com>
On Tue, Dec 02, 2014 at 12:17:28PM +0000, Chris Wilson wrote:
> On Tue, Dec 02, 2014 at 02:10:46PM +0200, ville.syrjala@linux.intel.com wrote:
> > + if (!check_digital_port_conflicts(dev)) {
>
> Being picky:
>
> if not check digital port for conflicts, report error.
>
> It reads backwards. Perhaps
>
> if (conflicting_digital_port_config(dev)) return -EINVAL;
>
> > + DRM_DEBUG_KMS("rejecting conflicting digital port configuration\n");
> > + return ERR_PTR(-EINVAL);
> > + }
>
> Regarding getting more information back to the user about the error
> message, we could with have a connector/crtc property, a procfs file or
> an ioctl to grab a string describing the last error. A LastError
> property blob might be the most convenient. Though I am not sure how
> outlandish this idea is.
It's an unsolved problem since right now we don't tell anyone ever why
something doesn't work. The current solution is the check-only mode of
atomic where you can quickly go through a bunch of options and then pick
the most suitable using heuristics (either user picking what he likes or
in the code).
Queued for -next, thanks for the patch.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2014-12-02 12:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-19 14:19 [PATCH] drm/i915: Reject modeset when the same digital port is used more than once ville.syrjala
2014-05-19 14:29 ` Daniel Vetter
2014-05-19 14:45 ` Ville Syrjälä
2014-10-28 13:20 ` Paulo Zanoni
2014-11-03 10:29 ` Daniel Vetter
2014-11-04 12:50 ` Paulo Zanoni
2014-11-05 9:05 ` Daniel Vetter
2014-12-02 12:10 ` [PATCH v2] " ville.syrjala
2014-12-02 12:17 ` Chris Wilson
2014-12-02 12:42 ` Ville Syrjälä
2014-12-02 12:55 ` Daniel Vetter [this message]
2014-12-03 0:44 ` shuang.he
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141202125529.GP32117@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox