public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>,
	Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
	Intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/3] drm/i915: Stop putting GGTT VMA at the head of the list
Date: Thu, 4 Dec 2014 11:54:29 +0100	[thread overview]
Message-ID: <20141204105429.GL32117@phenom.ffwll.local> (raw)
In-Reply-To: <20141204094811.GG25773@nuc-i3427.alporthouse.com>

On Thu, Dec 04, 2014 at 09:48:11AM +0000, Chris Wilson wrote:
> On Wed, Dec 03, 2014 at 02:59:24PM +0000, Tvrtko Ursulin wrote:
> > From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> > 
> > Multiple GGTT VMAs per object will be introduced in the near future which will
> > make it impossible to guarantee normal GGTT view is at the head of the list.
> > 
> > Purpose of this patch is to break this assumption straight away so any
> > potential hidden assumptions in the code base can be bisected to this
> > simple patch.
> 
> No, please don't. The rationale for putting ggtt first is because it
> puts the one vma that every object is likely to use at the front, and
> makes it also the first in the list for debugging.

With hindsight I think this was just premature optimization (and way too
many obj->vma lookups to boot). Imo we should just fix the remaining
spurious obj->vma lookups we have and if there's still a problem then we
need to have actual benchmark data or profiles to support this trick.

Hence I pulled this patch in, thanks.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2014-12-04 10:53 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-03 14:59 [PATCH 0/3] Multiple GGTT views Tvrtko Ursulin
2014-12-03 14:59 ` [PATCH 1/3] drm/i915: Stop putting GGTT VMA at the head of the list Tvrtko Ursulin
2014-12-04  9:48   ` Chris Wilson
2014-12-04 10:02     ` Tvrtko Ursulin
2014-12-04 10:17       ` Chris Wilson
2014-12-04 10:30         ` Tvrtko Ursulin
2014-12-04 10:39           ` Chris Wilson
2014-12-04 10:48             ` Tvrtko Ursulin
2014-12-04 10:54     ` Daniel Vetter [this message]
2014-12-03 14:59 ` [PATCH 2/3] drm/i915: Infrastructure for supporting different GGTT views per object Tvrtko Ursulin
2014-12-04  9:53   ` Chris Wilson
2014-12-04 10:19     ` Tvrtko Ursulin
2014-12-04 10:26       ` Chris Wilson
2014-12-04 10:59         ` Daniel Vetter
2014-12-04 12:17           ` Tvrtko Ursulin
2014-12-04 12:27             ` Chris Wilson
2014-12-04 13:01             ` Daniel Vetter
2014-12-03 14:59 ` [PATCH 3/3] drm/i915: Documentation for multiple GGTT views Tvrtko Ursulin
2014-12-04  7:12   ` shuang.he
2014-12-05 12:11 ` [PATCH v2 0/2] Multiple " Tvrtko Ursulin
2014-12-05 12:11   ` [PATCH 1/2] drm/i915: Infrastructure for supporting different GGTT views per object Tvrtko Ursulin
2014-12-05 14:25     ` Daniel Vetter
2014-12-09 15:23     ` Michel Thierry
2014-12-10  9:16       ` Daniel Vetter
2014-12-10 10:17         ` Tvrtko Ursulin
2014-12-05 12:11   ` [PATCH 2/2] drm/i915: Documentation for multiple GGTT views Tvrtko Ursulin
2014-12-09 15:41     ` Michel Thierry
2014-12-10 17:27 ` [PATCH v3 0/2] Multiple " Tvrtko Ursulin
2014-12-10 17:27   ` [PATCH 1/2] drm/i915: Infrastructure for supporting different GGTT views per object Tvrtko Ursulin
2014-12-11 10:18     ` Michel Thierry
2014-12-15 10:24     ` Daniel Vetter
2014-12-15 11:23       ` Tvrtko Ursulin
2014-12-10 17:27   ` [PATCH 2/2] drm/i915: Documentation for multiple GGTT views Tvrtko Ursulin
2014-12-11  3:41     ` shuang.he
2014-12-11 10:19     ` Michel Thierry
2014-12-15  8:30       ` Daniel Vetter
2014-12-15 10:01         ` Michel Thierry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141204105429.GL32117@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=Intel-gfx@lists.freedesktop.org \
    --cc=chris@chris-wilson.co.uk \
    --cc=tvrtko.ursulin@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox