From: Daniel Vetter <daniel@ffwll.ch>
To: Dave Gordon <david.s.gordon@intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH] drm/i915: Move golden context init into ->init_context
Date: Mon, 8 Dec 2014 15:19:23 +0100 [thread overview]
Message-ID: <20141208141923.GS20350@phenom.ffwll.local> (raw)
In-Reply-To: <5485ACC5.3010501@intel.com>
On Mon, Dec 08, 2014 at 01:51:01PM +0000, Dave Gordon wrote:
> On 02/12/14 15:19, Daniel Vetter wrote:
> > Similar to a patch from Thomas Daniel for lrc contexts. This keeps
> > both sides somewhat in sync and should make Dave Gordon happy.
> >
> > Note that both the wa and the golden context init code suffer a bit
> > from an inssuficient split into driver load and hw init code. Which
> > means we have a bunch of tests all over the place to check whether the
> > one-time initialization has been done already or not.
> >
> > All that one-tim code should be moved into the one-time ring setup
> > code, but that's work for later.
> >
> > Cc: Dave Gordon <david.s.gordon@intel.com>
> > Cc: Thomas Daniel <thomas.daniel@intel.com>
> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> > ---
> > drivers/gpu/drm/i915/i915_gem_context.c | 4 ----
> > drivers/gpu/drm/i915/intel_ringbuffer.c | 18 +++++++++++++++++-
> > 2 files changed, 17 insertions(+), 5 deletions(-)
>
> LGTM :)
> Reviewed-by: Dave Gordon <david.s.gordon@intel.com>
Queued for -next, thanks for the review.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2014-12-08 14:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-02 15:19 [PATCH] drm/i915: Move golden context init into ->init_context Daniel Vetter
2014-12-03 2:54 ` shuang.he
2014-12-08 13:51 ` Dave Gordon
2014-12-08 14:19 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141208141923.GS20350@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=david.s.gordon@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox