From: Daniel Vetter <daniel@ffwll.ch>
To: sonika.jindal@intel.com
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/skl: Correctly updating sprite wm parameter
Date: Tue, 9 Dec 2014 11:27:05 +0100 [thread overview]
Message-ID: <20141209102705.GU27182@phenom.ffwll.local> (raw)
In-Reply-To: <1418102955-14357-1-git-send-email-sonika.jindal@intel.com>
On Tue, Dec 09, 2014 at 10:59:15AM +0530, sonika.jindal@intel.com wrote:
> From: Sonika Jindal <sonika.jindal@intel.com>
>
> The pipe wm parameters is not correctly updated with sprite parameters
> because it copies them for each plane from plane_list to the sprite
> offset in pipe wm parameters. Since plane_list also contains primary and
> cursor planes, we end up updating wrong params for sprites.
>
> Signed-off-by: Sonika Jindal <sonika.jindal@intel.com>
> ---
> drivers/gpu/drm/i915/intel_pm.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index 8d182a6..4a16f9b 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -3301,7 +3301,8 @@ static void skl_compute_wm_pipe_parameters(struct drm_crtc *crtc,
> list_for_each_entry(plane, &dev->mode_config.plane_list, head) {
> struct intel_plane *intel_plane = to_intel_plane(plane);
>
> - if (intel_plane->pipe == pipe)
> + if (intel_plane->pipe == pipe &&
> + plane->type == DRM_PLANE_TYPE_OVERLAY)
> p->plane[i++] = intel_plane->wm;
> }
> }
With the great unification of planes both in hw with skl+ and in software
(with Matt's recent work): Can't we just ditch the cursor/primary plane
special cases?
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2014-12-09 10:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-09 5:29 [PATCH] drm/i915/skl: Correctly updating sprite wm parameter sonika.jindal
2014-12-09 10:27 ` Daniel Vetter [this message]
2014-12-09 11:22 ` Jindal, Sonika
2014-12-09 12:50 ` shuang.he
2014-12-12 14:34 ` Tvrtko Ursulin
2014-12-15 8:55 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141209102705.GU27182@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=sonika.jindal@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox