From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/i9xx: check for panel on pipe before asserting panel unlock bits
Date: Fri, 12 Dec 2014 11:17:19 +0200 [thread overview]
Message-ID: <20141212091719.GM10649@intel.com> (raw)
In-Reply-To: <1418248802-8439-1-git-send-email-jbarnes@virtuousgeek.org>
On Wed, Dec 10, 2014 at 02:00:02PM -0800, Jesse Barnes wrote:
> Should address a warning reported in #79824.
>
> References: https://bugs.freedesktop.org/show_bug.cgi?id=79824
> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
Isn's this fixed by https://freedesktop.org/patch/37900/ ?
> ---
> drivers/gpu/drm/i915/intel_display.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index c424c36..a19544b 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -1607,7 +1607,9 @@ static void i9xx_enable_pll(struct intel_crtc *crtc)
> BUG_ON(INTEL_INFO(dev)->gen >= 5);
>
> /* PLL is protected by panel, make sure we can write it */
> - if (IS_MOBILE(dev) && !IS_I830(dev))
> + if (IS_MOBILE(dev) && !IS_I830(dev) &&
> + (intel_pipe_has_type(crtc, INTEL_OUTPUT_LVDS) ||
> + intel_pipe_has_type(crtc, INTEL_OUTPUT_EDP)))
> assert_panel_unlocked(dev_priv, crtc->pipe);
>
> /* Enable DVO 2x clock on both PLLs if necessary */
> --
> 1.9.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2014-12-12 9:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-10 22:00 [PATCH] drm/i915/i9xx: check for panel on pipe before asserting panel unlock bits Jesse Barnes
2014-12-11 8:40 ` shuang.he
2014-12-11 15:24 ` Jesse Barnes
2014-12-12 9:17 ` Ville Syrjälä [this message]
2014-12-15 9:16 ` Daniel Vetter
2014-12-15 14:59 ` Jani Nikula
2014-12-15 15:28 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141212091719.GM10649@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox