From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: deepak.s@linux.intel.com
Cc: daniel.vetter@ffwll.ch, intel-gfx@lists.freedesktop.org,
Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [PATCH v2] drm/i915/chv: Use timeout mode for RC6 on chv
Date: Fri, 12 Dec 2014 18:34:53 +0200 [thread overview]
Message-ID: <20141212163453.GW10649@intel.com> (raw)
In-Reply-To: <1418451207-30795-1-git-send-email-deepak.s@linux.intel.com>
On Sat, Dec 13, 2014 at 11:43:27AM +0530, deepak.s@linux.intel.com wrote:
> From: Deepak S <deepak.s@linux.intel.com>
>
> Higher RC6 residency is observed using timeout mode
> instead of EI mode. It's Recommended to use TO Method for RC6.
>
> v2: Add comment about timeout threshold. (Tom)
Yeah if TO is better let's just use it. The 1750us value is what
the BIOS spec recommends, so:
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Signed-off-by: Deepak S <deepak.s@linux.intel.com>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Why is Rodrigo's sob here?
> ---
> drivers/gpu/drm/i915/intel_pm.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index 2316d23..2acb3de 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -4689,7 +4689,8 @@ static void cherryview_enable_rps(struct drm_device *dev)
> I915_WRITE(RING_MAX_IDLE(ring->mmio_base), 10);
> I915_WRITE(GEN6_RC_SLEEP, 0);
>
> - I915_WRITE(GEN6_RC6_THRESHOLD, 50000); /* 50/125ms per EI */
> + /* TO threshold set to 1750 us ( 0x557 * 1.28 us) */
> + I915_WRITE(GEN6_RC6_THRESHOLD, 0x557);
>
> /* allows RC6 residency counter to work */
> I915_WRITE(VLV_COUNTER_CONTROL,
> @@ -4703,7 +4704,7 @@ static void cherryview_enable_rps(struct drm_device *dev)
> /* 3: Enable RC6 */
> if ((intel_enable_rc6(dev) & INTEL_RC6_ENABLE) &&
> (pcbr >> VLV_PCBR_ADDR_SHIFT))
> - rc6_mode = GEN6_RC_CTL_EI_MODE(1);
> + rc6_mode = GEN7_RC_CTL_TO_MODE;
>
> I915_WRITE(GEN6_RC_CONTROL, rc6_mode);
>
> --
> 1.9.1
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2014-12-12 16:38 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-12 8:48 [PATCH 1/4] drm/i915/chv: Use timeout mode for RC6 on chv deepak.s
2014-12-12 8:48 ` [PATCH 2/4] drm/i915/chv: Populate total EU count on Cherryview deepak.s
2014-12-11 12:09 ` Jani Nikula
2014-12-12 12:10 ` Deepak S
2014-12-12 12:33 ` [PATCH v2] " deepak.s
2014-12-12 8:48 ` [PATCH 3/4] drm/i915: New offset for reading frequencies on CHV deepak.s
2014-12-12 19:09 ` Ville Syrjälä
2014-12-15 6:51 ` Jani Nikula
2014-12-16 12:11 ` Deepak S
2015-01-16 15:12 ` [PATCH v2 0/3] Use new turbo offset for chv production system deepak.s
2015-01-16 15:12 ` [PATCH v2 1/3] drm/i915/chv: Populate total EU count on Cherryview deepak.s
2015-01-16 16:06 ` Jeff McGee
2015-01-16 17:11 ` Ville Syrjälä
2015-01-19 9:44 ` Daniel Vetter
2015-01-20 3:07 ` Deepak S
2015-01-20 9:06 ` Daniel Vetter
2015-01-16 15:12 ` [PATCH v2 2/3] drm/i915: Increase the range of sideband address deepak.s
2015-01-16 17:11 ` Ville Syrjälä
2015-01-16 15:12 ` [PATCH v2 3/3] drm/i915: New offset for reading frequencies on CHV deepak.s
2015-01-16 17:09 ` Ville Syrjälä
2015-01-17 5:34 ` Deepak S
2015-01-17 5:35 ` [PATCH v3] " deepak.s
2015-01-19 9:47 ` Daniel Vetter
2014-12-12 8:48 ` [PATCH 4/4] drm/i915: Skip gunit save/restore for cherryview deepak.s
2014-12-11 12:02 ` Ville Syrjälä
2014-12-15 15:16 ` Daniel Vetter
2014-12-13 6:13 ` [PATCH v2] drm/i915/chv: Use timeout mode for RC6 on chv deepak.s
2014-12-12 16:34 ` Ville Syrjälä [this message]
2014-12-16 12:09 ` Deepak S
2014-12-15 15:12 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141212163453.GW10649@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=deepak.s@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox