Re: [PATCH v3 4/8] drm/i915: Disable framebuffer compression for i915 driver in VM

Yu, Zhang
2014-12-17T03:16:29Z

On 12/12/2014 9:13 PM, Tvrtko Ursulin wrote:
>
>
> On 11/13/2014 12:02 PM, Yu Zhang wrote:
>> Framebuffer compression is disabled when driver detects it's
>> running in a Intel GVT-g enlightened VM, because FBC is not
>> emulated and there is no stolen memory for a vGPU.
>>
>> v2:
>> take Chris' comments:
>> - move the code into intel_update_fbc()
>>
>> Signed-off-by: Yu Zhang <yu.c.zhang@linux.intel.com>
>> Signed-off-by: Jike Song <jike.song@intel.com>
>> Signed-off-by: Zhiyuan Lv <zhiyuan.lv@intel.com>
>> ---
>> drivers/gpu/drm/i915/intel_pm.c | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_pm.c
>> b/drivers/gpu/drm/i915/intel_pm.c
>> index 7a69eba..3bc5d93 100644
>> --- a/drivers/gpu/drm/i915/intel_pm.c
>> +++ b/drivers/gpu/drm/i915/intel_pm.c
>> @@ -544,6 +544,10 @@ void intel_update_fbc(struct drm_device *dev)
>> return;
>> }
>>
>> + /* disable framebuffer compression in vGPU */
>> + if (intel_vgpu_active(dev))
>> + i915.enable_fbc = 0;
>> +
>> /*
>> * If FBC is already on, we just have to verify that we can
>> * keep it that way...
>>
>
> Looks like you'll need to rebase this one, I see no intel_update_fbc in
> my tree. :(
>
OK. I'll rebase this in next version. :)
> Regards,
>
> Tvrtko