Re: [PATCH v3 1/8] drm/i915: Introduce a PV INFO page structure for Intel GVT-g.

Daniel Vetter
2014-12-15T08:12:20Z

On Thu, Dec 11, 2014 at 05:33:00PM +0000, Tvrtko Ursulin wrote:
> >+struct vgt_if {
> >+ uint64_t magic; /* VGT_MAGIC */
> >+ uint16_t version_major;
> >+ uint16_t version_minor;
> >+ uint32_t vgt_id; /* ID of vGT instance */
> >+ uint32_t rsv1[12]; /* pad to offset 0x40 */
>
> In general I thought stdint types should be avoided in the kernel in favour
> of u32 and company. But I see i915 is full of them already so maybe my
> information is outdated.

That was back when c99 types weren't a common thing, nowadays I think we
should prefer _t types for more uniformity with userspace. Also it makes
the __u32 and similar types which are required for ioctl structs stand out
much more. And yes we're totally inconsistent about it.

Just an aside.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch