From: Daniel Vetter <daniel@ffwll.ch>
To: Rodrigo Vivi <rodrigo.vivi@gmail.com>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>,
Paulo Zanoni <paulo.r.zanoni@intel.com>
Subject: Re: [PATCH 03/11] drm/i915: don't try to find crtcs for FBC if it's disabled
Date: Mon, 15 Dec 2014 09:35:20 +0100 [thread overview]
Message-ID: <20141215083520.GY27182@phenom.ffwll.local> (raw)
In-Reply-To: <CABVU7+sNUi37MrTRB0U9wtBcqwzX89c_PaghVGuRoqoKJmaznQ@mail.gmail.com>
On Fri, Dec 12, 2014 at 04:53:45PM -0800, Rodrigo Vivi wrote:
> On Mon, Dec 8, 2014 at 8:09 AM, Paulo Zanoni <przanoni@gmail.com> wrote:
> > From: Paulo Zanoni <paulo.r.zanoni@intel.com>
> >
> > .. because it would be a waste of time, so move the place where the
> > check is done. Also, with this we won't risk printing "more than one
> > pipe active, disabling compression" or "no output, disabling" when FBC
> > is actually disabled.
> >
> > This patch also represents a small behavior difference when using
> > i915.powersave=0: it is now exactly the same as i915.enable_fbc=0 on
> > this part of the code.
>
> I always ask myself if we should continue using this i915.powersave here.
> I vaguely remember someone complaining when I tried to re-org this
> i915.powersave making it a umbrealla for all powersaving features and
> the complain was to avoid more than one variable for feature... to
> avoid superset of parameters, or something like that.
>
> Or if we keep this here shouldn't we also put this to disable psr?
>
> Anyway this can be another patch. Daniel, please let me know what you
> want with this parameters that I can change that later.
Imo powersave has outlived its usefulness and it can die. We've long ago
started having specific options for this. So maybe create a patch to mark
it as a debug option and then 1 kernel later kill it?
-Daneil
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2014-12-15 8:34 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-08 16:09 [PATCH 00/11] FBC improvements + frontbuffer tracking conversion Paulo Zanoni
2014-12-08 16:09 ` [PATCH 01/11] drm/i915: Move FBC stuff to intel_fbc.c Paulo Zanoni
2014-12-08 16:09 ` [PATCH 02/11] drm/i915: Introduce FBC DocBook Paulo Zanoni
2014-12-08 16:49 ` Daniel Vetter
2014-12-08 14:46 ` [PATCH] " Rodrigo Vivi
2014-12-08 21:48 ` [PATCH 02/11] " Rodrigo Vivi
2014-12-09 9:52 ` Daniel Vetter
2014-12-08 16:09 ` [PATCH 03/11] drm/i915: don't try to find crtcs for FBC if it's disabled Paulo Zanoni
2014-12-13 0:53 ` Rodrigo Vivi
2014-12-15 8:35 ` Daniel Vetter [this message]
2014-12-08 16:09 ` [PATCH 04/11] drm/i915: don't keep reassigning FBC_UNSUPPORTED Paulo Zanoni
2014-12-13 0:55 ` Rodrigo Vivi
2014-12-15 8:37 ` Daniel Vetter
2014-12-08 16:09 ` [PATCH 05/11] drm/i915: change dev_priv->fbc.plane to dev_priv->fbc.crtc Paulo Zanoni
2014-12-13 0:58 ` Rodrigo Vivi
2014-12-08 16:09 ` [PATCH 06/11] drm/i915: pass which operation triggered the frontbuffer tracking Paulo Zanoni
2014-12-08 16:53 ` Daniel Vetter
2014-12-13 1:05 ` Rodrigo Vivi
2014-12-15 8:43 ` Daniel Vetter
2014-12-15 13:58 ` Paulo Zanoni
2014-12-08 16:09 ` [PATCH 07/11] drm/i915: also do frontbuffer tracking on pwrites Paulo Zanoni
2014-12-08 16:55 ` Daniel Vetter
2014-12-13 1:10 ` Rodrigo Vivi
2014-12-15 8:39 ` Daniel Vetter
2014-12-08 16:09 ` [PATCH 08/11] drm/i915: add fronbuffer tracking to FBC Paulo Zanoni
2014-12-13 1:12 ` [PATCH 6/9] drm/i915: add frontbuffer " Rodrigo Vivi
2014-12-13 1:16 ` [PATCH 08/11] drm/i915: add fronbuffer " Rodrigo Vivi
2014-12-15 14:00 ` [PATCH 8/11] drm/i915: add frontbuffer " Paulo Zanoni
2014-12-08 16:09 ` [PATCH 09/11] drm/i915: extract intel_fbc_find_crtc() Paulo Zanoni
2014-12-13 1:20 ` Rodrigo Vivi
2014-12-08 16:09 ` [PATCH 10/11] drm/i915: HSW+ FBC is tied to pipe A Paulo Zanoni
2014-12-13 1:23 ` Rodrigo Vivi
2014-12-15 8:41 ` Daniel Vetter
2014-12-08 16:09 ` [PATCH 11/11] drm/i915: gen5+ can have FBC with multiple pipes Paulo Zanoni
2014-12-09 16:08 ` shuang.he
2014-12-13 1:25 ` Rodrigo Vivi
2014-12-08 16:12 ` [PATCH igt 1/4] lib: add igt_wait() Paulo Zanoni
2014-12-08 16:12 ` [PATCH igt 2/4] tests/kms_fb_crc: call gem_sync() instead of gem_bo_busy() Paulo Zanoni
2014-12-08 16:12 ` [PATCH igt 3/4] tests/kms_fbc_crc: add wait_for_fbc_enabled() Paulo Zanoni
2014-12-08 16:12 ` [PATCH igt 4/4] tests/kms_fbc_crc: also gem_sync() on exec_nop() Paulo Zanoni
2014-12-08 16:40 ` [PATCH igt 1/4] lib: add igt_wait() Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141215083520.GY27182@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=paulo.r.zanoni@intel.com \
--cc=rodrigo.vivi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox