From: Daniel Vetter <daniel@ffwll.ch>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/skl: Correctly updating sprite wm parameter
Date: Mon, 15 Dec 2014 09:55:13 +0100 [thread overview]
Message-ID: <20141215085513.GF27182@phenom.ffwll.local> (raw)
In-Reply-To: <548AFCFD.6000604@linux.intel.com>
On Fri, Dec 12, 2014 at 02:34:37PM +0000, Tvrtko Ursulin wrote:
>
> On 12/09/2014 05:29 AM, sonika.jindal@intel.com wrote:
> >From: Sonika Jindal <sonika.jindal@intel.com>
> >
> >The pipe wm parameters is not correctly updated with sprite parameters
> >because it copies them for each plane from plane_list to the sprite
> >offset in pipe wm parameters. Since plane_list also contains primary and
> >cursor planes, we end up updating wrong params for sprites.
> >
> >Signed-off-by: Sonika Jindal <sonika.jindal@intel.com>
> >---
> > drivers/gpu/drm/i915/intel_pm.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> >diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> >index 8d182a6..4a16f9b 100644
> >--- a/drivers/gpu/drm/i915/intel_pm.c
> >+++ b/drivers/gpu/drm/i915/intel_pm.c
> >@@ -3301,7 +3301,8 @@ static void skl_compute_wm_pipe_parameters(struct drm_crtc *crtc,
> > list_for_each_entry(plane, &dev->mode_config.plane_list, head) {
> > struct intel_plane *intel_plane = to_intel_plane(plane);
> >
> >- if (intel_plane->pipe == pipe)
> >+ if (intel_plane->pipe == pipe &&
> >+ plane->type == DRM_PLANE_TYPE_OVERLAY)
> > p->plane[i++] = intel_plane->wm;
> > }
> > }
> >
>
> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Queued for -next, thanks for the patch.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2014-12-15 8:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-09 5:29 [PATCH] drm/i915/skl: Correctly updating sprite wm parameter sonika.jindal
2014-12-09 10:27 ` Daniel Vetter
2014-12-09 11:22 ` Jindal, Sonika
2014-12-09 12:50 ` shuang.he
2014-12-12 14:34 ` Tvrtko Ursulin
2014-12-15 8:55 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141215085513.GF27182@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox