From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Roper Subject: Re: [PATCH 5/8] drm/i915: Don't access to crtc->new_config from intel_mode_max_pixclk() Date: Mon, 15 Dec 2014 11:17:45 -0800 Message-ID: <20141215191745.GE31948@intel.com> References: <1418301491-23020-1-git-send-email-ander.conselvan.de.oliveira@intel.com> <1418301491-23020-6-git-send-email-ander.conselvan.de.oliveira@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 9FFBC6E219 for ; Mon, 15 Dec 2014 11:18:03 -0800 (PST) Content-Disposition: inline In-Reply-To: <1418301491-23020-6-git-send-email-ander.conselvan.de.oliveira@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ander Conselvan de Oliveira Cc: intel-gfx@lists.freedesktop.org, shuang.he@linux.intel.com List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBEZWMgMTEsIDIwMTQgYXQgMDI6Mzg6MDhQTSArMDIwMCwgQW5kZXIgQ29uc2VsdmFu IGRlIE9saXZlaXJhIHdyb3RlOgo+IFNvIHRoYXQgd2UgY2FuIGdldCByaWQgb2YgdGhlIG5ld19j b25maWcgcG9pbnRlciBsYXRlci4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBBbmRlciBDb25zZWx2YW4g ZGUgT2xpdmVpcmEgPGFuZGVyLmNvbnNlbHZhbi5kZS5vbGl2ZWlyYUBpbnRlbC5jb20+Cj4gLS0t Cj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyB8IDMwICsrKysrKysrKysr KysrKysrKysrKystLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMjIgaW5zZXJ0aW9ucygrKSwg OCBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZGlzcGxheS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gaW5k ZXggZGE1YWYyMy4uYTlmMzAzNCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9kaXNwbGF5LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5 LmMKPiBAQCAtNDg5NywyNyArNDg5NywzOSBAQCBzdGF0aWMgaW50IHZhbGxleXZpZXdfY2FsY19j ZGNsayhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gIH0KPiAgCj4gIC8qIGNv bXB1dGUgdGhlIG1heCBwaXhlbCBjbG9jayBmb3IgbmV3IGNvbmZpZ3VyYXRpb24gKi8KPiAtc3Rh dGljIGludCBpbnRlbF9tb2RlX21heF9waXhjbGsoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRl dl9wcml2KQo+ICtzdGF0aWMgaW50IGludGVsX21vZGVfbWF4X3BpeGNsayhzdHJ1Y3QgZHJtX2k5 MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gKwkJCQkgc3RydWN0IGludGVsX2NydGMgKm1vZGVfc2V0 X2NydGMsCgpJJ20gbm90IHN1cmUgaWYgeW91IG5lZWQgdG8gcGFzcyB0aGlzLiAgZHJtX2NydGNf c3RhdGUgaGFzIGEgYmFja3BvaW50ZXIKdG8gdGhlIGNvcnJlc3BvbmRpbmcgZHJtX2NydGMgbm93 LCBzbyBpZiB3ZSBlbnN1cmUgdGhhdCdzIHNldCBieSBvdXIKZHJpdmVyIHdoZW4gY3JlYXRpbmcg YSBuZXcgcGlwZV9jb25maWcsIHdlIGNvdWxkIHByb2JhYmx5IGdldCBhd2F5IHdpdGgKanVzdCBw YXNzaW5nIHRoZSBzdGF0ZSBoZXJlLgoKPiArCQkJCSBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAq Y3J0Y19uZXdfc3RhdGUpCj4gIHsKPiAgCXN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBkZXZfcHJp di0+ZGV2Owo+ICAJc3RydWN0IGludGVsX2NydGMgKmludGVsX2NydGM7Cj4gIAlpbnQgbWF4X3Bp eGNsayA9IDA7Cj4gKwlpbnQgcGl4Y2xrOwo+ICAKPiAgCWZvcl9lYWNoX2ludGVsX2NydGMoZGV2 LCBpbnRlbF9jcnRjKSB7Cj4gLQkJaWYgKGludGVsX2NydGMtPm5ld19lbmFibGVkKQo+IC0JCQlt YXhfcGl4Y2xrID0gbWF4KG1heF9waXhjbGssCj4gLQkJCQkJIGludGVsX2NydGMtPm5ld19jb25m aWctPmJhc2UuYWRqdXN0ZWRfbW9kZS5jcnRjX2Nsb2NrKTsKPiArCQlpZiAoIWludGVsX2NydGMt Pm5ld19lbmFibGVkKQo+ICsJCQljb250aW51ZTsKCk5vdCByZWFsbHkgcmVsYXRlZCB0byB0aGlz IHBhdGNoIHNwZWNpZmljYWxseSwgYnV0IEknbSBhIGxpdHRsZSBmdXp6eSBvbgp0aGUgZGlzdGlu Y3Rpb24gYmV0d2VlbiBkcm1fY3J0Yy0+ZW5hYmxlZCBhbmQgZHJtX2NydGNfc3RhdGUtPmVuYWJs ZQooYW5kIHRoZW4gYnkgZXh0ZW5zaW9uIGludGVsX2NydGMtPm5ld19lbmFibGVkKS4gIEl0J3Mg bm90IGltbWVkaWF0ZWx5CmNsZWFyIHRvIG1lIHdoeSB3ZSBjYW4ndCBqdXN0IGhhdmUgYSBzaW5n bGUgJ2VuYWJsZWQnIGluIHRoZSBiYXNlIHN0YXRlCnN0cnVjdHVyZSBhbmQgdGhlbiB3aGVuIHdl IGhhdmUgYSBuZXcgY29uZmlnIHRoYXQgd2UncmUgcGFzc2luZyBhcm91bmQsCnRoZSBlbmFibGVk IGZsYWcgaW4gdGhhdCBzdHJ1Y3R1cmUgd291bGQgc2VydmUgdGhlIHB1cnBvc2UgdGhhdAppbnRl bF9jcnRjLT5uZXdfZW5hYmxlZCBkb2VzIGZvciBpOTE1IHRvZGF5LiAgSSdtIHByb2JhYmx5Cm1p c3VuZGVyc3RhbmRpbmcgc29tZXRoaW5nLgoKCk1hdHQKCj4gKwo+ICsJCWlmIChpbnRlbF9jcnRj ID09IG1vZGVfc2V0X2NydGMpCj4gKwkJCXBpeGNsayA9IGNydGNfbmV3X3N0YXRlLT5iYXNlLmFk anVzdGVkX21vZGUuY3J0Y19jbG9jazsKPiArCQllbHNlCj4gKwkJCXBpeGNsayA9IGludGVsX2Ny dGMtPmNvbmZpZy0+YmFzZS5hZGp1c3RlZF9tb2RlLmNydGNfY2xvY2s7Cj4gKwo+ICsJCW1heF9w aXhjbGsgPSBtYXgobWF4X3BpeGNsaywgcGl4Y2xrKTsKPiAgCX0KPiAgCj4gIAlyZXR1cm4gbWF4 X3BpeGNsazsKPiAgfQo+ICAKPiAgc3RhdGljIHZvaWQgdmFsbGV5dmlld19tb2Rlc2V0X2dsb2Jh bF9waXBlcyhzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+IC0JCQkJCSAgICB1bnNpZ25lZCAqcHJl cGFyZV9waXBlcykKPiArCQkJCQkgICAgdW5zaWduZWQgKnByZXBhcmVfcGlwZXMsCj4gKwkJCQkJ ICAgIHN0cnVjdCBpbnRlbF9jcnRjICptb2RlX3NldF9jcnRjLAo+ICsJCQkJCSAgICBzdHJ1Y3Qg aW50ZWxfY3J0Y19zdGF0ZSAqY3J0Y19uZXdfc3RhdGUpCj4gIHsKPiAgCXN0cnVjdCBkcm1faTkx NV9wcml2YXRlICpkZXZfcHJpdiA9IGRldi0+ZGV2X3ByaXZhdGU7Cj4gIAlzdHJ1Y3QgaW50ZWxf Y3J0YyAqaW50ZWxfY3J0YzsKPiAtCWludCBtYXhfcGl4Y2xrID0gaW50ZWxfbW9kZV9tYXhfcGl4 Y2xrKGRldl9wcml2KTsKPiArCWludCBtYXhfcGl4Y2xrID0KPiArCQlpbnRlbF9tb2RlX21heF9w aXhjbGsoZGV2X3ByaXYsIG1vZGVfc2V0X2NydGMsIGNydGNfbmV3X3N0YXRlKTsKPiAgCj4gIAlp ZiAodmFsbGV5dmlld19jYWxjX2NkY2xrKGRldl9wcml2LCBtYXhfcGl4Y2xrKSA9PQo+ICAJICAg IGRldl9wcml2LT52bHZfY2RjbGtfZnJlcSkKPiBAQCAtNDkzMiw3ICs0OTQ0LDcgQEAgc3RhdGlj IHZvaWQgdmFsbGV5dmlld19tb2Rlc2V0X2dsb2JhbF9waXBlcyhzdHJ1Y3QgZHJtX2RldmljZSAq ZGV2LAo+ICBzdGF0aWMgdm9pZCB2YWxsZXl2aWV3X21vZGVzZXRfZ2xvYmFsX3Jlc291cmNlcyhz dHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ICB7Cj4gIAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAq ZGV2X3ByaXYgPSBkZXYtPmRldl9wcml2YXRlOwo+IC0JaW50IG1heF9waXhjbGsgPSBpbnRlbF9t b2RlX21heF9waXhjbGsoZGV2X3ByaXYpOwo+ICsJaW50IG1heF9waXhjbGsgPSBpbnRlbF9tb2Rl X21heF9waXhjbGsoZGV2X3ByaXYsIE5VTEwsIE5VTEwpOwo+ICAJaW50IHJlcV9jZGNsayA9IHZh bGxleXZpZXdfY2FsY19jZGNsayhkZXZfcHJpdiwgbWF4X3BpeGNsayk7Cj4gIAo+ICAJaWYgKHJl cV9jZGNsayAhPSBkZXZfcHJpdi0+dmx2X2NkY2xrX2ZyZXEpIHsKPiBAQCAtMTA5NTYsNyArMTA5 NjgsOSBAQCBzdGF0aWMgaW50IF9faW50ZWxfc2V0X21vZGUoc3RydWN0IGRybV9jcnRjICpjcnRj LAo+ICAJICogYWRqdXN0ZWRfbW9kZSBiaXRzIGluIHRoZSBjcnRjIGRpcmVjdGx5Lgo+ICAJICov Cj4gIAlpZiAoSVNfVkFMTEVZVklFVyhkZXYpKSB7Cj4gLQkJdmFsbGV5dmlld19tb2Rlc2V0X2ds b2JhbF9waXBlcyhkZXYsICZwcmVwYXJlX3BpcGVzKTsKPiArCQl2YWxsZXl2aWV3X21vZGVzZXRf Z2xvYmFsX3BpcGVzKGRldiwgJnByZXBhcmVfcGlwZXMsCj4gKwkJCQkJCXRvX2ludGVsX2NydGMo Y3J0YyksCj4gKwkJCQkJCXBpcGVfY29uZmlnKTsKPiAgCj4gIAkJLyogbWF5IGhhdmUgYWRkZWQg bW9yZSB0byBwcmVwYXJlX3BpcGVzIHRoYW4gd2Ugc2hvdWxkICovCj4gIAkJcHJlcGFyZV9waXBl cyAmPSB+ZGlzYWJsZV9waXBlczsKPiAtLSAKPiAxLjkuMQo+IAo+IF9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+ IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4CgotLSAKTWF0dCBSb3BlcgpHcmFwaGlj cyBTb2Z0d2FyZSBFbmdpbmVlcgpJb1RHIFBsYXRmb3JtIEVuYWJsaW5nICYgRGV2ZWxvcG1lbnQK SW50ZWwgQ29ycG9yYXRpb24KKDkxNikgMzU2LTI3OTUKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9pbnRlbC1nZngK